public inbox for linux-arm-msm@vger.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>,
	linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Aditya Pakki <pakki001@umn.edu>,
	Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
	Qiushi Wu <wu000273@umn.edu>, Andy Gross <agross@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Stanimir Varbanov <stanimir.varbanov@linaro.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v3] media: venus: core: Fix runtime PM imbalance in venus_probe()
Date: Sun, 28 Jun 2020 15:16:23 +0200	[thread overview]
Message-ID: <9797fb44-e10e-61b5-b2cc-82d94cc98a3c@web.de> (raw)

> when it returns an error code. Thus a pairing decrement is needed on

* I find it more appropriate to use the word “corresponding” here
  (if you do still not like previous wording suggestions).

* Will it become helpful to add the tag “Fixes” to the commit message?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=719fdd32921fb7e3208db8832d32ae1c2d68900f#n183

* Would you like to improve the change description any more?


> ---
>  drivers/media/platform/qcom/venus/core.c | 5 ++++-

I suggest replace the triple dashes before this diffstat by a blank line.

Regards,
Markus

                 reply	other threads:[~2020-06-28 13:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9797fb44-e10e-61b5-b2cc-82d94cc98a3c@web.de \
    --to=markus.elfring@web.de \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=dinghao.liu@zju.edu.cn \
    --cc=emamd001@umn.edu \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kjlu@umn.edu \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pakki001@umn.edu \
    --cc=stanimir.varbanov@linaro.org \
    --cc=wu000273@umn.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox