From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB295329E69 for ; Wed, 7 Jan 2026 14:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767794743; cv=none; b=qFN23NAfQnNLcj8KDNhRL319PN0njQ0cK6aM3znYG0w3D+qmJ89p3zhj0VwTvQLqqqKcnuC3Wukorrr3B5rddb5X4OX46pcOl6UFd6lw0njJAUe3KmlCS4YyLnJFzT5tLK6TmTtrtLaPiMvhXuFxie8I6EYo/5KINkQL699cr18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767794743; c=relaxed/simple; bh=kHO1GfgESNMw3/GQ6yHWd3+WOk49vjbI2/ozirdvW5E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b6Hh72mhH2x284qPGDD2PlC/OpibZalfBLL5g2KvoxnukuOu/x5urHeuJRNABtHUmCzHiXpTjWCfQhEAGE84V772p4QaSyv0dd42ezIia6FaY5isYRLzGDbNejVyfkjApuJ3RLZIsbxgd2z2LIdBkj3pgUlc+fVYwy79WyTihdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ldoPIHBj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aX7GE31L; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ldoPIHBj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aX7GE31L" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6079f2sd2989967 for ; Wed, 7 Jan 2026 14:05:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /dYPUxZoqHhXGVsRsNUTNCnu3BPPm6di+RgA5mKj+Cc=; b=ldoPIHBjr0J4Kklj EQjEnUa8ADWp9M7lYVVQn39SuIKTOBnYVM+rnhq0BcizUeNc5pmtXvvvucdhRNAL eLxUu+pIDjBKo1JXCE8V/3aLZyN0sLl1eo3vDPGBP0ZXoNHe4C8wWTKIRBmUPYiz vtWqBRa4AGMmBRui9uWMmpfJRTq4sCzHEdUOXDKybVXNwysnyfblEcjA8X5P88Fr MQoS57S+Yp4tigvLlL7s9r+aw6edTjYIRzjjypt8NOpCHMCL8EzS5dHw2wvyhAhT O/KByy83gabv1tWoPgonqHidobYG5nOyzvr51B/ABKtXH6cbaenHnlrpKUFunK30 gc0uaw== Received: from mail-yx1-f71.google.com (mail-yx1-f71.google.com [74.125.224.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bhn2nrrc1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 07 Jan 2026 14:05:40 +0000 (GMT) Received: by mail-yx1-f71.google.com with SMTP id 956f58d0204a3-640e5edbce4so561935d50.1 for ; Wed, 07 Jan 2026 06:05:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767794740; x=1768399540; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/dYPUxZoqHhXGVsRsNUTNCnu3BPPm6di+RgA5mKj+Cc=; b=aX7GE31LawS9Nqr/HA5fJq8uDSA7i0OIB3KF9KwlaSIPCs/mZhHvfAme4k32uH+gqz HPci4mmyywX6CV4tZmrMpB2qGsZMx2ZsoYc2UzfDMFu033QfqwGwAiUwhf1fuewbscjW ThDLTtri+gNPZ6E1oz03ws1msWLfrHsk4kw8uDDxwLL8j552d6X0UkdGnWke1Ps4fGdx yM6IJXf+Cw7D7+KR8rgpQ6lTLsjIo13A4fX/66joR3FgYuIDHtZOReTmyCJAteMTOxGA cKKZQ0XgbeUhqpg3bvvqRxh+mth9ra9UHShJhuoAiYfCVZPatSyMAHSwZvzOn528jyB6 wLag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767794740; x=1768399540; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/dYPUxZoqHhXGVsRsNUTNCnu3BPPm6di+RgA5mKj+Cc=; b=OL8A+7wRdUks5ADpH8rWVV8UE2EyN5z/1/c73Irbis5jzvw+ssDImL6dV9SnvYRVuo miIYLYY09KH36pR/6BWQDq4xXV/ElsrJ92QduByPBFx9eqmj2GPTrmbg+5Zj1X4qU7xl n5//9oqXdUVG/A7D0AYFSbRr5OTBaee2XICSc0VzxdM5be2wVUvlDA6af8xnm9CJdHJP duFdwH1P1ewlQLac0ld4I88UA2Hhm+ABIcplX/0W89YE72XJAbP03mTlldffEDWUwdeW z3aI2u5PVRksvLQj3xICzc8m6siuqAk8JofvqiOUcaGDm26CWnoaPG0VaJeqX83/VzGe 3WiQ== X-Forwarded-Encrypted: i=1; AJvYcCUSbx46mRt4F/HhUsf78Bz+pRNtqxLXtINZKQJmb7LJ+Knd04wc0993/sMnm61G6IvyrjU/K3EYF9/x6OKB@vger.kernel.org X-Gm-Message-State: AOJu0YyYw12MaYwkTuUML1GlS8I2Fathkl55F+oZDyyfmVfhIMVNrJqM fVeYf+NdQHAKtdimwoDiUwHTZsDOyLcpHKnpmc0TbMgiz+8CqSC3Mkyj5Sr5uUlXicZltURo5ga S6vupkE6scs31swXHDqQBahADFRQl4pS4TzSwMm+OHkDo1/4D4Clnj3dcYrWdvZMtxXz+ X-Gm-Gg: AY/fxX6vEtsR+sjwtJ00KhjRRknCcW+kyFcFGO9Iwiy1gE4rSysJLqOo0FycISZ9Fux bMtzpv5ExXDtFUz5eW+Q5Uwtx/zR9H3MRQWbQK+H7pdWeqnNtNB16QS7upJtSmOp1msJPMuY2g7 TWWjq8NOQw7LrbSCcWNuM2kDuS4O9iTlb5iQbb08rbZf4i8hf4ZMuA0QcseCDg8VucvLdSsFJwy k3d6fkRGW3e/g/eSY+F3Q1W1oFX81b5MSbpEeoqgI/W54Mf6ubNbv1U9vIqgPVkXEQl7Kt1unh7 CEy/4iN+B0LC+M9Tzun8mwS4Z0ptTGee12gpdMy6jn/+2M8YUInx+gKQpZ6u5CtvZMIz7NsrtKn bQtJHsgojcRiI7JvDYSzprviBHOvpP2SU8OSm2D+rvjx0DY4CZLfUHSp40/6ZCA25Rxc= X-Received: by 2002:a05:690e:161c:b0:63f:b410:e8d with SMTP id 956f58d0204a3-64716c7da8cmr1450669d50.6.1767794740219; Wed, 07 Jan 2026 06:05:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IFuk8dtNnNc7djajDkI2qFNJzxGYcVWgt4Hwy4aMZohg0n1wAnt/4mZtVfjRdh0tsRspfFjoQ== X-Received: by 2002:a05:690e:161c:b0:63f:b410:e8d with SMTP id 956f58d0204a3-64716c7da8cmr1450573d50.6.1767794737711; Wed, 07 Jan 2026 06:05:37 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a27c755sm527241966b.18.2026.01.07.06.05.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 06:05:36 -0800 (PST) Message-ID: <990bc3d5-40d7-46c8-9e14-192aac7fd2cc@oss.qualcomm.com> Date: Wed, 7 Jan 2026 15:05:33 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] backlight: qcom-wled: Support ovp values for PMI8950 To: =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Kiran Gunda , Helge Deller , Luca Weiss , Konrad Dybcio , Eugene Lepshy , Gianluca Boiano , Alejandro Tafalla Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Thompson , linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org References: <20260107-pmi8950-wled-v1-0-5e52f5caa39c@mainlining.org> <20260107-pmi8950-wled-v1-2-5e52f5caa39c@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260107-pmi8950-wled-v1-2-5e52f5caa39c@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA3MDEwOSBTYWx0ZWRfX/ZDNFU8UAa2u r8C7nXi7gh3qxSVFjKMUzzwTBCAUbvSL12imzLxSxbCunxyxAaaor4zERUKZGPYaYL/0PLpUV/E TV8uk6KZw17MSwVarGtS5oUCGXXYM6/M+x9AZZtuWZJARNwSh1RK8rbCmtkNUHjEu2HRZB+pwM6 hdGATLOxJzG9xWeEuPSAMR6Q9C3uy7SR+uOU4lmaXQWitSnfVErW4JexS4CV+jlYjfI+IWkN9u/ dI4TP1SR+eAWs99G9UQ3nEPRhR+EjqXlDXK3Fwqj03LWsilSnjTgMpRwGLrMJE9jIkJWEv9axd2 NR08Z8mI1ZzFuQymh2y1cj03dnyThMH3crt4JLdH0I0inw8LijbiFvCO839XKaj/8pYxrFkVYSU Edw+gOBGZIxvK3hUj3SDpn1FNv0SrWmMC42dL2wMeLaFzCKoCd+iN2XKgpKStuuXlAPWM4YGhrU voFdQLbS/Fm9/SiUHmg== X-Authority-Analysis: v=2.4 cv=CYEFJbrl c=1 sm=1 tr=0 ts=695e6834 cx=c_pps a=ngMg22mHWrP7m7pwYf9JkA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=OuZLqq7tAAAA:8 a=EUspDBNiAAAA:8 a=M3M7KMW9Y1EPzfeyKr8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=yHXA93iunegOHmWoMUFd:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-GUID: JpKi8oO794e42MxryLTNUWyk_Vy0IOOC X-Proofpoint-ORIG-GUID: JpKi8oO794e42MxryLTNUWyk_Vy0IOOC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-07_02,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 spamscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601070109 On 1/7/26 2:31 PM, Barnabás Czémán wrote: > WLED4 found in PMI8950 supports different ovp values. > > Fixes: 10258bf4534bf ("backlight: qcom-wled: Add PMI8950 compatible") > Signed-off-by: Barnabás Czémán > --- [...] > case 4: > - u32_opts = wled4_opts; > - size = ARRAY_SIZE(wled4_opts); > + if (of_device_is_compatible(dev->of_node, "qcom,pmi8950-wled")) { > + u32_opts = pmi8950_wled4_opts; > + size = ARRAY_SIZE(pmi8950_wled4_opts); > + } else { > + u32_opts = wled4_opts; > + size = ARRAY_SIZE(wled4_opts); > + } I really don't like how this driver went about abstracting parsing all of that, but that's not your fault Reviewed-by: Konrad Dybcio Konrad