Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Helen Koike <helen.koike@collabora.com>
To: Vignesh Raman <vignesh.raman@collabora.com>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org
Cc: daniels@collabora.com, sean@poorly.run,
	guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com,
	robdclark@gmail.com, quic_abhinavk@quicinc.com,
	david.heidelberg@collabora.com, dmitry.baryshkov@linaro.org,
	marijn.suijten@somainline.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] drm/ci: add sc7180-trogdor-kingoftown
Date: Mon, 15 Jan 2024 12:24:52 -0300	[thread overview]
Message-ID: <9a968260-e7a2-45fb-9a3b-1a8e15d49018@collabora.com> (raw)
In-Reply-To: <20240104081435.1936059-1-vignesh.raman@collabora.com>



On 04/01/2024 05:14, Vignesh Raman wrote:
> Add job that executes the IGT test suite for sc7180-trogdor-kingoftown.
> This commit also updates xfails for sc7180-trogdor-lazor-limozeen.
> 
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>

lgtm

Acked-by: Helen Koike <helen.koike@collabora.com>

Thanks
Helen

> ---
> 
> See pipeline: https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1069934
> 
> ---
>   drivers/gpu/drm/ci/build.sh                   |  1 +
>   drivers/gpu/drm/ci/test.yml                   | 25 ++++++++++++----
>   .../gpu/drm/ci/xfails/msm-sc7180-fails.txt    | 30 -------------------
>   .../gpu/drm/ci/xfails/msm-sc7180-flakes.txt   | 17 -----------
>   .../gpu/drm/ci/xfails/msm-sc7180-skips.txt    |  7 -----
>   .../msm-sc7180-trogdor-kingoftown-fails.txt   | 17 +++++++++++
>   ...sm-sc7180-trogdor-lazor-limozeen-fails.txt | 17 +++++++++++
>   7 files changed, 55 insertions(+), 59 deletions(-)
>   delete mode 100644 drivers/gpu/drm/ci/xfails/msm-sc7180-fails.txt
>   delete mode 100644 drivers/gpu/drm/ci/xfails/msm-sc7180-flakes.txt
>   delete mode 100644 drivers/gpu/drm/ci/xfails/msm-sc7180-skips.txt
>   create mode 100644 drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-kingoftown-fails.txt
>   create mode 100644 drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-lazor-limozeen-fails.txt
> 
> diff --git a/drivers/gpu/drm/ci/build.sh b/drivers/gpu/drm/ci/build.sh
> index 97ff43759b91..331a61e0d25a 100644
> --- a/drivers/gpu/drm/ci/build.sh
> +++ b/drivers/gpu/drm/ci/build.sh
> @@ -26,6 +26,7 @@ if [[ "$KERNEL_ARCH" = "arm64" ]]; then
>       DEVICE_TREES+=" arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb"
>       DEVICE_TREES+=" arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dtb"
>       DEVICE_TREES+=" arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dtb"
> +    DEVICE_TREES+=" arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtb"
>   elif [[ "$KERNEL_ARCH" = "arm" ]]; then
>       GCC_ARCH="arm-linux-gnueabihf"
>       DEBIAN_ARCH="armhf"
> diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml
> index a079f3632a95..0c7920c0254d 100644
> --- a/drivers/gpu/drm/ci/test.yml
> +++ b/drivers/gpu/drm/ci/test.yml
> @@ -82,20 +82,35 @@
>     tags:
>       - $RUNNER_TAG
>   
> -msm:sc7180:
> +.msm-sc7180:
>     extends:
>       - .lava-igt:arm64
>     stage: msm
> -  parallel: 4
>     variables:
>       DRIVER_NAME: msm
> -    DEVICE_TYPE: sc7180-trogdor-lazor-limozeen
> -    DTB: sc7180-trogdor-lazor-limozeen-nots-r5
>       BOOT_METHOD: depthcharge
>       KERNEL_IMAGE_TYPE: ""
> -    GPU_VERSION: sc7180
> +
> +msm:sc7180-trogdor-lazor-limozeen:
> +  extends:
> +    - .msm-sc7180
> +  parallel: 4
> +  variables:
> +    DEVICE_TYPE: sc7180-trogdor-lazor-limozeen
> +    DTB: sc7180-trogdor-lazor-limozeen-nots-r5
> +    GPU_VERSION: ${DEVICE_TYPE}
>       RUNNER_TAG: mesa-ci-x86-64-lava-sc7180-trogdor-lazor-limozeen
>   
> +msm:sc7180-trogdor-kingoftown:
> +  extends:
> +    - .msm-sc7180
> +  parallel: 6
> +  variables:
> +    DEVICE_TYPE: sc7180-trogdor-kingoftown
> +    DTB: sc7180-trogdor-kingoftown
> +    GPU_VERSION: ${DEVICE_TYPE}
> +    RUNNER_TAG: mesa-ci-x86-64-lava-sc7180-trogdor-kingoftown
> +
>   msm:apq8016:
>     extends:
>       - .baremetal-igt-arm64
> diff --git a/drivers/gpu/drm/ci/xfails/msm-sc7180-fails.txt b/drivers/gpu/drm/ci/xfails/msm-sc7180-fails.txt
> deleted file mode 100644
> index f71166a57731..000000000000
> --- a/drivers/gpu/drm/ci/xfails/msm-sc7180-fails.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -kms_color@ctm-0-25,Fail
> -kms_color@ctm-0-50,Fail
> -kms_color@ctm-0-75,Fail
> -kms_color@ctm-blue-to-red,Fail
> -kms_color@ctm-green-to-red,Fail
> -kms_color@ctm-negative,Fail
> -kms_color@ctm-red-to-blue,Fail
> -kms_color@ctm-signed,Fail
> -kms_cursor_legacy@cursor-vs-flip-toggle,Fail
> -kms_cursor_legacy@cursor-vs-flip-varying-size,Fail
> -kms_cursor_legacy@cursorA-vs-flipA-atomic-transitions,Crash
> -kms_flip@flip-vs-modeset-vs-hang,Fail
> -kms_flip@flip-vs-panning-vs-hang,Fail
> -kms_pipe_crc_basic@compare-crc-sanitycheck-nv12,Fail
> -kms_plane_alpha_blend@alpha-7efc,Fail
> -kms_plane_alpha_blend@coverage-7efc,Fail
> -kms_plane_alpha_blend@coverage-vs-premult-vs-constant,Fail
> -kms_plane_alpha_blend@pipe-A-alpha-7efc,Fail
> -kms_plane_alpha_blend@pipe-A-coverage-7efc,Fail
> -kms_plane_alpha_blend@pipe-A-coverage-vs-premult-vs-constant,Fail
> -kms_plane_alpha_blend@pipe-B-alpha-7efc,Fail
> -kms_plane_alpha_blend@pipe-B-alpha-basic,Fail
> -kms_plane_alpha_blend@pipe-B-alpha-opaque-fb,Fail
> -kms_plane_alpha_blend@pipe-B-constant-alpha-max,Fail
> -kms_plane_alpha_blend@pipe-B-constant-alpha-mid,Fail
> -kms_plane_alpha_blend@pipe-B-coverage-7efc,Fail
> -kms_plane_alpha_blend@pipe-B-coverage-vs-premult-vs-constant,Fail
> -kms_rmfb@close-fd,Fail
> -kms_universal_plane@disable-primary-vs-flip-pipe-b,Fail
> -kms_universal_plane@universal-plane-pipe-B-sanity,Fail
> diff --git a/drivers/gpu/drm/ci/xfails/msm-sc7180-flakes.txt b/drivers/gpu/drm/ci/xfails/msm-sc7180-flakes.txt
> deleted file mode 100644
> index 04730044ed12..000000000000
> --- a/drivers/gpu/drm/ci/xfails/msm-sc7180-flakes.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -kms_color@ctm-0-25
> -kms_color@ctm-0-50
> -kms_color@ctm-0-75
> -kms_color@ctm-blue-to-red
> -kms_color@ctm-green-to-red
> -kms_color@ctm-negative
> -kms_color@ctm-red-to-blue
> -kms_color@ctm-signed
> -kms_flip@flip-vs-modeset-vs-hang
> -kms_flip@flip-vs-panning-vs-hang
> -kms_plane@pixel-format
> -kms_plane@pixel-format-source-clamping
> -kms_plane@plane-position-covered
> -kms_plane@plane-position-hole
> -kms_plane@plane-position-hole-dpms
> -kms_writeback@writeback-fb-id
> -kms_writeback@writeback-invalid-parameters
> diff --git a/drivers/gpu/drm/ci/xfails/msm-sc7180-skips.txt b/drivers/gpu/drm/ci/xfails/msm-sc7180-skips.txt
> deleted file mode 100644
> index e59a2fddfde0..000000000000
> --- a/drivers/gpu/drm/ci/xfails/msm-sc7180-skips.txt
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -# Suspend to RAM seems to be broken on this machine
> -.*suspend.*
> -
> -# Test incorrectly assumes that CTM support implies gamma/degamma
> -# LUT support.  None of the subtests handle the case of only having
> -# CTM support
> -#kms_color.*
> diff --git a/drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-kingoftown-fails.txt b/drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-kingoftown-fails.txt
> new file mode 100644
> index 000000000000..7e4d8744fcc6
> --- /dev/null
> +++ b/drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-kingoftown-fails.txt
> @@ -0,0 +1,17 @@
> +kms_color@ctm-0-25,Fail
> +kms_color@ctm-0-50,Fail
> +kms_color@ctm-0-75,Fail
> +kms_color@ctm-blue-to-red,Fail
> +kms_color@ctm-green-to-red,Fail
> +kms_color@ctm-negative,Fail
> +kms_color@ctm-red-to-blue,Fail
> +kms_color@ctm-signed,Fail
> +kms_cursor_legacy@cursor-vs-flip-toggle,Fail
> +kms_cursor_legacy@cursor-vs-flip-varying-size,Fail
> +kms_flip@flip-vs-modeset-vs-hang,Fail
> +kms_flip@flip-vs-panning-vs-hang,Fail
> +kms_pipe_crc_basic@compare-crc-sanitycheck-nv12,Fail
> +kms_plane_alpha_blend@alpha-7efc,Fail
> +kms_plane_alpha_blend@coverage-7efc,Fail
> +kms_plane_alpha_blend@coverage-vs-premult-vs-constant,Fail
> +kms_rmfb@close-fd,Fail
> diff --git a/drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-lazor-limozeen-fails.txt b/drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-lazor-limozeen-fails.txt
> new file mode 100644
> index 000000000000..7e4d8744fcc6
> --- /dev/null
> +++ b/drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-lazor-limozeen-fails.txt
> @@ -0,0 +1,17 @@
> +kms_color@ctm-0-25,Fail
> +kms_color@ctm-0-50,Fail
> +kms_color@ctm-0-75,Fail
> +kms_color@ctm-blue-to-red,Fail
> +kms_color@ctm-green-to-red,Fail
> +kms_color@ctm-negative,Fail
> +kms_color@ctm-red-to-blue,Fail
> +kms_color@ctm-signed,Fail
> +kms_cursor_legacy@cursor-vs-flip-toggle,Fail
> +kms_cursor_legacy@cursor-vs-flip-varying-size,Fail
> +kms_flip@flip-vs-modeset-vs-hang,Fail
> +kms_flip@flip-vs-panning-vs-hang,Fail
> +kms_pipe_crc_basic@compare-crc-sanitycheck-nv12,Fail
> +kms_plane_alpha_blend@alpha-7efc,Fail
> +kms_plane_alpha_blend@coverage-7efc,Fail
> +kms_plane_alpha_blend@coverage-vs-premult-vs-constant,Fail
> +kms_rmfb@close-fd,Fail

  reply	other threads:[~2024-01-15 15:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04  8:14 [PATCH v1] drm/ci: add sc7180-trogdor-kingoftown Vignesh Raman
2024-01-15 15:24 ` Helen Koike [this message]
2024-01-15 16:51 ` Helen Koike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a968260-e7a2-45fb-9a3b-1a8e15d49018@collabora.com \
    --to=helen.koike@collabora.com \
    --cc=daniels@collabora.com \
    --cc=david.heidelberg@collabora.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=guilherme.gallo@collabora.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=sergi.blanch.torne@collabora.com \
    --cc=vignesh.raman@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox