Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Wangao Wang <wangao.wang@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: wangao.wang@oss.qualcomm.com, Bryan O'Donoghue <bod@kernel.org>,
	Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
	Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v2 0/5] media: iris: add support for purwa platform
Date: Tue, 10 Mar 2026 15:20:40 +0800	[thread overview]
Message-ID: <9b046f29-61ac-4bd3-a89f-a8d438ccaa2f@oss.qualcomm.com> (raw)
In-Reply-To: <20260307-talented-civet-of-strength-356cb5@quoll>



On 2026/3/7 21:12, Krzysztof Kozlowski wrote:
> On Fri, Mar 06, 2026 at 04:44:28PM +0800, Wangao Wang wrote:
>> This series enables the Iris video codec on purwa, allowing purwa to
>> use hardware‑accelerated video encoding and decoding.
>>
>> The Iris codec on purwa is nearly identical to the one on hamoa(X1E),
>> except that it requires one additional clock and uses a different OPP
>> table.
>>
>> Therefore, purwa can reuse the Iris node from hamoa, but the clocks
>> and OPP table need to be redefined.
>>
>> Dependencies:
>> https://lore.kernel.org/all/20260202-purwa-v5-0-1f5a93578802@oss.qualcomm.com/
>> https://lore.kernel.org/all/20260304-purwa-videocc-camcc-v2-0-dbbd2d258bd6@oss.qualcomm.com/
> 
> I don't understand why you coupled them and added these as dependencies.
> This only makes it difficult to test and technically your media patches
> cannot be applied.
> 
> And I don't even see what is needed from these patchsets for the media
> bits.
> 
> Best regards,
> Krzysztof
> 

Thanks for the feedback.

You are right — coupling these patchsets as dependencies was not 
necessary and indeed makes the series harder to test and apply. The 
media/iris changes should be self-contained and not depend on the Purwa 
base DT/videocc series.

The dependency note was added mainly for bring-up convenience. However, 
that should not be expressed as a hard dependency for the media patches.

Should I send the DT patches separately from the driver patches?

-- 
Best Regards,
Wangao


      reply	other threads:[~2026-03-10  7:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06  8:44 [PATCH v2 0/5] media: iris: add support for purwa platform Wangao Wang
2026-03-06  8:44 ` [PATCH v2 1/5] dt-bindings: media: qcom,sm8550-iris: Add X1P42100 compatible Wangao Wang
2026-03-07 13:13   ` Krzysztof Kozlowski
2026-03-07 13:19     ` Krzysztof Kozlowski
2026-03-10  7:08       ` Wangao Wang
2026-03-10  7:09         ` Krzysztof Kozlowski
2026-03-06  8:44 ` [PATCH v2 2/5] arm64: dts: qcom: purwa: Override Iris clocks and operating points Wangao Wang
2026-03-07 13:15   ` Krzysztof Kozlowski
2026-03-10  7:11     ` Wangao Wang
2026-03-06  8:44 ` [PATCH v2 3/5] media: iris: Add IRIS_BSE_HW_CLK handling in vpu3 power on/off sequence Wangao Wang
2026-03-09 23:58   ` Dmitry Baryshkov
2026-03-10  7:14     ` Wangao Wang
2026-03-13 17:54       ` Dmitry Baryshkov
2026-03-06  8:44 ` [PATCH v2 4/5] media: iris: Add platform data for X1P42100 Wangao Wang
2026-03-07 13:18   ` Krzysztof Kozlowski
2026-03-09 10:43     ` Konrad Dybcio
2026-03-09 10:49       ` Krzysztof Kozlowski
2026-03-09 23:55         ` Dmitry Baryshkov
2026-03-06  8:44 ` [PATCH v2 5/5] arm64: dts: qcom: purwa-iot-som: enable video Wangao Wang
2026-03-07 13:12 ` [PATCH v2 0/5] media: iris: add support for purwa platform Krzysztof Kozlowski
2026-03-10  7:20   ` Wangao Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b046f29-61ac-4bd3-a89f-a8d438ccaa2f@oss.qualcomm.com \
    --to=wangao.wang@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=andersson@kernel.org \
    --cc=bod@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=vikash.garodia@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox