Re: [PATCH v2 4/7] dt-bindings: clock: qcom: Add SM8750 GCC

[Taniya Das <quic_tdas@quicinc.com>]

On 11/20/2024 1:47 PM, Krzysztof Kozlowski wrote:
> On Mon, Nov 11, 2024 at 04:28:04PM -0800, Melody Olvera wrote:
>> From: Taniya Das <quic_tdas@quicinc.com>
>>
>> Add bindings documentation for the SM8750 General Clock Controller.
> 
> Subject prefix - use proper file prefix:
> dt-bindings: clock: qcom,sm8650-gcc:
> 
>>
>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>>   .../bindings/clock/qcom,sm8650-gcc.yaml       |   8 +-
>>   include/dt-bindings/clock/qcom,sm8750-gcc.h   | 226 ++++++++++++++++++
>>   2 files changed, 232 insertions(+), 2 deletions(-)
>>   create mode 100644 include/dt-bindings/clock/qcom,sm8750-gcc.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml
>> index 976f29cce809..e50b5f1cad75 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml
>> @@ -13,11 +13,15 @@ description: |
>>     Qualcomm global clock control module provides the clocks, resets and power
>>     domains on SM8650
>>   
>> -  See also:: include/dt-bindings/clock/qcom,sm8650-gcc.h
>> +  See also: include/dt-bindings/clock/qcom,sm8650-gcc.h
>> +            include/dt-bindings/reset/qcom,sm8750-gcc.h
>>   
>>   properties:
>>     compatible:
>> -    const: qcom,sm8650-gcc
>> +    items:
> 
> No need for items, simpler is just enum.
> 

will fix in the next patch.

>> +      - enum:
>> +          - qcom,sm8650-gcc
>> +          - qcom,sm8750-gcc
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 

-- 
Thanks & Regards,
Taniya Das.