From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD47DA932 for ; Sat, 25 Oct 2025 00:02:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761350543; cv=none; b=OcEomkDlI+LcytnFBQ6JYTJMds3xn3k/LCkta/XpTWK7VwYPXFhtcm9d1/zr3/fzttuQBW9OTMEe51zYv1MV1QmnoMCCjLR7zHDqHY1+CpY+KYvnuaMm6cJ2MUTqls/r5ig+xwu+3sw1SNd9keU7jgQ2AS5Lp24ZGBIhxLmLB4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761350543; c=relaxed/simple; bh=BqREg4gsxpMPNLe6ibuhRTqn6ygL+R0bbCz/kW1VxKM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CNdtFxBaSJrp87MzZBkID+hwb7oQwZlXQiQj5auwPPI8zdXFVRLKZ+0ZhvWgwSVcf+P3oLC2bDX9ttgBd8iZUaRzxy3j6RXoWEE00UWbhKCtSIJUguSobd5cuVlOl1OsW1qvNqd1Efn6uV9gHsRYgeBMxkXOTnOYnCI/uy3f5xM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XGM/74FO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XGM/74FO" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59OI9J1Q028437 for ; Sat, 25 Oct 2025 00:02:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fc56pL8berOUmLto0AR19Euk08KtluvdaeNgGMdpvTE=; b=XGM/74FOGdNx4bPt V2fYvREFPHifpId8zU2Ui2yQVcAFg4vl3fBm1nXlYcoeDfHYVXKzMnCXVKFwH9NV ziNbdw9OozywFuMK9R+KP8Mmy9KWf+6igzG7Di5mhjv/NgAHH2XnP8ljF+k4x+HQ TLX3TVACSX4kY/NvUVAJkHPpGvmT8RXfArjyAXrezz3uCta5/LfvRMuwfiMwYAHI YCo3G4yPBh4AJE/eqLXCWLepxGpXYLzhT4JBWnr0xLI0TKfGPsMWgG/KLx8r9/dK AalJYizIUkOpmENTDJ/1dYL2T6hOT+ni8NXATzK1GBwWSYJOs3Stqe3Mja39E0q0 xWn5Zw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49y67qqhqu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 25 Oct 2025 00:02:20 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-76e2ea9366aso2349571b3a.2 for ; Fri, 24 Oct 2025 17:02:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761350539; x=1761955339; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fc56pL8berOUmLto0AR19Euk08KtluvdaeNgGMdpvTE=; b=TeuevGSfT9zjTc2AgWF5nO3OVt2oXnxQVKimrXUclB4ds/bATVrWBAUjBedv5qtjNb 5nxNHPnxWAiYjYN+ScjiI5/D6OMN2szakNWDw7Pz/UqNIw/bq2hoxtKOyZEkaVmd9oNX n4sfN3FOH7zilUu3Et8ZwEr+c3HhC6bqm0cOhdqpYYmgGeO6+K6XpspYP3pkqI9SqPhi ex8apjFYWULFlCDa7VdgEi4pcjuj7dx+xRubLukWaOq1W6JbfiAl+N07v2DKibAXj+8u z6zMigpz7c7xDkskXVH+9ClsX/owpLiG5Z3PKkC/7fYrzb5qTcwugFg6V2GUdsNcb4MR Uanw== X-Forwarded-Encrypted: i=1; AJvYcCUW5oBSs2Bzk2o9NDcnQ1G9seEC0rfJ1BaigJkR9c7qefSci90wFBrFV8qiumhW4RrIngwjESe5QeBtF/EQ@vger.kernel.org X-Gm-Message-State: AOJu0YxK9w9wB6wDVl+tkMkIaBjQEzOCtLlZt7EAe07yOH1wt8L2sQ43 4EQEuEluDclQY6zoN6CXsqMP4J2ztyCe2q1BQfzmIS4WEX3xne6/kJIdEgnFY/UkheFOKWFiPbR sfLIFOQ6Gq3UNFsDQb+AgYDm2jJNNghW0fGhJLzik4BThCXzpaQIKomc+RL4hR+lu7slYoMhX/L 38 X-Gm-Gg: ASbGncvN2PWxkqg4QkwuvuElwX5RUCx8ix/PqgI5EiWxtpXDBt9p2HJStXNt2cnsCXm XgpJE7wqfhKkjGG2xV1Yzra5THLzMDuA6HI6zWSlhmUzMcov5v1JGIBwmGTgK6YPb2lASWod4Bj VOMRpi015vm5W99UvNXiUCCHeHd0i5X49bk5kf7esx8U1Hq4ZFDX4zKnlg9CuX9dNXwM0Xnmke6 3p3yxETRZljfoWKH2XqLEIC2hbBbOqpPJoa7HSE+jU3iNhbWOXMvJ+PDjdIIpNwxQSIsVdwYMuI dNKuVANUen5vgrPd0JCjbL4v0A4qyPYON1yy6AZCZNv4VIXTXsfc2C3SAvFl64U1priil5Ab5uc ib8eDjZODJTkUG/iGzow1SQL8x3Uhwm5d5fpWqbnK X-Received: by 2002:a05:6a20:e291:b0:341:3b91:69d1 with SMTP id adf61e73a8af0-3413b916bfemr325146637.5.1761350539006; Fri, 24 Oct 2025 17:02:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHx6iqMO7Mnjaq8k2ZFocktbexyApACGzLDJtVcDcWlYMjTJ7zTgXxvx6wLi2N8LqDG0LX5kw== X-Received: by 2002:a05:6a20:e291:b0:341:3b91:69d1 with SMTP id adf61e73a8af0-3413b916bfemr325102637.5.1761350538483; Fri, 24 Oct 2025 17:02:18 -0700 (PDT) Received: from [10.73.53.19] (pat_11.qualcomm.com. [192.35.156.11]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b712d024aaasm382952a12.26.2025.10.24.17.02.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Oct 2025 17:02:17 -0700 (PDT) Message-ID: <9d3dd1cf-4969-3dcb-18dc-59cfb68033f7@oss.qualcomm.com> Date: Fri, 24 Oct 2025 17:02:15 -0700 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v5 07/10] phy: qualcomm: qmp-combo: Update QMP PHY with Glymur settings To: Abel Vesa Cc: krzk+dt@kernel.org, conor+dt@kernel.org, konrad.dybcio@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, kishon@kernel.org, vkoul@kernel.org, gregkh@linuxfoundation.org, robh@kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251006222002.2182777-1-wesley.cheng@oss.qualcomm.com> <20251006222002.2182777-8-wesley.cheng@oss.qualcomm.com> Content-Language: en-US From: Wesley Cheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDIyMDE2OCBTYWx0ZWRfX1ZaZkdllbQjb QjhHupejgMSHoOSccsU1+DrwbsbLe5vFmwn4ThwVGL8JPHYvHTp3UwuRFbqoj1VAea7IRJj8X11 JWxOEyWBWMntEmiPAolUOMBRSgVJzRD+BwOmHmq3w8vltQSzQWRfuR7C7Z8D0O/sHSzKylcaDp0 tU9V/FB8p51WenfH91aFq1htCAhATSfFXFhPqbvaznV+/gCAb1+dd9NvkjXljmXj5dFIFPPIvrY V95RlbDnNa78OYCEqpF+bZMKWXSnCGF9+7K7t12/o+wHvf3kUauvipjgffGqZpZeyeeSmEhjmru VnN0rU0yHHOvmF9nv5/TaBsfas58eDdbnNcBkdq3t+CnHB0dlZbX7wvigSuCHs+iGeiAyMw/Q2v BH4v1y0JdMOsAUvLf7MGwCPi494GxQ== X-Authority-Analysis: v=2.4 cv=LMRrgZW9 c=1 sm=1 tr=0 ts=68fc138c cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZdW6uxA9NKXbfdqeeS2OGA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=iT4AbuSYlod7UvTVlOgA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-GUID: CHiTG_koFC6Np49Vf-sduDJZEAMy7771 X-Proofpoint-ORIG-GUID: CHiTG_koFC6Np49Vf-sduDJZEAMy7771 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-24_05,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510220168 On 10/24/2025 3:04 AM, Abel Vesa wrote: > On 25-10-06 15:19:59, Wesley Cheng wrote: >> For SuperSpeed USB to work properly, there is a set of HW settings that >> need to be programmed into the USB blocks within the QMP PHY. Ensure that >> these settings follow the latest settings mentioned in the HW programming >> guide. The QMP USB PHY on Glymur is a USB43 based PHY that will have some >> new ways to define certain registers, such as the replacement of TXA/RXA >> and TXB/RXB register sets. This was replaced with the LALB register set. >> >> There are also some PHY init updates to modify the PCS MISC register space. >> Without these, the QMP PHY PLL locking fails. >> >> Reviewed-by: Dmitry Baryshkov >> Signed-off-by: Wesley Cheng >> --- >> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 314 ++++++++- >> .../phy/qualcomm/phy-qcom-qmp-pcs-aon-v8.h | 17 + >> .../phy/qualcomm/phy-qcom-qmp-pcs-misc-v8.h | 12 + >> .../qualcomm/phy-qcom-qmp-qserdes-lalb-v8.h | 639 ++++++++++++++++++ >> .../phy/qualcomm/phy-qcom-qmp-usb43-pcs-v8.h | 33 + >> .../phy-qcom-qmp-usb43-qserdes-com-v8.h | 224 ++++++ >> drivers/phy/qualcomm/phy-qcom-qmp.h | 2 + >> 7 files changed, 1240 insertions(+), 1 deletion(-) >> create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-aon-v8.h >> create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-misc-v8.h >> create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-qserdes-lalb-v8.h >> create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-usb43-pcs-v8.h >> create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-usb43-qserdes-com-v8.h >> >> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >> index 1caa1fb6a8c7..8216820e388f 100644 >> --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > > [...] > >> +static const struct qmp_phy_cfg glymur_usb3dpphy_cfg = { >> + .offsets = &qmp_combo_usb43dp_offsets_v8, >> + >> + .serdes_tbl = glymur_usb43dp_serdes_tbl, >> + .serdes_tbl_num = ARRAY_SIZE(glymur_usb43dp_serdes_tbl), >> + .tx_tbl = glymur_usb43dp_lalb_tbl, >> + .tx_tbl_num = ARRAY_SIZE(glymur_usb43dp_lalb_tbl), >> + .pcs_tbl = glymur_usb43dp_pcs_tbl, >> + .pcs_tbl_num = ARRAY_SIZE(glymur_usb43dp_pcs_tbl), >> + .pcs_usb_tbl = glymur_usb43dp_pcs_usb_tbl, >> + .pcs_usb_tbl_num = ARRAY_SIZE(glymur_usb43dp_pcs_usb_tbl), >> + .pcs_misc_tbl = glymur_usb43dp_pcs_misc_tbl, >> + .pcs_misc_tbl_num = ARRAY_SIZE(glymur_usb43dp_pcs_misc_tbl), >> + >> + .dp_serdes_tbl = qmp_v6_n4_dp_serdes_tbl, >> + .dp_serdes_tbl_num = ARRAY_SIZE(qmp_v6_n4_dp_serdes_tbl), >> + .dp_tx_tbl = qmp_v6_n4_dp_tx_tbl, >> + .dp_tx_tbl_num = ARRAY_SIZE(qmp_v6_n4_dp_tx_tbl), >> + >> + .serdes_tbl_rbr = qmp_v6_n4_dp_serdes_tbl_rbr, >> + .serdes_tbl_rbr_num = ARRAY_SIZE(qmp_v6_n4_dp_serdes_tbl_rbr), >> + .serdes_tbl_hbr = qmp_v6_n4_dp_serdes_tbl_hbr, >> + .serdes_tbl_hbr_num = ARRAY_SIZE(qmp_v6_n4_dp_serdes_tbl_hbr), >> + .serdes_tbl_hbr2 = qmp_v6_n4_dp_serdes_tbl_hbr2, >> + .serdes_tbl_hbr2_num = ARRAY_SIZE(qmp_v6_n4_dp_serdes_tbl_hbr2), >> + .serdes_tbl_hbr3 = qmp_v6_n4_dp_serdes_tbl_hbr3, >> + .serdes_tbl_hbr3_num = ARRAY_SIZE(qmp_v6_n4_dp_serdes_tbl_hbr3), >> + >> + .swing_hbr_rbr = &qmp_dp_v6_voltage_swing_hbr_rbr, >> + .pre_emphasis_hbr_rbr = &qmp_dp_v6_pre_emphasis_hbr_rbr, >> + .swing_hbr3_hbr2 = &qmp_dp_v5_voltage_swing_hbr3_hbr2, >> + .pre_emphasis_hbr3_hbr2 = &qmp_dp_v5_pre_emphasis_hbr3_hbr2, >> + >> + .dp_aux_init = qmp_v4_dp_aux_init, >> + .configure_dp_tx = qmp_v4_configure_dp_tx, >> + .configure_dp_phy = qmp_v4_configure_dp_phy, >> + .calibrate_dp_phy = qmp_v4_calibrate_dp_phy, > > So I see you are adding the DP related config here as well, but it is > definitely not compatible with v6 N4. I'm assyuming you picked v6 N4 as a default > just to allow the USB part work for now, right ? > > I don't suppose we can drop the DP related config from this patch and > still have the USB part working, right? > > Otherwise, we need to mention the fact that even though the DP part > is also being added, it is broken. Hi Abel, That is correct. Without these defined, the USB path won't work, and we'll need to supplement this if we wanted to add DP support. Hence, why I didn't add any mention of DP altmode in the commit text. I can clarify that we added DP placeholders if that makes it more clear in the commit text. Thanks Wesley CHeng