From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32ED53DBD76 for ; Wed, 18 Mar 2026 14:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773844444; cv=none; b=Zqm70omy420rZciVURqm2eJ1xya56EZMcasxW2XLrpMZ83cGuWkCRsjotm92TLDq/m3TSHFeU9a2YcsErsHHeq9vrSs0Oyq51DtHAzjx4WggPIP16aKkl8hvRAHwxdXyoWQ7ChhxosY2qNoJlMWksae5d/7A9S09jzadPs0KtsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773844444; c=relaxed/simple; bh=9p6tQs+mLyee3FtMZwaNEygInWPuLE++rtiwf4wLoCg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n6RcHxxPDdnUHowIF3uCtDezlmhwmOEzNvVH9nylpFwfM2YV/rXO6hdpBK8ah6ASLC4XeiVYkxDZVClY9C/Y3wWCFYbGF4Ipopds1MutFZq41mpfUDZtz/rPJgvp5E/XOnk8rfx80ZUlGzI55AFLtIUA7j4myOE1ULHQzGKG6+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nQZ3a4lA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MaehRU4Z; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nQZ3a4lA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MaehRU4Z" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62IAhxNf008446 for ; Wed, 18 Mar 2026 14:34:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KvDkX8RsG9Lo1c/o4mDsdW9Ws2mDXEVxPEhrsdpPYsU=; b=nQZ3a4lAY2DD+UgK q5/LLvnUTzUgpKDPMOQ2OLyoMh7x0nqgwWxqx5m7U1ubuFJ+vE8DX4RKPq1kKD7V rdkK682e0vbRC0sDTJRFrBzpyKgsbBV3cNZUspIMM/RDFeYJ5K2J346FstTNbmrH ICyTaSdwJtEcsTYtwBiV96Qqm5pRXcLamRhHEimciMixnyhsIRYDckhCXrdo3926 H7A4k9BM8yyfxDzquupt+TLH59k4kr9y8sj7D2P4FaDGa4Z52eBbQEoxYMvQXjV7 K04wSiq2FYo1h96z9a51ADRDhsSYRIpW+gpe2RlVsTr5tLZdQ51BzFEL5xKC9PeC ZukWcA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cytj50tvm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 14:34:01 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5093a985e21so542560851cf.3 for ; Wed, 18 Mar 2026 07:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773844440; x=1774449240; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=KvDkX8RsG9Lo1c/o4mDsdW9Ws2mDXEVxPEhrsdpPYsU=; b=MaehRU4ZeIcXysnwHDk4oPeqQNuZhKx4M/1JElj0SZSUyuxnIUFnYSQfx8jeKU9yt7 70CQu+rvUuOgE11RCJ2P+/OUZwiX1/8J1ntBOxeqCIWU7c3a+sQdKLxb6opAEdqsEPDr G5pxfrSQn68dIa2BzGdESXITAklZWQ4VcEGYFLvdAKWGmxq4EWSiZHXL/v98xWbEpxYZ cniCGscXNgasSJqHqq3eCN92kNRgDvdVcUJPJp1znaUgxrv58Merjf8H2INiD326z87q MoVQ5YlUP2WFdOJ9Y++IXue/gKnIGDDAQwnWonaNNHPDwFmQd5X832p5VMU7x/hXtSqe LRVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773844440; x=1774449240; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KvDkX8RsG9Lo1c/o4mDsdW9Ws2mDXEVxPEhrsdpPYsU=; b=fkBh+gc8pElMQzqVWbJ08rcQM7+1ui11qB734AwDsM7R9tlEmlXrrIMWp7mhiW/FZ2 P6aNBTuZLT4DQva+JRWUskKsvgHZMS9BFW2pxzSExCfuQToN6H52a0ZjskyzFGr5LrVO 8x95xrS5ACfqX9d9cAebqhK7E+FYO8T1l+iDA01tDL8QffDovI4gXRtkW2B70ybRF0g+ JFoSLtins30q8hmPphYd4EbDYUNthB8BqDe/UbqLkwg+Eu4YHhATPhWCGiB1V5i2zt5u pTk7PPc9Ij9/FSdL/goESLQpPecppD9+K8AgbLbc6b+5g7vE6tN1wyg41zbfSZZt2E84 h3ug== X-Forwarded-Encrypted: i=1; AJvYcCWqIcCZxf5Ihet3n+3bfICZ3mxKfrWiMO1pAar1nIp9f6zuQDLP97cEJjlNVWm2rqPDr8jxT8L9xsscUWNS@vger.kernel.org X-Gm-Message-State: AOJu0YxWipgRoTW04xwxm9waXkol4C+U/2PXjaOMO4dwj698blPxwvY6 Ve7t9T88JNNzESQfnwcQwhrAJF/d4HQa25j/pmTLYeVbuy3yOn2Li7R12rT7ShRJa/cjCxVhsmn 7ksgcTHHnlaMP30fwhjykvWc78DGC/ik/YV+2VE/0BedC9aobGHqcbXa+yF4hdf3DHdaQ X-Gm-Gg: ATEYQzx2jMzUlDplX7r4ry4GUTilcZD2cqN3A8Te6YD/9ndjCn2YdW1eYN0BbCeh8tC uZ3WCsNuAAqlshVrT7j9mf3age/N4xQFMhzrjzlbzT9NCg9Pw8FVB8KiBlW8FIrAUyiJ3gWPMyw 3fNEvTUIy5op48+5uqs3tRKpjgSTpokFqMF4uqgiJ1JWq/kk3zkJ193ZmfHIM/PjM1HP9yMZ2VM Rmt4+Vwn3hQMWYIGxSxw0KQ4ifSQD9KOY8DcHVIota1McSyvtN13pwVHB1RHOouL6mEn31r8KxF xXf/96/Mzy/WtdtfkM6v9pjhny7T6uarkkx5EDrNxVtEmg00eXc9gW3U/IeAWmS5sAqHEuORM5t 49F4ryJdvBEKNMvdMiNGLeiWBM+CscfOTE1H5i6V9EjZIvcYu X-Received: by 2002:ac8:5f93:0:b0:509:44c3:5ffa with SMTP id d75a77b69052e-50b148bc253mr45865551cf.52.1773844440374; Wed, 18 Mar 2026 07:34:00 -0700 (PDT) X-Received: by 2002:ac8:5f93:0:b0:509:44c3:5ffa with SMTP id d75a77b69052e-50b148bc253mr45864721cf.52.1773844439720; Wed, 18 Mar 2026 07:33:59 -0700 (PDT) Received: from [192.168.1.29] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f4b9892esm19606605e9.19.2026.03.18.07.33.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 07:33:57 -0700 (PDT) Message-ID: <9ea16bfe-ac9b-405c-8597-e4f398347d8f@oss.qualcomm.com> Date: Wed, 18 Mar 2026 15:33:56 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] clk: qcom: dispcc-eliza: Add Eliza display clock controller support To: Dmitry Baryshkov Cc: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260318-clk-qcom-dispcc-eliza-v2-0-8c05581168d1@oss.qualcomm.com> <20260318-clk-qcom-dispcc-eliza-v2-2-8c05581168d1@oss.qualcomm.com> <1a00582d-66d6-4325-aafd-156cfacee8cd@oss.qualcomm.com> <2227a9d2-fb34-4d54-8122-c00f54009de1@oss.qualcomm.com> <846ae47c-8e0e-4fdb-899d-de679d013fa5@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@oss.qualcomm.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTpLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQG9zcy5xdWFsY29tbS5jb20+wsGXBBMB CgBBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmkknB4CGwMFCRaWdJoFCwkIBwICIgIGFQoJ CAsCBBYCAwECHgcCF4AACgkQG5NDfTtBYpuCRw/+J19mfHuaPt205FXRSpogs/WWdheqNZ2s i50LIK7OJmBQ8+17LTCOV8MYgFTDRdWdM5PF2OafmVd7CT/K4B3pPfacHATtOqQFHYeHrGPf 2+4QxUyHIfx+Wp4GixnqpbXc76nTDv+rX8EbAB7e+9X35oKSJf/YhLFjGOD1Nl/s1WwHTJtQ a2XSXZ2T9HXa+nKMQfaiQI4WoFXjSt+tsAFXAuq1SLarpct4h52z4Zk//ET6Xs0zCWXm9HEz v4WR/Q7sycHeCGwm2p4thRak/B7yDPFOlZAQNdwBsnCkoFE1qLXI8ZgoWNd4TlcjG9UJSwru s1WTQVprOBYdxPkvUOlaXYjDo2QsSaMilJioyJkrniJnc7sdzcfkwfdWSnC+2DbHd4wxrRtW kajTc7OnJEiM78U3/GfvXgxCwYV297yClzkUIWqVpY2HYLBgkI89ntnN95ePyTnLSQ8WIZJk ug0/WZfTmCxX0SMxfCYt36QwlWsImHpArS6xjTvUwUNTUYN6XxYZuYBmJQF9eLERK2z3KUeY 2Ku5ZTm5axvlraM0VhUn8yv7G5Pciv7oGXJxrA6k4P9CAvHYeJSTXYnrLr/Kabn+6rc0my/l RMq9GeEUL3LbIUadL78yAtpf7HpNavYkVureuFD8xK8HntEHySnf7s2L28+kDbnDi27WR5kn u/POwU0EVUNcNAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDy fv4dEKuCqeh0hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOG mLPRIBkXHqJYoHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6 H79LIsiYqf92H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4ar gt4e+jum3NwtyupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8 nO2N5OsFJOcd5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFF knCmLpowhct95ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz 7fMkcaZU+ok/+HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgN yxBZepj41oVqFPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMi p+12jgw4mGjy5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYC GwwWIQSb0H4ODFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92 Vcmzn/jaEBcqyT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbTh LsSN1AuyP8wFKChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH 5lSCjhP4VXiGq5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpF c1D/9NV/zIWBG1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzeP t/SvC0RhQXNjXKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60 RtThnhKc2kLIzd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7q VT41xdJ6KqQMNGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZ v+PKIVf+zFKuh0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1q wom6QbU06ltbvJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHp cwzYbmi/Et7T2+47PN9NZAOyb771QoVr8A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDEyNCBTYWx0ZWRfX2p0Qt0qp6i11 wTuaX+B3sENHL79QSiKtvN1h43maV6N19xMCCBHd6PcYvPGSIEPDvaEhJiBEKJ5llGDHJaAm4FE wvfWjD5BlplFJS8NxrcbaL97CfTb//YZG8yNH1nhcfagZ/eE7/9E1gFyruK75vFFDeNfHBLSyDp JRozt9xaik5sSXZK2ncESt/oKdvNfwGqpcHBxxgIRk8evCtw2nKMwq2ErfENlQL8vT/XLDejPNt yLyybELCxlDVD+ZNsnVl74LPUeglu3ZvT7HQdGiSL2OtzV422DNd8e4Zgp2aHR48y02I+9BmmAo 4ysgg/zZLurJb2YZGvcco6BYed+3StAn7mc333+whOCt95fTns+7XUoOIlwZZROMejcjEEiwdUl 8nJO+88Q2j3jWndqtCDJJ2ED94z96Z3KcbrQ01W2hv/Ef4+h7Nf+qZ4Hv2TI8CFR/1rXv8W26Hz zI+xy9+rQjYAYTZqyCw== X-Proofpoint-ORIG-GUID: dSH_fzlr92QRRA2u_pxc8O5tjkFB_uMP X-Proofpoint-GUID: dSH_fzlr92QRRA2u_pxc8O5tjkFB_uMP X-Authority-Analysis: v=2.4 cv=dM+rWeZb c=1 sm=1 tr=0 ts=69bab7d9 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=0Xxaj_rZfRVFU6duThQA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180124 On 18/03/2026 14:46, Dmitry Baryshkov wrote: > On Wed, Mar 18, 2026 at 12:36:24PM +0100, Krzysztof Kozlowski wrote: >> On 18/03/2026 12:32, Konrad Dybcio wrote: >>> On 3/18/26 12:13 PM, Krzysztof Kozlowski wrote: >>>> On 18/03/2026 11:48, Konrad Dybcio wrote: >>>>> On 3/18/26 11:39 AM, Krzysztof Kozlowski wrote: >>>>>> Add a driver for the display clock controller on Qualcomm Eliza SoC, >>>>>> which is copied from SM8750 driver plus changes: >>>>>> >>>>>> 1. Additional DT_HDMI_PHY_PLL_CLK clock input, >>>>>> 2. Eight new HDMI clocks, >>>>>> 3. Different PLLs (lucid and pongo). >>>>>> >>>>>> Signed-off-by: Krzysztof Kozlowski >>>>>> --- >>>>> >>>>> [...] >>>>> >>>>> >>>>>> +// SPDX-License-Identifier: GPL-2.0-only >>>>>> +/* >>>>>> + * Copyright (c) 2021, The Linux Foundation. All rights reserved. >>>>>> + * Copyright (c) 2023-2024, Linaro Ltd. >>>>>> + * Copyright (c) 2024-2025, Qualcomm Innovation Center, Inc. All rights reserved. >>>>> >>>>> -> Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >>>> >>>> That's the copyright I found in the downstream code I used in few places >>>> here (with modifications) and I am not touching them. I also don't care >>>> about these and I am surprised this keeps popping in community review... >>> >>> You may not care, but our legal department does.. >> >> And your task as community maintainer is to care about community and >> Linux kernel, not about legal department. >> >> Legal department can comment here, if they care. You as maintainer have >> rather responsibilities regardless of that legal department. >> >> Don't bring corpo legal stuff to the community. > > Then please follow the internal company guidelines as outlined in the > legal&marketing documents. That's not your task to instruct people what internal stuff should they follow or not. Especially not implied by previous comment "Then". > > JFYI, several other Qualcomm maintainers also enforce use of copyright > headers for Qualcomm-provided patches. Konrad is not unique here. I already objected to one of them, so I know. You do understand that this is completely broken review process? As every contributor, I can object to that comment with arguments (and I did in the past), however you as reviewer do not bring any counter-arguments for that all. You just refer "follow legal internal stuff". No, this does not work for that. If you bring review comment you must be able to justify it, when it is being discussed. You cannot refer "but legal team said". Otherwise look for comments for your contributions where you are going to receive review "please remove all boilerplate because my legal team told me that and I am not going to provide actual arguments why". Best regards, Krzysztof