Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Oltmanns <frank@oltmanns.dev>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Chris Lew <quic_clew@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stephan Gerhold <stephan.gerhold@linaro.org>,
	Johan Hovold <johan+linaro@kernel.org>,
	Caleb Connolly <caleb.connolly@linaro.org>,
	Joel Selvaraj <joelselvaraj.oss@gmail.com>,
	Alexey Minnekhanov <alexeymin@postmarketos.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: pd-mapper: defer probing on sdm845
Date: Wed, 12 Feb 2025 06:45:17 +0100	[thread overview]
Message-ID: <9f8cf902-85a3-43db-bce9-4fc9b876c473@kernel.org> (raw)
In-Reply-To: <20250205-qcom_pdm_defer-v1-1-a2e9a39ea9b9@oltmanns.dev>

On 05/02/2025 22:57, Frank Oltmanns wrote:
> +static const struct of_device_id qcom_pdm_defer[] __maybe_unused = {
> +	{ .compatible = "qcom,sdm845", .data = &first_dev_remoteproc3, },
> +	{},
> +};
>  static void qcom_pdm_stop(struct qcom_pdm_data *data)
>  {
>  	qcom_pdm_free_domains(data);
> @@ -637,6 +651,25 @@ static struct qcom_pdm_data *qcom_pdm_start(void)
>  	return ERR_PTR(ret);
>  }
>  
> +static bool qcom_pdm_ready(struct auxiliary_device *auxdev)
> +{
> +	const struct of_device_id *match;
> +	struct device_node *root;
> +	struct qcom_pdm_probe_first_dev_quirk *first_dev;
> +
> +	root = of_find_node_by_path("/");
> +	if (!root)
> +		return true;
> +
> +	match = of_match_node(qcom_pdm_defer, root);

Aren't you open-coding machine is compatible?



Best regards,
Krzysztof

  parent reply	other threads:[~2025-02-12  5:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-05 21:57 [PATCH] soc: qcom: pd-mapper: defer probing on sdm845 Frank Oltmanns
2025-02-06  0:44 ` Dmitry Baryshkov
2025-02-06  2:54 ` Bjorn Andersson
2025-02-06  5:57   ` Frank Oltmanns
2025-02-06  6:44     ` Frank Oltmanns
2025-02-06 18:25       ` Steev Klimaszewski
2025-02-09 12:07         ` Frank Oltmanns
2025-02-10  5:26           ` Steev Klimaszewski
2025-02-09 11:57       ` Frank Oltmanns
2025-02-12  2:48         ` Bjorn Andersson
2025-02-15  7:24           ` Frank Oltmanns
2025-02-12  5:45 ` Krzysztof Kozlowski [this message]
2025-02-12  6:26   ` Frank Oltmanns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f8cf902-85a3-43db-bce9-4fc9b876c473@kernel.org \
    --to=krzk@kernel.org \
    --cc=alexeymin@postmarketos.org \
    --cc=andersson@kernel.org \
    --cc=caleb.connolly@linaro.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=frank@oltmanns.dev \
    --cc=joelselvaraj.oss@gmail.com \
    --cc=johan+linaro@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_clew@quicinc.com \
    --cc=stable@vger.kernel.org \
    --cc=stephan.gerhold@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox