* [PATCH 08/40] ARM: MSM: update clock source registration
2010-12-17 11:32 [PATCH 0/40] Complete set of clocksource/sched_clock patches Russell King - ARM Linux
@ 2010-12-17 11:38 ` Russell King - ARM Linux
2010-12-17 21:23 ` David Brown
2010-12-20 3:32 ` [PATCH 0/40] Complete set of clocksource/sched_clock patches Eric Miao
` (3 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Russell King - ARM Linux @ 2010-12-17 11:38 UTC (permalink / raw)
To: David Brown, Daniel Walker, Bryan Huntsman, linux-arm-msm
Cc: linux-arm-kernel
In d7e81c2 (clocksource: Add clocksource_register_hz/khz interface) new
interfaces were added which simplify (and optimize) the selection of the
divisor shift/mult constants. Switch over to using this new interface.
Tested-By: Jeff Ohlstein <johlstei@codeaurora.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
arch/arm/mach-msm/timer.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-msm/timer.c b/arch/arm/mach-msm/timer.c
index 950100f..595be7f 100644
--- a/arch/arm/mach-msm/timer.c
+++ b/arch/arm/mach-msm/timer.c
@@ -137,7 +137,6 @@ static struct msm_clock msm_clocks[] = {
.rating = 200,
.read = msm_gpt_read,
.mask = CLOCKSOURCE_MASK(32),
- .shift = 17,
.flags = CLOCK_SOURCE_IS_CONTINUOUS,
},
.irq = {
@@ -164,7 +163,6 @@ static struct msm_clock msm_clocks[] = {
.rating = 300,
.read = msm_dgt_read,
.mask = CLOCKSOURCE_MASK((32 - MSM_DGT_SHIFT)),
- .shift = 24 - MSM_DGT_SHIFT,
.flags = CLOCK_SOURCE_IS_CONTINUOUS,
},
.irq = {
@@ -205,8 +203,7 @@ static void __init msm_timer_init(void)
ce->min_delta_ns = clockevent_delta2ns(4, ce);
ce->cpumask = cpumask_of(0);
- cs->mult = clocksource_hz2mult(clock->freq, cs->shift);
- res = clocksource_register(cs);
+ res = clocksource_register_hz(cs, clock->freq);
if (res)
printk(KERN_ERR "msm_timer_init: clocksource_register "
"failed for %s\n", cs->name);
--
1.6.2.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 08/40] ARM: MSM: update clock source registration
2010-12-17 11:38 ` [PATCH 08/40] ARM: MSM: update clock source registration Russell King - ARM Linux
@ 2010-12-17 21:23 ` David Brown
0 siblings, 0 replies; 9+ messages in thread
From: David Brown @ 2010-12-17 21:23 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: David Brown, Daniel Walker, Bryan Huntsman, linux-arm-msm,
linux-arm-kernel
On Fri, Dec 17, 2010 at 11:38:02AM +0000, Russell King - ARM Linux wrote:
> In d7e81c2 (clocksource: Add clocksource_register_hz/khz interface) new
> interfaces were added which simplify (and optimize) the selection of the
> divisor shift/mult constants. Switch over to using this new interface.
>
> Tested-By: Jeff Ohlstein <johlstei@codeaurora.org>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: David Brown <davidb@codeaurora.org>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/40] Complete set of clocksource/sched_clock patches
2010-12-17 11:32 [PATCH 0/40] Complete set of clocksource/sched_clock patches Russell King - ARM Linux
2010-12-17 11:38 ` [PATCH 08/40] ARM: MSM: update clock source registration Russell King - ARM Linux
@ 2010-12-20 3:32 ` Eric Miao
2010-12-20 22:48 ` Russell King - ARM Linux
2010-12-21 19:24 ` Kevin Hilman
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Eric Miao @ 2010-12-20 3:32 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Alessandro Rubini, Bryan Huntsman, Colin Cross, Daniel Walker,
David Brown, Erik Gilling, Hans J. Koch, Imre Kaloz, Kevin Hilman,
Krzysztof Halasa, Kukjin Kim, Lennert Buytenhek, Jiandong Zheng,
Linus Walleij, linux-arm-msm, linux-omap, linux-samsung-soc,
linux-tegra, Nicolas Pitre, Olof Johansson, Sascha Hauer,
Scott Branden, STEricsson, Tony Lindgren, Viresh Kumar,
Wan ZongShun, linux-arm-kernel
On Fri, Dec 17, 2010 at 7:32 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> Here is the entire set of clocksource and sched_clock patches which
> have been previously posted. There's a couple of small tweaks in a
> few of the patches (such as adding notrace to OMAP clocksource read
> functions), and this also shows the proper ordering of these patches.
>
> Still looking for acks or tested-by's for these patches.
>
Hi Russell,
Sorry for late feedback. Tested the branch 'clksrc' on Littleton/PXA3xx,
seems to be good.
Tested-by: Eric Miao <eric.y.miao@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 0/40] Complete set of clocksource/sched_clock patches
2010-12-20 3:32 ` [PATCH 0/40] Complete set of clocksource/sched_clock patches Eric Miao
@ 2010-12-20 22:48 ` Russell King - ARM Linux
0 siblings, 0 replies; 9+ messages in thread
From: Russell King - ARM Linux @ 2010-12-20 22:48 UTC (permalink / raw)
To: Eric Miao
Cc: Alessandro Rubini, Bryan Huntsman, Colin Cross, Daniel Walker,
David Brown, Erik Gilling, Hans J. Koch, Imre Kaloz, Kevin Hilman,
Krzysztof Halasa, Kukjin Kim, Lennert Buytenhek, Jiandong Zheng,
Linus Walleij, linux-arm-msm, linux-omap, linux-samsung-soc,
linux-tegra, Nicolas Pitre, Olof Johansson, Sascha Hauer,
Scott Branden, STEricsson, Tony Lindgren, Viresh Kumar,
Wan ZongShun, linux-arm-kernel
On Mon, Dec 20, 2010 at 11:32:21AM +0800, Eric Miao wrote:
> On Fri, Dec 17, 2010 at 7:32 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > Here is the entire set of clocksource and sched_clock patches which
> > have been previously posted. There's a couple of small tweaks in a
> > few of the patches (such as adding notrace to OMAP clocksource read
> > functions), and this also shows the proper ordering of these patches.
> >
> > Still looking for acks or tested-by's for these patches.
> >
>
> Hi Russell,
>
> Sorry for late feedback. Tested the branch 'clksrc' on Littleton/PXA3xx,
> seems to be good.
>
> Tested-by: Eric Miao <eric.y.miao@gmail.com>
Ok, I'll add that to the PXA and generic patches, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/40] Complete set of clocksource/sched_clock patches
2010-12-17 11:32 [PATCH 0/40] Complete set of clocksource/sched_clock patches Russell King - ARM Linux
2010-12-17 11:38 ` [PATCH 08/40] ARM: MSM: update clock source registration Russell King - ARM Linux
2010-12-20 3:32 ` [PATCH 0/40] Complete set of clocksource/sched_clock patches Eric Miao
@ 2010-12-21 19:24 ` Kevin Hilman
2010-12-22 7:24 ` Olof Johansson
2011-01-08 9:05 ` Wan ZongShun
4 siblings, 0 replies; 9+ messages in thread
From: Kevin Hilman @ 2010-12-21 19:24 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Alessandro Rubini, Bryan Huntsman, Colin Cross, Daniel Walker,
David Brown, Eric Miao, Erik Gilling, Hans J. Koch, Imre Kaloz,
Krzysztof Halasa, Kukjin Kim, Lennert Buytenhek, Jiandong Zheng,
Linus Walleij, linux-arm-msm, linux-omap, linux-samsung-soc,
linux-tegra, Nicolas Pitre, Olof Johansson, Sascha Hauer,
Scott Branden, STEricsson, Tony Lindgren, Viresh Kumar,
Wan ZongShun, linux-arm-kernel
Russell King - ARM Linux <linux@arm.linux.org.uk> writes:
> Here is the entire set of clocksource and sched_clock patches which
> have been previously posted. There's a couple of small tweaks in a
> few of the patches (such as adding notrace to OMAP clocksource read
> functions), and this also shows the proper ordering of these patches.
>
> Still looking for acks or tested-by's for these patches.
Tested-by: Kevin Hilman <khilman@deeprootsystems.com>
on a few davinci platforms.
Kevin
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/40] Complete set of clocksource/sched_clock patches
2010-12-17 11:32 [PATCH 0/40] Complete set of clocksource/sched_clock patches Russell King - ARM Linux
` (2 preceding siblings ...)
2010-12-21 19:24 ` Kevin Hilman
@ 2010-12-22 7:24 ` Olof Johansson
2011-01-08 9:05 ` Wan ZongShun
4 siblings, 0 replies; 9+ messages in thread
From: Olof Johansson @ 2010-12-22 7:24 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Alessandro Rubini, Bryan Huntsman, Colin Cross, Daniel Walker,
David Brown, Eric Miao, Erik Gilling, Hans J. Koch, Imre Kaloz,
Kevin Hilman, Krzysztof Halasa, Kukjin Kim, Lennert Buytenhek,
Jiandong Zheng, Linus Walleij, linux-arm-msm, linux-omap,
linux-samsung-soc, linux-tegra, Nicolas Pitre, Sascha Hauer,
Scott Branden, STEricsson, Tony Lindgren, Viresh Kumar,
Wan ZongShun, linux-arm-kernel
On Fri, Dec 17, 2010 at 3:32 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> Here is the entire set of clocksource and sched_clock patches which
> have been previously posted. There's a couple of small tweaks in a
> few of the patches (such as adding notrace to OMAP clocksource read
> functions), and this also shows the proper ordering of these patches.
>
> Still looking for acks or tested-by's for these patches.
Tegra (see comment to that specific patch for a needed fixup):
Tested-by: Olof Johansson <olof@lixom.net>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 0/40] Complete set of clocksource/sched_clock patches
2010-12-17 11:32 [PATCH 0/40] Complete set of clocksource/sched_clock patches Russell King - ARM Linux
` (3 preceding siblings ...)
2010-12-22 7:24 ` Olof Johansson
@ 2011-01-08 9:05 ` Wan ZongShun
2011-01-08 9:23 ` Russell King - ARM Linux
4 siblings, 1 reply; 9+ messages in thread
From: Wan ZongShun @ 2011-01-08 9:05 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Alessandro Rubini, Bryan Huntsman, Colin Cross, Daniel Walker,
David Brown, Eric Miao, Erik Gilling, Hans J. Koch, Imre Kaloz,
Kevin Hilman, Krzysztof Halasa, Kukjin Kim, Lennert Buytenhek,
Jiandong Zheng, Linus Walleij, linux-arm-msm, linux-omap,
linux-samsung-soc, linux-tegra, Nicolas Pitre, Olof Johansson,
Sascha Hauer, Scott Branden, STEricsson
2010/12/17 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> Here is the entire set of clocksource and sched_clock patches which
> have been previously posted. There's a couple of small tweaks in a
> few of the patches (such as adding notrace to OMAP clocksource read
> functions), and this also shows the proper ordering of these patches.
>
> Still looking for acks or tested-by's for these patches.
>
Acked-By: Wan Zongshun <mcuos.com@gmail.com>
--
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
* linux-arm-NUC900 mailing list
mail addr:NUC900@googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 0/40] Complete set of clocksource/sched_clock patches
2011-01-08 9:05 ` Wan ZongShun
@ 2011-01-08 9:23 ` Russell King - ARM Linux
0 siblings, 0 replies; 9+ messages in thread
From: Russell King - ARM Linux @ 2011-01-08 9:23 UTC (permalink / raw)
To: Wan ZongShun
Cc: Alessandro Rubini, Bryan Huntsman, Colin Cross, Daniel Walker,
David Brown, Eric Miao, Erik Gilling, Hans J. Koch, Imre Kaloz,
Kevin Hilman, Krzysztof Halasa, Kukjin Kim, Lennert Buytenhek,
Jiandong Zheng, Linus Walleij, linux-arm-msm, linux-omap,
linux-samsung-soc, linux-tegra, Nicolas Pitre, Olof Johansson,
Sascha Hauer, Scott Branden, STEricsson
On Sat, Jan 08, 2011 at 05:05:53PM +0800, Wan ZongShun wrote:
> 2010/12/17 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> > Here is the entire set of clocksource and sched_clock patches which
> > have been previously posted. There's a couple of small tweaks in a
> > few of the patches (such as adding notrace to OMAP clocksource read
> > functions), and this also shows the proper ordering of these patches.
> >
> > Still looking for acks or tested-by's for these patches.
> >
>
> Acked-By: Wan Zongshun <mcuos.com@gmail.com>
I'm afraid you're too late - it's already in mainline so your ack can't
be added.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread