From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Wool Subject: Re: [PATCH] drivers: mmc: msm: remove clock disable in probe Date: Wed, 19 Jan 2011 11:50:28 +0100 Message-ID: References: <1295374473-27872-1-git-send-email-dwalker@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:52273 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752796Ab1ASKu3 (ORCPT ); Wed, 19 Jan 2011 05:50:29 -0500 Received: by qwa26 with SMTP id 26so680479qwa.19 for ; Wed, 19 Jan 2011 02:50:29 -0800 (PST) In-Reply-To: <1295374473-27872-1-git-send-email-dwalker@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Daniel Walker Cc: davidb@quicinc.com, linux-arm-msm@vger.kernel.org, Sahitya Tummala , linux-arm-kernel@lists.infradead.org Hi, On Tue, Jan 18, 2011 at 7:14 PM, Daniel Walker wrote: > The probe function adds the MMC host which can start accepting request > immediately. There is an assumption here that no requests happen > immediatly, but it's not always the case. This assumption can causes > a BUG() when the clocks are disabled. The fix is to just remove the > clock disable in the probe function. > > Signed-off-by: Daniel Walker I can add acked-by and/or tested-by if needed. ~Vitaly