From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Swetland Subject: Re: [PATCH 0/7] Nexus One Support Date: Sat, 22 Jan 2011 11:59:41 -0800 Message-ID: References: <20110121094827.41818a55@jbarnes-desktop> <20110121095658.1ab623fe@jbarnes-desktop> <1295632828.19880.22.camel@m0nster> <20110121100441.06a94482@jbarnes-desktop> <1295633882.19880.31.camel@m0nster> <1295642995.19880.42.camel@m0nster> <1295643762.25868.31.camel@Joe-Laptop> <1295645098.22882.1.camel@m0nster> <20110122122018.GC5194@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp-out.google.com ([74.125.121.67]:25965 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851Ab1AVT7q convert rfc822-to-8bit (ORCPT ); Sat, 22 Jan 2011 14:59:46 -0500 Received: from kpbe17.cbf.corp.google.com (kpbe17.cbf.corp.google.com [172.25.105.81]) by smtp-out.google.com with ESMTP id p0MJxirB005354 for ; Sat, 22 Jan 2011 11:59:45 -0800 Received: from yxd30 (yxd30.prod.google.com [10.190.1.222]) by kpbe17.cbf.corp.google.com with ESMTP id p0MJxhVP006941 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT) for ; Sat, 22 Jan 2011 11:59:43 -0800 Received: by yxd30 with SMTP id 30so798971yxd.22 for ; Sat, 22 Jan 2011 11:59:43 -0800 (PST) In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Nicolas Pitre Cc: Russell King - ARM Linux , Pekka Enberg , Daniel Walker , linux-arm-msm@vger.kernel.org, lkml , Jesse Barnes , Dima Zavin , Joe Perches , davidb@codeaurora.org, linux-arm-kernel@lists.infradead.org On Sat, Jan 22, 2011 at 11:49 AM, Nicolas Pitre wrot= e: > On Sat, 22 Jan 2011, Brian Swetland wrote: > >> All we ask is that some reasonable acknowledgement of original >> authorship is maintained for non-trivial work. =C2=A0A 5-10 line pat= ch that >> deals with mechanical issues of board files or cleans stuff up is no >> big deal. =C2=A0100s of lines that represent some real work is somet= hing >> else. > > So... What about http://article.gmane.org/gmane.linux.ports.arm.msm/1= 67 ? > Is that good enough for you? =C2=A0If no, then could you please propo= se an > alternative? =C2=A0If that is indeed good enough, then could we pleas= e move on? Something like: Based on code written by: is absolutely fine by me. Including patch counts, etc, is not essentia= l. >> What would be useful would be a reasonable convention for >> acknowledging multiple authors, perhaps something along the lines of= : >> >> Author: Awesome Upstreamer =C2=A0or =C2=A0Main Auth= or >> Committer: Awesome Upstreamer >> Subject: arm: msm8k: acpu clock management >> >> ... summary of the patch ... >> >> Original-Author: Joe Firmware Guy >> Original-Author: Kernel Droid >> Signed-off-by: ... >> >> Though I'm not sure "Original-Author" is the best phrasing here... =C2= =A0Or >> perhaps just having the patch description end with "This patch is >> based on original code by Joe Firmware Guy, Kernel Droid, etc is the >> way to go. =C2=A0I do think that for work where there is one clear o= riginal >> author, it's nice to leave them as the Author, but at the end of the >> day, provided the code's heading in the right direction and the >> contributors are acknowledged, that's a detail. > > I think a free form list of contributors in the commit log should be > fine, possibly adding them in CC to the patch submission as well. That seems reasonable to me. > There is a _huge_ value in the action of making code palatable for > mainline inclusion and actually pushing that code into mainline. If y= ou > do it yourself next time instead of letting your code rot then no one > might be tempted to stump on your authorship. Certainly. As long as we're acknowledging both the contributions of those who wrote the code and those who are doing the heavy lifting to get it upstream, we're happy. We are, of course, working on doing things better in the future -- the tegra2 efforts are a direct result of our desire to get things right on a newer project. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html