From: Mike Frysinger <vapier.adi@gmail.com>
To: Gregory Bean <gbean@codeaurora.org>
Cc: akpm@linux-foundation.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
"David S. Miller" <davem@davemloft.net>,
Samuel Ortiz <sameo@linux.intel.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@codeaurora.org>,
Bryan Huntsman <bryanh@codeaurora.org>
Subject: Re: [PATCH 1/2 v4] gpio: msm7200a: Add gpiolib support for MSM chips.
Date: Tue, 15 Jun 2010 17:18:12 -0400 [thread overview]
Message-ID: <AANLkTinSE9pO-UtNyTecEovU7gG9G1PIwK_-0__XflrP@mail.gmail.com> (raw)
In-Reply-To: <1276636268-4891-2-git-send-email-gbean@codeaurora.org>
On Tue, Jun 15, 2010 at 17:11, Gregory Bean wrote:
> +config GPIO_MSM7200A
> + tristate "Qualcomm MSM7200A SoC GPIO support"
> + depends on GPIOLIB
> + help
> + Say yes here to support GPIO functionality on Qualcomm's
> + MSM chipsets which descend from the MSM7200a:
> + MSM7x01(a), MSM7x25, MSM7x27, MSM7x30, QSD8x50(a).
you should mention the module name in the help text
> +static int msm_gpio_probe(struct platform_device *dev)
should have __devinit markings
> +static int msm_gpio_remove(struct platform_device *dev)
__devexit
> + .remove = msm_gpio_remove,
__devexit_p()
> +postcore_initcall(msm_gpio_init);
does this really need to be postcore rather than module ?
-mike
next prev parent reply other threads:[~2010-06-15 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 21:11 [PATCH 0/2 v4] gpio: msm7200a: Add gpiolib support for MSM chips Gregory Bean
2010-06-15 21:11 ` [PATCH 1/2 " Gregory Bean
2010-06-15 21:18 ` Mike Frysinger [this message]
2010-06-15 21:11 ` [PATCH 2/2 v4] gpio: msm7200a: Add irq support to msm-gpiolib Gregory Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinSE9pO-UtNyTecEovU7gG9G1PIwK_-0__XflrP@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=bryanh@codeaurora.org \
--cc=davem@davemloft.net \
--cc=davidb@codeaurora.org \
--cc=dwalker@codeaurora.org \
--cc=gbean@codeaurora.org \
--cc=joe@perches.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).