linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tony Lindgren <tony@atomide.com>,
	Russell King <rmk@arm.linux.org.uk>,
	Daniel Walker <dwalker@codeaurora.org>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-msm@vger.kernel.org,
	Vegard Nossum <vegard.nossum@gmail.com>
Subject: Re: ARM defconfig files
Date: Sat, 5 Jun 2010 19:39:07 +0300	[thread overview]
Message-ID: <AANLkTinl_D5ZRaSru6B-Hq4ciAi4CTXhDtDG33AdWWW6@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1006050734370.8175@i5.linux-foundation.org>

On Sat, Jun 5, 2010 at 5:39 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Sat, 5 Jun 2010, Felipe Contreras wrote:
>>
>> How about instead of using full defconfigs, we use minimal ones and
>> let the rest be determined with defaults.
>
> I wouldn't mind that either, but there needs to be some way to check that
> they _are_ minimal. Which is more complicated than even SAT, afaik.

I don't think so. The SAT should be able to come up with a minimal
config for 'CONFIG_MACH_OMAP3_BEAGLE=y', and then a minimal config for
whatever is in omap3_beagle_defconfig. The diff is either unnecessary,
or the Kconfig files are missing some 'default y if whatever'. You fix
the Kconfig files, and then use the resulting minimal config.

> So the reason I don't like the "minimal defconfig" notion is that a
> "regular defconfig" will work equally well, and lazy people will thus not
> bother to make it minimal (because it's work) and instead just pick the
> full config output.
>
> And we're all lazy. So gearing the process towards something that makes it
> easy for lazy cases to do the wrong thing is a bad thing.

Yes, that's why I lean toward the solution that creates an ideal
config with the minimal effort: SAT with a single
CONFIG_MACH_OMAP3_BEAGLE=y. Then you don't need defconfigs at all.

> We also don't have any way to "source" these config files from each other,
> so there's no way from within such a config file to say "use the basic
> omap3 defaults an then just add this on top". You can do it by
> concatenating several such files manually from the Makefile or whatever
> script, of course, but then you end up with the files themselves not
> actually describing what they do.

I don't really see the big need for hierarchical configs. When you do
'make ARCH=arm' you are already including all the arm stuff, so
there's no need for an ARM base config. Then you would need some
platform stuff like OMAP3, but if you do CONFIG_ARCH_OMAP3=y, and
there are proper 'default y if ARCH_OMAP3' in the Kconfigs, you don't
need any base config either. The rest of the stuff is truly specific
to the boards.

If there's a need to include other configs, I'm sure we can come with
markups to include them and have a parser script that generates the
.config.

> That's why I suggested the Kconfig format instead. It's the exact same
> idea, but it's a "before pre-processing" format that already supports
> including other files.

Yes, although I don't like the format (it looks clearly designed for
something else), it's another possibility. However, I don't think
"allnoconfig" makes sense because that would ignore the default hints
already present in Kconfig files.

-- 
Felipe Contreras

  reply	other threads:[~2010-06-05 16:39 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100603074548.GA12104@flint.arm.linux.org.uk>
2010-06-03 14:48 ` ARM defconfig files Linus Torvalds
2010-06-03 16:46   ` Tony Lindgren
2010-06-03 18:13     ` Russell King
2010-06-03 21:33       ` Tony Lindgren
2010-06-03 22:45         ` Nicolas Pitre
2010-06-04  4:59           ` Tony Lindgren
2010-06-04  0:23       ` Kevin Hilman
2010-06-04  4:53         ` Tony Lindgren
2010-06-04  1:02       ` Benjamin Herrenschmidt
2010-06-04  5:29         ` Tony Lindgren
2010-06-04  6:30         ` Geert Uytterhoeven
2010-06-04  6:53           ` Geert Uytterhoeven
2010-06-04  8:52           ` Benjamin Herrenschmidt
2010-06-03 16:53   ` Daniel Walker
2010-06-08 15:30     ` Catalin Marinas
2010-06-08 16:37       ` Daniel Walker
2010-06-03 18:10   ` Russell King
2010-06-03 18:18     ` Linus Torvalds
2010-06-03 18:53       ` Russell King
2010-06-03 18:56         ` Linus Torvalds
2010-06-03 19:20           ` Russell King
2010-06-03 19:35           ` Daniel Walker
2010-06-03 19:45             ` Russell King
2010-06-03 19:49               ` Daniel Walker
2010-06-03 19:57                 ` Russell King
2010-06-03 20:06                   ` Daniel Walker
2010-06-03 20:18                     ` Russell King
2010-06-03 20:20                   ` Nicolas Pitre
2010-06-04  1:06                   ` Benjamin Herrenschmidt
2010-06-03 20:09               ` Linus Torvalds
2010-06-03 20:31                 ` Linus Torvalds
2010-06-03 21:17                   ` Tony Lindgren
2010-06-03 22:15                     ` Grant Likely
2010-06-04  5:18                       ` Felipe Balbi
2010-06-04 11:31                       ` Catalin Marinas
2010-06-03 22:24                     ` Daniel Walker
2010-06-05 14:12                     ` Felipe Contreras
2010-06-05 14:39                       ` Linus Torvalds
2010-06-05 16:39                         ` Felipe Contreras [this message]
2010-06-03 21:48                   ` Daniel Walker
2010-06-04  0:36                   ` Paul Mackerras
2010-06-04 12:39                     ` Grant Likely
2010-06-05 13:47                   ` Felipe Contreras
2010-06-03 20:34                 ` Nicolas Pitre
2010-06-03 20:05             ` Linus Torvalds
2010-06-06  3:28         ` david
2010-06-03 18:20     ` Daniel Walker
2010-06-03 18:21       ` Linus Torvalds
2010-06-03 18:30         ` Al Viro
2010-06-03 19:26         ` Paul Mundt
2010-06-14  8:32         ` Uwe Kleine-König
2010-06-30 10:40           ` Uwe Kleine-König
2010-07-12 15:55             ` Uwe Kleine-König
2010-07-12 16:51               ` Linus Torvalds
2010-07-12 17:32                 ` Russell King - ARM Linux
2010-07-12 17:40                   ` Linus Torvalds
2010-07-12 18:50                     ` Uwe Kleine-König
2010-07-12 19:04                       ` Linus Torvalds
2010-07-12 19:17                         ` Nicolas Pitre
2010-07-12 19:34                           ` Linus Torvalds
2010-07-12 19:50                             ` Grant Likely
2010-07-13  7:07                               ` Uwe Kleine-König
2010-07-13  8:07                                 ` optimized script [Was: ARM defconfig files] Uwe Kleine-König
2010-07-13 18:04                                   ` Olof Johansson
2010-07-13 23:39                                     ` Nicolas Pitre
2010-07-13 18:32                                 ` ARM defconfig files Grant Likely
2010-07-12 19:59                             ` Uwe Kleine-König
2010-07-12 20:14                             ` Nicolas Pitre
2010-07-12 19:09                       ` Nicolas Pitre
2010-07-12 20:31                       ` Arnd Bergmann
2010-07-12 20:50                         ` Nicolas Pitre
2010-07-12 23:05                       ` David Brown
2010-07-12 23:18                         ` Linus Torvalds
2010-07-12 23:34                           ` David Brown
2010-07-13  0:55                             ` Nicolas Pitre
2010-07-14  9:13                             ` Felipe Contreras
2010-07-14 13:20                             ` Uwe Kleine-König
2010-07-14 17:37                               ` Tony Luck
2010-07-13 18:32                           ` Rob Landley
2010-07-12 20:06                     ` Russell King - ARM Linux
2010-07-12 20:29                       ` Nicolas Pitre
2010-07-12 21:54                         ` Linus Torvalds
2010-07-14  9:21                       ` Felipe Contreras
2010-06-03 18:41       ` Russell King
2010-06-03 18:53         ` Linus Torvalds
2010-06-06  3:53         ` david

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinl_D5ZRaSru6B-Hq4ciAi4CTXhDtDG33AdWWW6@mail.gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=dwalker@codeaurora.org \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=tony@atomide.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).