From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56361C433F5 for ; Thu, 23 Sep 2021 05:20:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FE87611C6 for ; Thu, 23 Sep 2021 05:20:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239137AbhIWFWT (ORCPT ); Thu, 23 Sep 2021 01:22:19 -0400 Received: from ixit.cz ([94.230.151.217]:53778 "EHLO ixit.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbhIWFWT (ORCPT ); Thu, 23 Sep 2021 01:22:19 -0400 Received: from [10.111.222.169] (ixit.cz [94.230.151.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ixit.cz (Postfix) with ESMTPSA id B555823B26; Thu, 23 Sep 2021 07:20:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ixit.cz; s=dkim; t=1632374446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cFfRp9hRc2lQUu9wZPFFHqwIGiNz/3vf6zUsUc5shkg=; b=CanIE2BlFjfAJzudFVKoZFhT0A3sC3uvnAWt2+SFQtYXDGTBG65+VwECxCFi7cJfQh/Ebr HeAL0VtANKJpwE1c/EYiOYy10zxbwdQ7zH4HzPVq0IeHnlbRdpx8xCSb70k4a11N2sxBvg 0IZsOU4kE5CoEB7bn23xOBjF6wiXJzU= Date: Thu, 23 Sep 2021 07:19:23 +0200 From: David Heidelberg Subject: Re: [PATCH] mfd: qcom-pm8xxx: switch away from using chained IRQ handlers To: Linus Walleij Cc: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Lee Jones , MSM , phone-devel@vger.kernel.org Message-Id: In-Reply-To: References: <20210921162433.1858296-1-dmitry.baryshkov@linaro.org> X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org with this patch, it does boot without any problems or warnings regarding to IRQ. Tested-by: David Heidelberg Best regards David Heidelberg On Thu, Sep 23 2021 at 02:04:10 +0200, Linus Walleij wrote: > On Tue, Sep 21, 2021 at 6:24 PM Dmitry Baryshkov > wrote: > >> PM8xxx PMIC family uses GPIO as parent IRQ. Using it together with >> the >> irq_set_chained_handler_and_data() results in warnings from the >> GPIOLIB >> as in this path the IRQ resources are not allocated (and thus the >> corresponding GPIO is not marked as used for the IRQ. Use >> request_irq so >> that the IRQ resources are proprely setup. >> >> Signed-off-by: Dmitry Baryshkov > > I sent this patch: > https://lore.kernel.org/lkml/20210819154400.51932-1-linus.walleij@linaro.org/ > > David Heidelberg reported that it didn't work for him. > > David can you test Dmitry's patch instead and see if that works > for you, I suppose I could have some bug in my patch :/ > It would be nice with a Tested-by from David. > > FWIW the code looks good: > Reviewed-by: Linus Walleij > > Yours, > Linus Walleij