From: Skacore Systems <skacore.systems@gmail.com>
To: balbi@ti.com
Cc: linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] s3c2410_udc: udc command always disables pull-up instead of passing the command
Date: Wed, 15 Jun 2011 09:30:00 +0200 [thread overview]
Message-ID: <BANLkTi==s4adWqt0uLhJHmeDe1H2RD_5Bw@mail.gmail.com> (raw)
In-Reply-To: <20110614164900.GR2353@legolas.emea.dhcp.ti.com>
I don't care much about pushing this into mainline. It's a bug and
it's up to kernel developers to fix that.
I was aware that kernel devs are bunch of lazy dicks and I'm not going
to do more work for one line patch.
Howg.
On Tue, Jun 14, 2011 at 6:49 PM, Felipe Balbi <balbi@ti.com> wrote:
> Hi,
>
> On Tue, Jun 14, 2011 at 04:58:40PM +0200, Skacore Systems wrote:
>> Sorry for the HTML,
>> There is a bug in s3c2410_udc driver, which triggers when using custom
>> UDC command for USB pull-up.
>> As a result driver is always calling user defined UDC command with
>> wrong parameter (S3C2410_UDC_P_DISABLE) instead of
>> just passing the parameter to the user defined function.
>
> please take a look at Documentation/SubmittingPatches and fix up your
> patch so that it can be applied. Also, when sending patches,
> scripts/get_maintainer.pl will give you a hint of who you should put on
> Cc ;-)
>
> --
> balbi
>
next prev parent reply other threads:[~2011-06-15 7:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 11:27 [PATCH] s3c2410_udc: udc command always disables pull-up instead of passing the command Skacore Systems
[not found] ` <BANLkTimL=+vaa7NB5FW192rZd08Gv-Z-OA@mail.gmail.com>
[not found] ` <BANLkTimL=+vaa7NB5FW192rZd08Gv-Z-OA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-14 14:58 ` Skacore Systems
[not found] ` <BANLkTik+TD1+k1hd-hEteE5OTeDrDAuMZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-14 16:49 ` Felipe Balbi
2011-06-15 7:30 ` Skacore Systems [this message]
2011-06-15 8:38 ` Felipe Balbi
2011-06-15 8:43 ` Skacore Systems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi==s4adWqt0uLhJHmeDe1H2RD_5Bw@mail.gmail.com' \
--to=skacore.systems@gmail.com \
--cc=balbi@ti.com \
--cc=gregkh@suse.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).