[PATCH] s3c2410_udc: udc command always disables pull-up instead of passing the command

[PATCH] s3c2410_udc: udc command always disables pull-up instead of passing the command

[Skacore Systems]

Hello *,
There is a bug in s3c2410_udc driver, which triggers when using custom
UDC command for USB pull-up.
As a result driver is always calling user defined UDC command with
wrong parameter (S3C2410_UDC_P_DISABLE) instead of
just passing the parameter to the user defined function.

BR.

Vilo

--- Linux-2.6.39-wp/2.6.39/drivers/usb/gadget/s3c2410_udc.c
2011-05-19 06:06:34.000000000 +0200
+++ Linux-2.6.39/linux-paytec/drivers/usb/gadget/s3c2410_udc.c
2011-06-14 11:59:55.000000000 +0200
@@ -1566,7 +1566,7 @@
                return;
        if (udc_info->udc_command) {
-               udc_info->udc_command(S3C2410_UDC_P_DISABLE);
+               udc_info->udc_command(cmd);
        } else if (gpio_is_valid(udc_info->pullup_pin)) {
                int value;

[PATCH] s3c2410_udc: udc command always disables pull-up instead of passing the command

[Skacore Systems]

Hello *,

Sorry for the HTML,
There is a bug in s3c2410_udc driver, which triggers when using custom
UDC command for USB pull-up.
As a result driver is always calling user defined UDC command with
wrong parameter (S3C2410_UDC_P_DISABLE) instead of
just passing the parameter to the user defined function.

BR.

Vilo

--- Linux-2.6.39-wp/2.6.39/drivers/usb/gadget/s3c2410_udc.c
2011-05-19 06:06:34.000000000 +0200
+++ Linux-2.6.39/linux-paytec/drivers/usb/gadget/s3c2410_udc.c
2011-06-14 11:59:55.000000000 +0200
@@ -1566,7 +1566,7 @@
                return;
        if (udc_info->udc_command) {
-               udc_info->udc_command(S3C2410_UDC_P_DISABLE);
+               udc_info->udc_command(cmd);
        } else if (gpio_is_valid(udc_info->pullup_pin)) {
                int value;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] s3c2410_udc: udc command always disables pull-up instead of passing the command

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

Hi,

On Tue, Jun 14, 2011 at 04:58:40PM +0200, Skacore Systems wrote:
> Sorry for the HTML,
> There is a bug in s3c2410_udc driver, which triggers when using custom
> UDC command for USB pull-up.
> As a result driver is always calling user defined UDC command with
> wrong parameter (S3C2410_UDC_P_DISABLE) instead of
> just passing the parameter to the user defined function.

please take a look at Documentation/SubmittingPatches and fix up your
patch so that it can be applied. Also, when sending patches,
scripts/get_maintainer.pl will give you a hint of who you should put on
Cc ;-)

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

Re: [PATCH] s3c2410_udc: udc command always disables pull-up instead of passing the command

[Skacore Systems]

I don't care much about pushing this into mainline. It's a bug and
it's up to kernel developers to fix that.
I was aware that kernel devs are bunch of lazy dicks and I'm not going
to do more work for one line patch.

Howg.

On Tue, Jun 14, 2011 at 6:49 PM, Felipe Balbi <balbi@ti.com> wrote:
> Hi,
>
> On Tue, Jun 14, 2011 at 04:58:40PM +0200, Skacore Systems wrote:
>> Sorry for the HTML,
>> There is a bug in s3c2410_udc driver, which triggers when using custom
>> UDC command for USB pull-up.
>> As a result driver is always calling user defined UDC command with
>> wrong parameter (S3C2410_UDC_P_DISABLE) instead of
>> just passing the parameter to the user defined function.
>
> please take a look at Documentation/SubmittingPatches and fix up your
> patch so that it can be applied. Also, when sending patches,
> scripts/get_maintainer.pl will give you a hint of who you should put on
> Cc ;-)
>
> --
> balbi
>

Re: [PATCH] s3c2410_udc: udc command always disables pull-up instead of passing the command

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

Hi,

On Wed, Jun 15, 2011 at 09:30:00AM +0200, Skacore Systems wrote:
> I don't care much about pushing this into mainline. It's a bug and
> it's up to kernel developers to fix that.
> I was aware that kernel devs are bunch of lazy dicks and I'm not going
> to do more work for one line patch.

You are the lazy dick here. All I asked was to follow our standards, do
you have any idea how many patches each kernel maintainer has to go
through ? It doesn't scale if we have to re-format the ugly crap you
send us.

Get over yourself and if you want this fixed, then send a proper patch.

It's just a small set of instructions we are asking you to follow, try
saying the same to your Income Tax office and see if they'll like that
you didn't follow their instructions.

Lazy dicks... hah... the one who can't get a simple set of instructions
right is calling us lazy dicks. What a prick!

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

Re: [PATCH] s3c2410_udc: udc command always disables pull-up instead of passing the command

[Skacore Systems]

You're lazy. I've already fixed it where I needed. You just trolling
about some rules for one line patch.
I'm not wasting any more time in this discussion.

On Wed, Jun 15, 2011 at 10:38 AM, Felipe Balbi <balbi@ti.com> wrote:
> Hi,
>
> On Wed, Jun 15, 2011 at 09:30:00AM +0200, Skacore Systems wrote:
>> I don't care much about pushing this into mainline. It's a bug and
>> it's up to kernel developers to fix that.
>> I was aware that kernel devs are bunch of lazy dicks and I'm not going
>> to do more work for one line patch.
>
> You are the lazy dick here. All I asked was to follow our standards, do
> you have any idea how many patches each kernel maintainer has to go
> through ? It doesn't scale if we have to re-format the ugly crap you
> send us.
>
> Get over yourself and if you want this fixed, then send a proper patch.
>
> It's just a small set of instructions we are asking you to follow, try
> saying the same to your Income Tax office and see if they'll like that
> you didn't follow their instructions.
>
> Lazy dicks... hah... the one who can't get a simple set of instructions
> right is calling us lazy dicks. What a prick!
>
> --
> balbi
>