From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver Date: Fri, 11 Nov 2016 09:11:42 -0300 Message-ID: References: <1478540043-24558-1-git-send-email-stanimir.varbanov@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Hans Verkuil Cc: Stanimir Varbanov , Mauro Carvalho Chehab , Andy Gross , Bjorn Andersson , Stephen Boyd , Srinivas Kandagatla , Linux Media Mailing List , Linux Kernel , linux-arm-msm@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org Hello Hans, On Fri, Nov 11, 2016 at 8:49 AM, Hans Verkuil wrote: > Hi Stanimir, > > Overall it looks good. As you saw, I do have some comments but nothing major. > > One question: you use qcom as the directory name. How about using qualcomm? > > It's really not that much longer and a bit more obvious. > > Up to you, though. > It seems qcom is more consistent to the name used in most subsystems for Qualcomm: $ find -name *qcom ./arch/arm/mach-qcom ./arch/arm64/boot/dts/qcom ./Documentation/devicetree/bindings/soc/qcom ./sound/soc/qcom ./drivers/pinctrl/qcom ./drivers/soc/qcom ./drivers/clk/qcom $ find -name *qualcomm ./drivers/net/ethernet/qualcomm > Regards, > > Hans > Best regards, Javier