From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] pinctrl: qcom: spmi-mpp: Fix drive strength setting Date: Mon, 10 Sep 2018 09:31:47 +0200 Message-ID: References: <20180831005852.156465-1-swboyd@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180831005852.156465-1-swboyd@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Boyd Cc: "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Doug Anderson List-Id: linux-arm-msm@vger.kernel.org On Fri, Aug 31, 2018 at 2:58 AM Stephen Boyd wrote: > It looks like we parse the drive strength setting here, but never > actually write it into the hardware to update it. Parse the setting and > then write it at the end of the pinconf setting function so that it > actually sticks in the hardware. > > Fixes: 0e948042c420 ("pinctrl: qcom: spmi-mpp: Implement support for sink mode") > Cc: Bjorn Andersson > Cc: Doug Anderson > Signed-off-by: Stephen Boyd Patch applied with Bjorn's ACK. Yours, Linus Walleij