linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: vkoul@kernel.org
Cc: linux-crypto@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Matt Mackall <mpm@selenic.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-arm-msm@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
	Timur Tabi <timur@codeaurora.org>,
	jhugo@codeaurora.org
Subject: Re: [PATCH v5 3/6] crypto: Add Qcom prng driver
Date: Sat, 14 Jul 2018 12:16:37 +0200	[thread overview]
Message-ID: <CACRpkdYk11wNMFFFqbVXgRtPCrvq25MOHDrG_dikCr31oUWyqA@mail.gmail.com> (raw)
In-Reply-To: <20180709061925.20276-4-vkoul@kernel.org>

On Mon, Jul 9, 2018 at 8:20 AM Vinod Koul <vkoul@kernel.org> wrote:

> This ports the Qcom prng from older hw_random driver.
>
> No change of functionality and move from hw_random to crypto
> APIs is done.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>

FWIW:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>


> +config CRYPTO_DEV_QCOM_RNG
> +       tristate "Qualcomm Randon Number Generator Driver"

Random speling error.

> +#include <linux/of_device.h>

Do you need this? It seems like a platform device fair and square.

Yours,
Linus Walleij

  reply	other threads:[~2018-07-14 10:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09  6:19 [PATCH v5 0/6] crypto: Add Qcom PRNG support Vinod Koul
2018-07-09  6:19 ` [PATCH v5 1/6] hwrng: remove msm hw_random driver Vinod Koul
2018-07-09  6:19 ` [PATCH v5 2/6] dt-bindings: crypto: Move prng binding to crypto Vinod Koul
2018-07-09  6:19 ` [PATCH v5 3/6] crypto: Add Qcom prng driver Vinod Koul
2018-07-14 10:16   ` Linus Walleij [this message]
2018-07-16  4:15     ` Vinod
2018-07-16  5:29       ` Vinod
2018-07-09  6:19 ` [PATCH v5 4/6] dt-bindings: crypto: Add new compatible qcom,prng-ee Vinod Koul
2018-07-09  6:19 ` [PATCH v5 5/6] crypto: qcom: Add support for prng-ee Vinod Koul
2018-07-09  6:19 ` [PATCH v5 6/6] crypto: qcom: Add ACPI support Vinod Koul
2018-07-10 17:27   ` Jeffrey Hugo
2018-07-10 23:37     ` Timur Tabi
2018-07-11  4:09     ` Vinod

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdYk11wNMFFFqbVXgRtPCrvq25MOHDrG_dikCr31oUWyqA@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=swboyd@chromium.org \
    --cc=timur@codeaurora.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).