From: Linus Walleij <linus.walleij@linaro.org>
To: "Lothar Waßmann" <LW@karo-electronics.de>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
linux-soc@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 2/4] soc: qcom: add EBI2 driver
Date: Wed, 24 Aug 2016 11:09:15 +0200 [thread overview]
Message-ID: <CACRpkdZCsCXWq4DfZSLzduHnpMPVUkmiZMDG8LjGcTHwgYEKkA@mail.gmail.com> (raw)
In-Reply-To: <20160818140717.7b5c2bbd@ipc1.ka-ro>
On Thu, Aug 18, 2016 at 2:07 PM, Lothar Waßmann <LW@karo-electronics.de> wrote:
>> +#define EBI2_CSN_MASK BIT(2)|BIT(3)|BIT(4)|BIT(5)|BIT(6)|BIT(7)
>> +
> missing '()' around expression, otherwise...
>
>> + csval &= ~EBI2_CSN_MASK;
> ...this will be '~BIT(2) | BIT(3) | BIT(4) | BIT(5) | BIT(6) | BIT(7)'
> which is most likely NOT what's intended.
>
> (Also spaces around the '|' operator would improve readability)
Sorry for not mentioning in my latest v2 revision: I solved this
by using GENMASK(0,9) (yeah it also turns out to be more
than 8 bits of CS...)
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-08-24 9:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 21:24 [PATCH 0/4] Qualcomm MSM8660/APQ8060 EBI2 and ethernet support Linus Walleij
[not found] ` <1470691445-27571-1-git-send-email-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-08-08 21:24 ` [PATCH 1/4] soc: qcom: add an EBI2 device tree bindings Linus Walleij
[not found] ` <1470691445-27571-2-git-send-email-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-08-08 21:32 ` Arnd Bergmann
2016-08-18 8:14 ` Linus Walleij
2016-08-29 11:51 ` Arnd Bergmann
2016-08-29 12:24 ` Rob Herring
[not found] ` <CAL_JsqJPckLGDSiqnspvtP_=t+yZ+0vO-8MxGB6x7poOZiyK+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-29 13:13 ` Linus Walleij
2016-08-29 13:42 ` Arnd Bergmann
[not found] ` <201608291542.55387.arnd-r2nGTMty4D4@public.gmane.org>
2016-08-29 16:18 ` Linus Walleij
[not found] ` <CACRpkdaRPa=tCH2FQUOUzp0Q2YvdLNA7R2y3w==sH40DwJ2vGA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-29 14:06 ` Rob Herring
2016-08-29 17:21 ` Linus Walleij
2016-08-29 22:51 ` Rob Herring
[not found] ` <201608291351.12915.arnd-r2nGTMty4D4@public.gmane.org>
2016-08-29 12:45 ` Linus Walleij
2016-08-10 20:31 ` Rob Herring
2016-08-08 21:24 ` [PATCH 2/4] soc: qcom: add EBI2 driver Linus Walleij
2016-08-08 21:34 ` Arnd Bergmann
2016-08-08 23:33 ` Stephen Boyd
2016-08-18 11:27 ` Linus Walleij
2016-08-18 12:07 ` Lothar Waßmann
2016-08-24 9:09 ` Linus Walleij [this message]
2016-08-08 21:24 ` [PATCH 3/4] ARM: dts: add EBI2 to the Qualcomm MSM8660 DTSI Linus Walleij
2016-08-08 21:24 ` [PATCH 4/4] ARM: dts: add SMSC ethernet on the APQ8060 Dragonboard Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2016-07-08 9:11 [PATCH 0/4] soc: qcom: add EBI2 support and do ethernet Linus Walleij
2016-07-08 9:12 ` [PATCH 2/4] soc: qcom: add EBI2 driver Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZCsCXWq4DfZSLzduHnpMPVUkmiZMDG8LjGcTHwgYEKkA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=LW@karo-electronics.de \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).