From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 2/4] soc: qcom: add EBI2 driver Date: Wed, 24 Aug 2016 11:09:15 +0200 Message-ID: References: <1470691445-27571-1-git-send-email-linus.walleij@linaro.org> <1470691445-27571-3-git-send-email-linus.walleij@linaro.org> <20160818140717.7b5c2bbd@ipc1.ka-ro> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-oi0-f54.google.com ([209.85.218.54]:35680 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753751AbcHXJJQ (ORCPT ); Wed, 24 Aug 2016 05:09:16 -0400 Received: by mail-oi0-f54.google.com with SMTP id 4so14195433oih.2 for ; Wed, 24 Aug 2016 02:09:16 -0700 (PDT) In-Reply-To: <20160818140717.7b5c2bbd@ipc1.ka-ro> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: =?UTF-8?Q?Lothar_Wa=C3=9Fmann?= Cc: "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , linux-soc@vger.kernel.org, Andy Gross , David Brown , Stephen Boyd , Bjorn Andersson On Thu, Aug 18, 2016 at 2:07 PM, Lothar Wa=C3=9Fmann wrote: >> +#define EBI2_CSN_MASK BIT(2)|BIT(3)|BIT(4)|BIT(5)|BIT(6)|BIT(7) >> + > missing '()' around expression, otherwise... > >> + csval &=3D ~EBI2_CSN_MASK; > ...this will be '~BIT(2) | BIT(3) | BIT(4) | BIT(5) | BIT(6) | BIT(7)' > which is most likely NOT what's intended. > > (Also spaces around the '|' operator would improve readability) Sorry for not mentioning in my latest v2 revision: I solved this by using GENMASK(0,9) (yeah it also turns out to be more than 8 bits of CS...) Yours, Linus Walleij