From: abhilash jindal <jindal.abhilash@gmail.com>
To: David Brown <davidb@codeaurora.org>
Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>,
dwalker@codeaurora.org, bryanh@codeaurora.org
Subject: Re: [BUG] mach-msm/msm_vibrator.c - very long vibration if CPU suspends
Date: Thu, 12 Sep 2013 10:18:38 -0400 [thread overview]
Message-ID: <CADQFcNHNTMSXx5r-A132QsgwpWVJZAqUrd39gi1LEyqmyo+beA@mail.gmail.com> (raw)
In-Reply-To: <20130911194720.GA2818@codeaurora.org>
Thanks for the reply ! I reported it here because the bug is present
in the main android tree:
https://android.googlesource.com/kernel/msm.git/+/android-msm-2.6.35/arch/arm/mach-msm/msm_vibrator.c
abhilash
On Wed, Sep 11, 2013 at 3:47 PM, David Brown <davidb@codeaurora.org> wrote:
> On Wed, Sep 04, 2013 at 05:24:50PM -0400, abhilash jindal wrote:
>>
>> msm_vibrator.c uses hrtimer to switch off the phone vibration as follows-
>>
>> hrtimer_start(&vibe_timer, ktime_set(value / 1000, (value % 1000) *
>> 1000000), HRTIMER_MODE_REL);
>>
>> However, hrtimer does not get fired after the CPU suspends. Hence, if
>> the CPU suspends before the timer gets fired, the phone continues
>> vibrating until the next time when CPU wakes up causing unnecessary
>> battery drain (which can be as long as 15 minutes).
>>
>> IMHO, one way to fix it would be to replace hrtimer by android alarm
>> timer.
>
>
> It looks like this file exists only in the codeaurora.org MSM tree,
> and not in the mainline kernel. The first thing I'd mention is that
> if you are an MSM customer, you'll be much better off reporting this
> through the customer support chain.
>
> Otherwise, I can forward this information internally. I'm not sure if
> they'll be any response, since it doesn't appear to be used in any
> recent targets.
>
> David
>
> --
> sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
prev parent reply other threads:[~2013-09-12 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 21:24 [BUG] mach-msm/msm_vibrator.c - very long vibration if CPU suspends abhilash jindal
2013-09-11 19:47 ` David Brown
2013-09-12 14:18 ` abhilash jindal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADQFcNHNTMSXx5r-A132QsgwpWVJZAqUrd39gi1LEyqmyo+beA@mail.gmail.com \
--to=jindal.abhilash@gmail.com \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).