From mboxrd@z Thu Jan 1 00:00:00 1970 From: abhilash jindal Subject: Re: [BUG] mach-msm/msm_vibrator.c - very long vibration if CPU suspends Date: Thu, 12 Sep 2013 10:18:38 -0400 Message-ID: References: <20130911194720.GA2818@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-qe0-f48.google.com ([209.85.128.48]:39082 "EHLO mail-qe0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034Ab3ILOS6 (ORCPT ); Thu, 12 Sep 2013 10:18:58 -0400 Received: by mail-qe0-f48.google.com with SMTP id nd7so5765260qeb.35 for ; Thu, 12 Sep 2013 07:18:58 -0700 (PDT) In-Reply-To: <20130911194720.GA2818@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: David Brown Cc: linux-arm-msm , dwalker@codeaurora.org, bryanh@codeaurora.org Thanks for the reply ! I reported it here because the bug is present in the main android tree: https://android.googlesource.com/kernel/msm.git/+/android-msm-2.6.35/arch/arm/mach-msm/msm_vibrator.c abhilash On Wed, Sep 11, 2013 at 3:47 PM, David Brown wrote: > On Wed, Sep 04, 2013 at 05:24:50PM -0400, abhilash jindal wrote: >> >> msm_vibrator.c uses hrtimer to switch off the phone vibration as follows- >> >> hrtimer_start(&vibe_timer, ktime_set(value / 1000, (value % 1000) * >> 1000000), HRTIMER_MODE_REL); >> >> However, hrtimer does not get fired after the CPU suspends. Hence, if >> the CPU suspends before the timer gets fired, the phone continues >> vibrating until the next time when CPU wakes up causing unnecessary >> battery drain (which can be as long as 15 minutes). >> >> IMHO, one way to fix it would be to replace hrtimer by android alarm >> timer. > > > It looks like this file exists only in the codeaurora.org MSM tree, > and not in the mainline kernel. The first thing I'd mention is that > if you are an MSM customer, you'll be much better off reporting this > through the customer support chain. > > Otherwise, I can forward this information internally. I'm not sure if > they'll be any response, since it doesn't appear to be used in any > recent targets. > > David > > -- > sent by an employee of the Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation