From: Pankaj Jangra <jangra.pankaj9@gmail.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Saravana Kannan <skannan@codeaurora.org>
Subject: Re: [PATCH 07/10] ARM: msm: Remove clock-7x30.h include file
Date: Wed, 26 Sep 2012 23:21:59 +0530 [thread overview]
Message-ID: <CADTbHxqrPmnOHqqYyskC32bN269k-_pgk-+czwf7zLCs70ESzA@mail.gmail.com> (raw)
In-Reply-To: <1348194419-11486-8-git-send-email-sboyd@codeaurora.org>
Hi
On Fri, Sep 21, 2012 at 7:56 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> This file is not used outside of the two users in the clock-7x30
> array. Those two clocks are virtual "source" clocks that don't
> really need to exist outside of the clock driver. Let's remove
> them from the array, since they're not doing anything anyway, and
> then remove the clock-7x30.h include file along with it.
>
> Cc: Saravana Kannan <skannan@codeaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> arch/arm/mach-msm/clock-7x30.h | 155 ------------------------------------
> arch/arm/mach-msm/devices-msm7x30.c | 2 -
> 2 files changed, 157 deletions(-)
> delete mode 100644 arch/arm/mach-msm/clock-7x30.h
>
> diff --git a/arch/arm/mach-msm/clock-7x30.h b/arch/arm/mach-msm/clock-7x30.h
> deleted file mode 100644
> index 1410445..0000000
> --- a/arch/arm/mach-msm/clock-7x30.h
> +++ /dev/null
> @@ -1,155 +0,0 @@
> -/* Copyright (c) 2009, Code Aurora Forum. All rights reserved.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 and
> - * only version 2 as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - */
> -
> -#ifndef __ARCH_ARM_MACH_MSM_CLOCK_7X30_H
> -#define __ARCH_ARM_MACH_MSM_CLOCK_7X30_H
> -
> -enum {
> - L_7X30_NONE_CLK = -1,
> - L_7X30_ADM_CLK,
> - L_7X30_I2C_CLK,
> - L_7X30_I2C_2_CLK,
> - L_7X30_QUP_I2C_CLK,
> - L_7X30_UART1DM_CLK,
> - L_7X30_UART1DM_P_CLK,
> - L_7X30_UART2DM_CLK,
> - L_7X30_UART2DM_P_CLK,
> - L_7X30_EMDH_CLK,
> - L_7X30_EMDH_P_CLK,
> - L_7X30_PMDH_CLK,
> - L_7X30_PMDH_P_CLK,
> - L_7X30_GRP_2D_CLK,
> - L_7X30_GRP_2D_P_CLK,
> - L_7X30_GRP_3D_SRC_CLK,
> - L_7X30_GRP_3D_CLK,
> - L_7X30_GRP_3D_P_CLK,
> - L_7X30_IMEM_CLK,
> - L_7X30_SDC1_CLK,
> - L_7X30_SDC1_P_CLK,
> - L_7X30_SDC2_CLK,
> - L_7X30_SDC2_P_CLK,
> - L_7X30_SDC3_CLK,
> - L_7X30_SDC3_P_CLK,
> - L_7X30_SDC4_CLK,
> - L_7X30_SDC4_P_CLK,
> - L_7X30_MDP_CLK,
> - L_7X30_MDP_P_CLK,
> - L_7X30_MDP_LCDC_PCLK_CLK,
> - L_7X30_MDP_LCDC_PAD_PCLK_CLK,
> - L_7X30_MDP_VSYNC_CLK,
> - L_7X30_MI2S_CODEC_RX_M_CLK,
> - L_7X30_MI2S_CODEC_RX_S_CLK,
> - L_7X30_MI2S_CODEC_TX_M_CLK,
> - L_7X30_MI2S_CODEC_TX_S_CLK,
> - L_7X30_MI2S_M_CLK,
> - L_7X30_MI2S_S_CLK,
> - L_7X30_LPA_CODEC_CLK,
> - L_7X30_LPA_CORE_CLK,
> - L_7X30_LPA_P_CLK,
> - L_7X30_MIDI_CLK,
> - L_7X30_MDC_CLK,
> - L_7X30_ROTATOR_IMEM_CLK,
> - L_7X30_ROTATOR_P_CLK,
> - L_7X30_SDAC_M_CLK,
> - L_7X30_SDAC_CLK,
> - L_7X30_UART1_CLK,
> - L_7X30_UART2_CLK,
> - L_7X30_UART3_CLK,
> - L_7X30_TV_CLK,
> - L_7X30_TV_DAC_CLK,
> - L_7X30_TV_ENC_CLK,
> - L_7X30_HDMI_CLK,
> - L_7X30_TSIF_REF_CLK,
> - L_7X30_TSIF_P_CLK,
> - L_7X30_USB_HS_SRC_CLK,
> - L_7X30_USB_HS_CLK,
> - L_7X30_USB_HS_CORE_CLK,
> - L_7X30_USB_HS_P_CLK,
> - L_7X30_USB_HS2_CLK,
> - L_7X30_USB_HS2_CORE_CLK,
> - L_7X30_USB_HS2_P_CLK,
> - L_7X30_USB_HS3_CLK,
> - L_7X30_USB_HS3_CORE_CLK,
> - L_7X30_USB_HS3_P_CLK,
> - L_7X30_VFE_CLK,
> - L_7X30_VFE_P_CLK,
> - L_7X30_VFE_MDC_CLK,
> - L_7X30_VFE_CAMIF_CLK,
> - L_7X30_CAMIF_PAD_P_CLK,
> - L_7X30_CAM_M_CLK,
> - L_7X30_JPEG_CLK,
> - L_7X30_JPEG_P_CLK,
> - L_7X30_VPE_CLK,
> - L_7X30_MFC_CLK,
> - L_7X30_MFC_DIV2_CLK,
> - L_7X30_MFC_P_CLK,
> - L_7X30_SPI_CLK,
> - L_7X30_SPI_P_CLK,
> - L_7X30_CSI0_CLK,
> - L_7X30_CSI0_VFE_CLK,
> - L_7X30_CSI0_P_CLK,
> - L_7X30_CSI1_CLK,
> - L_7X30_CSI1_VFE_CLK,
> - L_7X30_CSI1_P_CLK,
> - L_7X30_GLBL_ROOT_CLK,
> -
> - L_7X30_AXI_LI_VG_CLK,
> - L_7X30_AXI_LI_GRP_CLK,
> - L_7X30_AXI_LI_JPEG_CLK,
> - L_7X30_AXI_GRP_2D_CLK,
> - L_7X30_AXI_MFC_CLK,
> - L_7X30_AXI_VPE_CLK,
> - L_7X30_AXI_LI_VFE_CLK,
> - L_7X30_AXI_LI_APPS_CLK,
> - L_7X30_AXI_MDP_CLK,
> - L_7X30_AXI_IMEM_CLK,
> - L_7X30_AXI_LI_ADSP_A_CLK,
> - L_7X30_AXI_ROTATOR_CLK,
> -
> - L_7X30_NR_CLKS
> -};
> -
> -struct clk_ops;
> -extern struct clk_ops clk_ops_7x30;
> -
> -struct clk_ops *clk_7x30_is_local(uint32_t id);
> -int clk_7x30_init(void);
> -
> -void pll_enable(uint32_t pll);
> -void pll_disable(uint32_t pll);
> -
> -extern int internal_pwr_rail_ctl_auto(unsigned rail_id, bool enable);
> -
> -#define CLK_7X30(clk_name, clk_id, clk_dev, clk_flags) { \
> - .con_id = clk_name, \
> - .dev_id = clk_dev, \
> - .clk = &(struct clk){ \
> - .id = L_7X30_##clk_id, \
> - .remote_id = P_##clk_id, \
> - .flags = clk_flags, \
> - .dbg_name = #clk_id, \
> - }, \
> - }
> -
> -#define CLK_7X30S(clk_name, l_id, r_id, clk_dev, clk_flags) { \
> - .con_id = clk_name, \
> - .dev_id = clk_dev, \
> - .clk = &(struct clk){ \
> - .id = L_7X30_##l_id, \
> - .remote_id = P_##r_id, \
> - .flags = clk_flags, \
> - .dbg_name = #l_id, \
> - .ops = &clk_ops_pcom, \
> - }, \
> - }
> -
> -#endif
> diff --git a/arch/arm/mach-msm/devices-msm7x30.c b/arch/arm/mach-msm/devices-msm7x30.c
> index 09b4f14..1597d43 100644
> --- a/arch/arm/mach-msm/devices-msm7x30.c
> +++ b/arch/arm/mach-msm/devices-msm7x30.c
> @@ -146,7 +146,6 @@ struct clk_lookup msm_clocks_7x30[] = {
> CLK_PCOM("grp_2d_pclk", GRP_2D_P_CLK, NULL, 0),
> CLK_PCOM("grp_clk", GRP_3D_CLK, NULL, 0),
> CLK_PCOM("grp_pclk", GRP_3D_P_CLK, NULL, 0),
> - CLK_7X30S("grp_src_clk", GRP_3D_SRC_CLK, GRP_3D_CLK, NULL, 0),
> CLK_PCOM("hdmi_clk", HDMI_CLK, NULL, 0),
> CLK_PCOM("imem_clk", IMEM_CLK, NULL, OFF),
I suppose you forget to remove the include header clock-7x30.h from
this file. :)
--
Pankaj Kumar
next prev parent reply other threads:[~2012-09-26 17:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 2:26 [PATCH 00/10] Convert MSM to common clock framework Stephen Boyd
2012-09-21 2:26 ` [PATCH 01/10] usb: otg: msm: Convert to clk_prepare/unprepare Stephen Boyd
[not found] ` <1348194419-11486-2-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2012-09-26 16:58 ` Pankaj Jangra
2012-09-26 18:48 ` Stephen Boyd
[not found] ` <50634DF9.5010608-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2012-09-26 18:52 ` Pankaj Jangra
2012-09-21 2:26 ` [PATCH 02/10] msm_sdcc: " Stephen Boyd
2012-09-21 2:26 ` [PATCH 03/10] msm: iommu: " Stephen Boyd
2012-09-24 22:32 ` Saravana Kannan
2012-09-25 20:16 ` Stephen Boyd
2012-09-21 2:26 ` [PATCH 04/10] msm: iommu: Use clk_set_rate() instead of clk_set_min_rate() Stephen Boyd
2012-09-21 2:26 ` [PATCH 05/10] ARM: msm: Remove custom clk_set_flags() API Stephen Boyd
2012-09-24 22:33 ` Saravana Kannan
2012-09-21 2:26 ` [PATCH 06/10] ARM: msm: Remove custom clk_set_{max,min}_rate() API Stephen Boyd
2012-09-24 22:37 ` Saravana Kannan
2012-09-21 2:26 ` [PATCH 07/10] ARM: msm: Remove clock-7x30.h include file Stephen Boyd
2012-09-26 17:51 ` Pankaj Jangra [this message]
2012-09-26 18:18 ` Stephen Boyd
2012-09-26 18:54 ` Pankaj Jangra
2012-09-21 2:26 ` [PATCH 08/10] ARM: msm: Prepare clk_get() users in mach-msm for clock-pcom driver Stephen Boyd
2012-09-26 17:35 ` Pankaj Jangra
2012-09-26 18:14 ` Stephen Boyd
2012-09-21 2:26 ` [PATCH 09/10] ARM: msm: Make proc_comm clock control into a platform driver Stephen Boyd
2012-09-26 18:03 ` Pankaj Jangra
2012-09-26 18:36 ` Stephen Boyd
2012-09-21 2:26 ` [PATCH 10/10] ARM: msm: Migrate to common clock framework Stephen Boyd
2012-09-26 18:47 ` Pankaj Jangra
2012-09-26 18:50 ` Stephen Boyd
2012-09-26 18:57 ` Pankaj Jangra
2012-09-22 1:10 ` [PATCH 00/10] Convert MSM " Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADTbHxqrPmnOHqqYyskC32bN269k-_pgk-+czwf7zLCs70ESzA@mail.gmail.com \
--to=jangra.pankaj9@gmail.com \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).