From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA71C433EF for ; Fri, 10 Jun 2022 20:45:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348454AbiFJUpG (ORCPT ); Fri, 10 Jun 2022 16:45:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347886AbiFJUpF (ORCPT ); Fri, 10 Jun 2022 16:45:05 -0400 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22D7139BA0 for ; Fri, 10 Jun 2022 13:45:04 -0700 (PDT) Received: by mail-ot1-x335.google.com with SMTP id 93-20020a9d02e6000000b0060c252ee7a4so57093otl.13 for ; Fri, 10 Jun 2022 13:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc:content-transfer-encoding; bh=JmSm7RdG81p3jLk6y5qdqPkBOS3Ze//O1dXyGVO1Nbg=; b=hx7EhdeCKh6inM6hkWhAKuFdb0vq/lRb382k+PleprdIMQ2uGBzzviUYDM3WQ7YATs RY0827T+hJF7MsDFblzWBgl6zkXdUOV1uN6SYI9ZFGIhQQC12KR9jg2XH7slDyAwWQqd FfdOVfhD2WBsU8VqRmUiwCp+OQnmGKtvGKYN4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc:content-transfer-encoding; bh=JmSm7RdG81p3jLk6y5qdqPkBOS3Ze//O1dXyGVO1Nbg=; b=RSm+NpV0QLysaocwJ5Om+JT5fwAFLUhpzkgFXHVfyIOiylZknI1AaZkgovX2EyUY77 mb5cTEOLizOV32A5CqL97v7nDEknzkv+PFEk8chj+Tqplof3nqs9J5hkzvb9dBUcxJrM Z0Tra7YIq2VrtengAiWDeah9vzMCGIoatbdQYYcrXLz0v5Rsq3O+I+dumlOh2F5QVDFY PWM18+tRBzkaY/ukSrw+ljRicH2+/HDDsKZRLHPyOIXp11qdV8XAbkFTvTUofMc5NQa6 D2CRf/CCSjsG6TJ2xgd0j2rsmv2xidvMWazDgyjJJUE0hceAhKitYCh2cJ0/7vnqJeL5 KIdQ== X-Gm-Message-State: AOAM533NOGwkpyF4PQ/ALU1CWYFqgG1W9Cl7tW9Zy8ILmAt0IcJmk+qA fuV6JvTRBSm3nYzdpuj+9KAA6c5fTg8ItOqUUJ1feA== X-Google-Smtp-Source: ABdhPJyVwgqwzgCOH7YHHYBukvLs7hN/oJj2R+vCwTuhCUpXh/chu/SlAzFUgiXK7m9UfZ68NJT8jD1/SJSmMWm1T78= X-Received: by 2002:a9d:6484:0:b0:60b:eb0b:4054 with SMTP id g4-20020a9d6484000000b0060beb0b4054mr114803otl.159.1654893902756; Fri, 10 Jun 2022 13:45:02 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 10 Jun 2022 13:45:02 -0700 MIME-Version: 1.0 In-Reply-To: References: <1654602615-28849-1-git-send-email-quic_c_skakit@quicinc.com> <1654602615-28849-8-git-send-email-quic_c_skakit@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Fri, 10 Jun 2022 13:45:02 -0700 Message-ID: Subject: Re: [PATCH V14 7/9] regulator: Add a regulator driver for the PM8008 PMIC To: Bjorn Andersson , Rob Herring , Satya Priya Kakitapalli Cc: Lee Jones , Liam Girdwood , Mark Brown , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_collinsd@quicinc.com, quic_subbaram@quicinc.com, quic_jprakash@quicinc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Satya Priya Kakitapalli (Temp) (2022-06-08 22:20:27) > > If I place it here below error is seen > > error: ISO C90 forbids mixing declarations and code > [-Werror,-Wdeclaration-after-statement] > > It could be placed at the beginning=C2=A0 of this function near the > declarations though. I see that many of the drivers add it below the > array itself. > Ah, use BUILD_BUG_ON() then.