From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [patch v2] drm/msm/dsi: free first element on error Date: Thu, 16 Feb 2017 07:16:27 -0500 Message-ID: References: <87a89mnznw.fsf@intel.com> <20170216120028.GA29698@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-yw0-f195.google.com ([209.85.161.195]:35193 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754217AbdBPMQ3 (ORCPT ); Thu, 16 Feb 2017 07:16:29 -0500 In-Reply-To: <20170216120028.GA29698@mwanda> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Dan Carpenter Cc: Archit Taneja , David Airlie , Jani Nikula , Hai Li , Rob Herring , Wei Yongjun , linux-arm-msm , "dri-devel@lists.freedesktop.org" , freedreno@lists.freedesktop.org, kernel-janitors@vger.kernel.org On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter wrote: > We're off by one here. We free something that wasn't allocated and we > don't free msm_host->bus_clks[]. > > Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") > Signed-off-by: Dan Carpenter Thanks Reviewed-by: Rob Clark > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > index 1fc07ce24686..4fa32296162e 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -437,7 +437,7 @@ static int dsi_bus_clk_enable(struct msm_dsi_host *msm_host) > > return 0; > err: > - for (; i > 0; i--) > + while (i--) > clk_disable_unprepare(msm_host->bus_clks[i]); > > return ret;