From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: drm/msm: CONFIG_MSM_OCMEM? Date: Tue, 11 Feb 2014 12:29:49 -0500 Message-ID: References: <1392133181.3755.14.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-ie0-f179.google.com ([209.85.223.179]:64213 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585AbaBKR3u (ORCPT ); Tue, 11 Feb 2014 12:29:50 -0500 In-Reply-To: <1392133181.3755.14.camel@x220> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Paul Bolle Cc: Richard Weinberger , David Airlie , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org On Tue, Feb 11, 2014 at 10:39 AM, Paul Bolle wrote: > Rob, > > Commit 55459968176f ("drm/msm: add a330/apq8x74") added preprocessor > checks for CONFIG_MSM_OCMEM. But I couldn't find a Kconfig symbol > MSM_OCMEM (nor a preprocessor define for a macro of that name). Why were > those preprocessor checks added? At the moment, CONFIG_MSM_OCMEM is only in downstream kernel.. not 100% sure about how we'll handle that upstream when there is more than just drm/msm using OCMEM (which can be shared between gpu, video enc/dec, etc). > Please note that lines 197-201 currently read: > /* Set the OCMEM base address for A330, etc */ > if (a3xx_gpu->ocmem_hdl) { > gpu_write(gpu, REG_A3XX_RB_GMEM_BASE_ADDR, > (unsigned int)(a3xx_gpu->ocmem_base >> 14)); > } > > ocmem_hdl and ocmem_base are used uninitialized here, aren't they? So it > seems these lines should be wrapped with a preprocessor check for > CONFIG_MSM_OCMEM too. in this case ocmem_hdl will be NULL (since a3xx_gpu is kzalloc'd). The #ifdef's could be added here, but not required. BR, -R > > Paul Bolle >