From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH] gpu: drm: msm: Change return type to vm_fault_t Date: Mon, 18 Jun 2018 17:43:50 -0400 Message-ID: References: <20180521172948.GA18605@jordon-HP-15-Notebook-PC> <20180531175902.GC11565@jcrouse-lnx.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Souptick Joarder Cc: David Airlie , linux-arm-msm , Linux Kernel Mailing List , Matthew Wilcox , Jordan Crouse , freedreno List-Id: linux-arm-msm@vger.kernel.org T24gU3VuLCBKdW4gMTcsIDIwMTggYXQgMTE6NDAgUE0sIFNvdXB0aWNrIEpvYXJkZXIgPGpyZHIu bGludXhAZ21haWwuY29tPiB3cm90ZToKPiBPbiBUaHUsIE1heSAzMSwgMjAxOCBhdCAxMToyOSBQ TSwgSm9yZGFuIENyb3VzZSA8amNyb3VzZUBjb2RlYXVyb3JhLm9yZz4gd3JvdGU6Cj4+IE9uIE1v biwgTWF5IDI4LCAyMDE4IGF0IDEyOjM4OjQxUE0gKzA1MzAsIFNvdXB0aWNrIEpvYXJkZXIgd3Jv dGU6Cj4+PiBPbiBNb24sIE1heSAyMSwgMjAxOCBhdCAxMDo1OSBQTSwgU291cHRpY2sgSm9hcmRl ciA8anJkci5saW51eEBnbWFpbC5jb20+IHdyb3RlOgo+Pj4gPiBVc2UgbmV3IHJldHVybiB0eXBl IHZtX2ZhdWx0X3QgZm9yIGZhdWx0IGhhbmRsZXIuIEZvcgo+Pj4gPiBub3csIHRoaXMgaXMganVz dCBkb2N1bWVudGluZyB0aGF0IHRoZSBmdW5jdGlvbiByZXR1cm5zCj4+PiA+IGEgVk1fRkFVTFQg dmFsdWUgcmF0aGVyIHRoYW4gYW4gZXJybm8uIE9uY2UgYWxsIGluc3RhbmNlcwo+Pj4gPiBhcmUg Y29udmVydGVkLCB2bV9mYXVsdF90IHdpbGwgYmVjb21lIGEgZGlzdGluY3QgdHlwZS4KPj4+ID4K Pj4+ID4gUmVmLSBjb21taXQgMWM4ZjQyMjA1OWFlICgibW06IGNoYW5nZSByZXR1cm4gdHlwZSB0 byB2bV9mYXVsdF90IikKPj4+ID4KPj4+ID4gUHJldmlvdXNseSB2bV9pbnNlcnRfbWl4ZWQoKSBy ZXR1cm5zIGVyciB3aGljaCBkcml2ZXIKPj4+ID4gbWFwcGVkIGludG8gVk1fRkFVTFRfKiB0eXBl LiBUaGUgbmV3IGZ1bmN0aW9uCj4+PiA+IHZtZl9pbnNlcnRfbWl4ZWQoKSB3aWxsIHJlcGxhY2Ug dGhpcyBpbmVmZmljaWVuY3kgYnkKPj4+ID4gcmV0dXJuaW5nIFZNX0ZBVUxUXyogdHlwZS4KPj4+ ID4KPj4+ID4gdm1mX2Vycm9yKCkgaXMgdGhlIG5ld2x5IGludHJvZHVjZSBpbmxpbmUgZnVuY3Rp b24KPj4+ID4gaW4gNC4xNy1yYzYuCj4+PiA+Cj4+PiA+IFNpZ25lZC1vZmYtYnk6IFNvdXB0aWNr IEpvYXJkZXIgPGpyZHIubGludXhAZ21haWwuY29tPgo+Pj4gPiBSZXZpZXdlZC1ieTogTWF0dGhl dyBXaWxjb3ggPG1hd2lsY294QG1pY3Jvc29mdC5jb20+Cj4+PiA+IC0tLQo+Pj4gPiAgZHJpdmVy cy9ncHUvZHJtL21zbS9tc21fZHJ2LmggfCAgMyArKy0KPj4+ID4gIGRyaXZlcnMvZ3B1L2RybS9t c20vbXNtX2dlbS5jIHwgMzMgKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+PiA+ ICAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDI0IGRlbGV0aW9ucygtKQo+Pj4g Pgo+Pj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZHJ2LmggYi9kcml2 ZXJzL2dwdS9kcm0vbXNtL21zbV9kcnYuaAo+Pj4gPiBpbmRleCAwYTY1M2RkLi40NGI0Y2E3IDEw MDY0NAo+Pj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9kcnYuaAo+Pj4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9kcnYuaAo+Pj4gPiBAQCAtMzMsNiArMzMsNyBAQAo+ Pj4gPiAgI2luY2x1ZGUgPGxpbnV4L29mX2dyYXBoLmg+Cj4+PiA+ICAjaW5jbHVkZSA8bGludXgv b2ZfZGV2aWNlLmg+Cj4+PiA+ICAjaW5jbHVkZSA8YXNtL3NpemVzLmg+Cj4+PiA+ICsjaW5jbHVk ZSA8bGludXgvbW1fdHlwZXMuaD4KPj4+ID4KPj4+ID4gICNpbmNsdWRlIDxkcm0vZHJtUC5oPgo+ Pj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fYXRvbWljLmg+Cj4+PiA+IEBAIC0xODgsNyArMTg5LDcg QEAgaW50IG1zbV9pb2N0bF9nZW1fc3VibWl0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQg KmRhdGEsCj4+PiA+ICBpbnQgbXNtX2dlbV9tbWFwX29iaihzdHJ1Y3QgZHJtX2dlbV9vYmplY3Qg Km9iaiwKPj4+ID4gICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHZtX2FyZWFfc3RydWN0 ICp2bWEpOwo+Pj4gPiAgaW50IG1zbV9nZW1fbW1hcChzdHJ1Y3QgZmlsZSAqZmlscCwgc3RydWN0 IHZtX2FyZWFfc3RydWN0ICp2bWEpOwo+Pj4gPiAtaW50IG1zbV9nZW1fZmF1bHQoc3RydWN0IHZt X2ZhdWx0ICp2bWYpOwo+Pj4gPiArdm1fZmF1bHRfdCBtc21fZ2VtX2ZhdWx0KHN0cnVjdCB2bV9m YXVsdCAqdm1mKTsKPj4+ID4gIHVpbnQ2NF90IG1zbV9nZW1fbW1hcF9vZmZzZXQoc3RydWN0IGRy bV9nZW1fb2JqZWN0ICpvYmopOwo+Pj4gPiAgaW50IG1zbV9nZW1fZ2V0X2lvdmEoc3RydWN0IGRy bV9nZW1fb2JqZWN0ICpvYmosCj4+PiA+ICAgICAgICAgICAgICAgICBzdHJ1Y3QgbXNtX2dlbV9h ZGRyZXNzX3NwYWNlICphc3BhY2UsIHVpbnQ2NF90ICppb3ZhKTsKPj4+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9tc21f Z2VtLmMKPj4+ID4gaW5kZXggMDczNzZkZS4uMjdhNWFiNSAxMDA2NDQKPj4+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL21zbS9tc21fZ2VtLmMKPj4+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21z bS9tc21fZ2VtLmMKPj4+ID4gQEAgLTIxNyw3ICsyMTcsNyBAQCBpbnQgbXNtX2dlbV9tbWFwKHN0 cnVjdCBmaWxlICpmaWxwLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSkKPj4+ID4gICAgICAg ICByZXR1cm4gbXNtX2dlbV9tbWFwX29iaih2bWEtPnZtX3ByaXZhdGVfZGF0YSwgdm1hKTsKPj4+ ID4gIH0KPj4+ID4KPj4+ID4gLWludCBtc21fZ2VtX2ZhdWx0KHN0cnVjdCB2bV9mYXVsdCAqdm1m KQo+Pj4gPiArdm1fZmF1bHRfdCBtc21fZ2VtX2ZhdWx0KHN0cnVjdCB2bV9mYXVsdCAqdm1mKQo+ Pj4gPiAgewo+Pj4gPiAgICAgICAgIHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hID0gdm1mLT52 bWE7Cj4+PiA+ICAgICAgICAgc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmogPSB2bWEtPnZtX3By aXZhdGVfZGF0YTsKPj4+ID4gQEAgLTIyNSwxNSArMjI1LDE4IEBAIGludCBtc21fZ2VtX2ZhdWx0 KHN0cnVjdCB2bV9mYXVsdCAqdm1mKQo+Pj4gPiAgICAgICAgIHN0cnVjdCBwYWdlICoqcGFnZXM7 Cj4+PiA+ICAgICAgICAgdW5zaWduZWQgbG9uZyBwZm47Cj4+PiA+ICAgICAgICAgcGdvZmZfdCBw Z29mZjsKPj4+ID4gLSAgICAgICBpbnQgcmV0Owo+Pj4gPiArICAgICAgIGludCBlcnI7Cj4+PiA+ ICsgICAgICAgdm1fZmF1bHRfdCByZXQ7Cj4+PiA+Cj4+PiA+ICAgICAgICAgLyoKPj4+ID4gICAg ICAgICAgKiB2bV9vcHMub3Blbi9kcm1fZ2VtX21tYXBfb2JqIGFuZCBjbG9zZSBnZXQgYW5kIHB1 dAo+Pj4gPiAgICAgICAgICAqIGEgcmVmZXJlbmNlIG9uIG9iai4gU28sIHdlIGRvbnQgbmVlZCB0 byBob2xkIG9uZSBoZXJlLgo+Pj4gPiAgICAgICAgICAqLwo+Pj4gPiAtICAgICAgIHJldCA9IG11 dGV4X2xvY2tfaW50ZXJydXB0aWJsZSgmbXNtX29iai0+bG9jayk7Cj4+PiA+IC0gICAgICAgaWYg KHJldCkKPj4+ID4gKyAgICAgICBlcnIgPSBtdXRleF9sb2NrX2ludGVycnVwdGlibGUoJm1zbV9v YmotPmxvY2spOwo+Pj4gPiArICAgICAgIGlmIChlcnIpIHsKPj4+ID4gKyAgICAgICAgICAgICAg IHJldCA9IFZNX0ZBVUxUX05PUEFHRTsKPj4+ID4gICAgICAgICAgICAgICAgIGdvdG8gb3V0Owo+ Pj4gPiArICAgICAgIH0KPj4+ID4KPj4+ID4gICAgICAgICBpZiAoV0FSTl9PTihtc21fb2JqLT5t YWR2ICE9IE1TTV9NQURWX1dJTExORUVEKSkgewo+Pj4gPiAgICAgICAgICAgICAgICAgbXV0ZXhf dW5sb2NrKCZtc21fb2JqLT5sb2NrKTsKPj4+ID4gQEAgLTI0Myw3ICsyNDYsNyBAQCBpbnQgbXNt X2dlbV9mYXVsdChzdHJ1Y3Qgdm1fZmF1bHQgKnZtZikKPj4+ID4gICAgICAgICAvKiBtYWtlIHN1 cmUgd2UgaGF2ZSBwYWdlcyBhdHRhY2hlZCBub3cgKi8KPj4+ID4gICAgICAgICBwYWdlcyA9IGdl dF9wYWdlcyhvYmopOwo+Pj4gPiAgICAgICAgIGlmIChJU19FUlIocGFnZXMpKSB7Cj4+PiA+IC0g ICAgICAgICAgICAgICByZXQgPSBQVFJfRVJSKHBhZ2VzKTsKPj4+ID4gKyAgICAgICAgICAgICAg IHJldCA9IHZtZl9lcnJvcihQVFJfRVJSKHBhZ2VzKSk7Cj4+PiA+ICAgICAgICAgICAgICAgICBn b3RvIG91dF91bmxvY2s7Cj4+PiA+ICAgICAgICAgfQo+Pj4gPgo+Pj4gPiBAQCAtMjU1LDI3ICsy NTgsMTEgQEAgaW50IG1zbV9nZW1fZmF1bHQoc3RydWN0IHZtX2ZhdWx0ICp2bWYpCj4+PiA+ICAg ICAgICAgVkVSQigiSW5zZXJ0aW5nICVwIHBmbiAlbHgsIHBhICVseCIsICh2b2lkICopdm1mLT5h ZGRyZXNzLAo+Pj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBwZm4sIHBmbiA8PCBQQUdFX1NI SUZUKTsKPj4+ID4KPj4+ID4gLSAgICAgICByZXQgPSB2bV9pbnNlcnRfbWl4ZWQodm1hLCB2bWYt PmFkZHJlc3MsIF9fcGZuX3RvX3Bmbl90KHBmbiwgUEZOX0RFVikpOwo+Pj4gPiAtCj4+PiA+ICsg ICAgICAgcmV0ID0gdm1mX2luc2VydF9taXhlZCh2bWEsIHZtZi0+YWRkcmVzcywgX19wZm5fdG9f cGZuX3QocGZuLCBQRk5fREVWKSk7Cj4+PiA+ICBvdXRfdW5sb2NrOgo+Pj4gPiAgICAgICAgIG11 dGV4X3VubG9jaygmbXNtX29iai0+bG9jayk7Cj4+PiA+ICBvdXQ6Cj4+PiA+IC0gICAgICAgc3dp dGNoIChyZXQpIHsKPj4+ID4gLSAgICAgICBjYXNlIC1FQUdBSU46Cj4+PiA+IC0gICAgICAgY2Fz ZSAwOgo+Pj4gPiAtICAgICAgIGNhc2UgLUVSRVNUQVJUU1lTOgo+Pj4gPiAtICAgICAgIGNhc2Ug LUVJTlRSOgo+Pj4gPiAtICAgICAgIGNhc2UgLUVCVVNZOgo+Pj4gPiAtICAgICAgICAgICAgICAg LyoKPj4+ID4gLSAgICAgICAgICAgICAgICAqIEVCVVNZIGlzIG9rOiB0aGlzIGp1c3QgbWVhbnMg dGhhdCBhbm90aGVyIHRocmVhZAo+Pj4gPiAtICAgICAgICAgICAgICAgICogYWxyZWFkeSBkaWQg dGhlIGpvYi4KPj4+ID4gLSAgICAgICAgICAgICAgICAqLwo+Pj4gPiAtICAgICAgICAgICAgICAg cmV0dXJuIFZNX0ZBVUxUX05PUEFHRTsKPj4+ID4gLSAgICAgICBjYXNlIC1FTk9NRU06Cj4+PiA+ IC0gICAgICAgICAgICAgICByZXR1cm4gVk1fRkFVTFRfT09NOwo+Pj4gPiAtICAgICAgIGRlZmF1 bHQ6Cj4+PiA+IC0gICAgICAgICAgICAgICByZXR1cm4gVk1fRkFVTFRfU0lHQlVTOwo+Pj4gPiAt ICAgICAgIH0KPj4+ID4gKyAgICAgICByZXR1cm4gcmV0Owo+Pj4gPiAgfQo+Pj4gPgo+Pj4gPiAg LyoqIGdldCBtbWFwIG9mZnNldCAqLwo+Pj4gPiAtLQo+Pj4gPiAxLjkuMQo+Pj4gPgo+Pj4KPj4+ IEFueSBjb21tZW50IGZvciB0aGlzIHBhdGNoID8KPj4KPj4gU29ycnkgZm9yIHRoZSBkZWxheSwg SSB3YW50ZWQgdG8gZ2V0IGEgY2hhbmNlIHRvIHRlc3QgaXQuIEl0IHNlZW1zIHRvIHBhc3MgdGhl Cj4+IHVzdWFsIHJlZ3Jlc3Npb24gdGVzdHMuIExHVE0uCj4+Cj4KPiBKb3JkYW4sIFRoaXMgcGF0 Y2ggaXMgbm90IG1lcmdlZCBpbiA0LjE4LXJjLTEuCgp0aGlzIHdhcyBvbiBteSBsaXN0IHRvIHB1 bGwgaW50byBtc20tbmV4dCBmb3IgNC4xOSBhcyBzb29uIGFzIEkgaGF2ZSBhCmNoYW5jZSB0byBk byBteSBuZXh0IHJvdW5kIG9mIHB1bGxpbmcgcGF0Y2hlcyBmcm9tIHBhdGNod29yaywgc28gaXQK c2hvdWxkIHNob3cgdXAgaW4gbGludXgtbmV4dCBzaG9ydGx5Li4KCkJSLAotUgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBs aXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8K