From: Loic Poulain <loic.poulain@oss.qualcomm.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Luca Weiss <luca@lucaweiss.eu>
Cc: Robert Foss <rfoss@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] i2c: qcom-cci: Add msm8953 compatible
Date: Fri, 15 Aug 2025 13:22:57 +0200 [thread overview]
Message-ID: <CAFEp6-3pZAt9557us4ihM3-ifrUVkYx+LneuORVafYQGeVyiVA@mail.gmail.com> (raw)
In-Reply-To: <aJ7wWDejA0KDarIE@shikoro>
On Fri, Aug 15, 2025 at 10:31 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Hi Luca,
>
> > I'm also not sure what these parameters depend on, if it's CCI HW version,
> > or
> > something else. So naming it after the SoC should be a safer bet. Also the
> > msm8974-cci was only named 'v1.5' because it's an inbetween mix of the v1
> > and
> > v2 that were already upstream so arguably that one shouldn't have been
> > called
> > v1.5 in the first place either.
That's correct, this is a local version, not matching HW IP version.
The config depends both on the HW version and the CCI core clock.
As our timings are statically configured we should also ensure that
the CCI clock is correct...
> >
> > Let me know what you think. Maybe also someone from Qualcomm/Linaro can jump
> > in and share their thoughts, if someone knows more what these params depend
> > on.
That's fair enough.
Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
next prev parent reply other threads:[~2025-08-15 11:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-10 15:37 [PATCH 0/7] Camera I2C (CCI) enablement on MSM8953 and Fairphone 3 Luca Weiss
2025-08-10 15:37 ` [PATCH 1/7] dt-bindings: i2c: qcom-cci: Document msm8953 compatible Luca Weiss
2025-08-18 15:37 ` Rob Herring
2025-08-18 17:46 ` Luca Weiss
2025-08-10 15:37 ` [PATCH 2/7] i2c: qcom-cci: Add " Luca Weiss
2025-08-11 12:13 ` Wolfram Sang
2025-08-15 7:12 ` Luca Weiss
2025-08-15 8:31 ` Wolfram Sang
2025-08-15 11:22 ` Loic Poulain [this message]
2025-09-04 11:51 ` Konrad Dybcio
2025-08-10 15:37 ` [PATCH 3/7] dt-bindings: eeprom: at24: Add compatible for Belling BL24S64 Luca Weiss
2025-08-18 15:51 ` Rob Herring
2025-08-18 17:45 ` Luca Weiss
2025-08-25 19:51 ` Bartosz Golaszewski
2025-08-10 15:37 ` [PATCH 4/7] arm64: dts: qcom: msm8953: Re-sort tlmm pinctrl states Luca Weiss
2025-08-11 11:26 ` Konrad Dybcio
2025-08-10 15:37 ` [PATCH 5/7] arm64: dts: qcom: msm8953: Add CCI nodes Luca Weiss
2025-08-11 11:26 ` Konrad Dybcio
2025-08-10 15:37 ` [PATCH 6/7] arm64: dts: qcom: sdm632-fairphone-fp3: Add camera fixed regulators Luca Weiss
2025-08-11 11:27 ` Konrad Dybcio
2025-08-10 15:37 ` [PATCH 7/7] arm64: dts: qcom: sdm632-fairphone-fp3: Enable CCI and add EEPROM Luca Weiss
2025-08-11 11:27 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEp6-3pZAt9557us4ihM3-ifrUVkYx+LneuORVafYQGeVyiVA@mail.gmail.com \
--to=loic.poulain@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaweiss.eu \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).