From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Timur Tabi <timur@codeaurora.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Grant Likely <grant.likely@secretlab.ca>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested
Date: Fri, 23 Mar 2018 18:31:05 +0200 [thread overview]
Message-ID: <CAHp75VeTxGu-pxqde_egsqUkLBdZujoJv=0YEj9cv8ujnthyPA@mail.gmail.com> (raw)
In-Reply-To: <152182210780.178046.13284917877743312593@swboyd.mtv.corp.google.com>
On Fri, Mar 23, 2018 at 6:21 PM, Stephen Boyd <swboyd@chromium.org> wrote:
> bitmap_zero(chip->valid_mask, max_gpios);
> for (i = 0; i < len; i++)
> set_bit(tmp[i], chip->valid_mask);
Looking to this code I just realized it would be nice to have
{of,device}_property_read_bitmask() where bitmask_parse() is called.
Since it related to change a binding, I would really take couple of
days to hear other opinions.
In the above case, you need to supply a string, like
"1-5,16,18,25"
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-03-23 16:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 16:58 [PATCH v3 0/3] Support qcom pinctrl protected pins Stephen Boyd
2018-03-21 16:58 ` [PATCH v3 1/3] dt-bindings: gpio: Add a gpio-reserved-ranges property Stephen Boyd
2018-03-21 16:58 ` [PATCH v3 2/3] gpiolib: Support 'gpio-reserved-ranges' property Stephen Boyd
2018-03-21 17:59 ` Andy Shevchenko
2018-03-21 18:02 ` Andy Shevchenko
2018-03-21 19:59 ` Stephen Boyd
2018-03-21 20:31 ` Andy Shevchenko
2018-03-27 13:24 ` Linus Walleij
2018-03-21 16:58 ` [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested Stephen Boyd
2018-03-21 18:07 ` Andy Shevchenko
2018-03-21 20:04 ` Stephen Boyd
2018-03-21 20:30 ` Andy Shevchenko
2018-03-21 20:17 ` Stephen Boyd
2018-03-23 0:16 ` Timur Tabi
2018-03-23 0:23 ` Timur Tabi
2018-03-23 0:59 ` Timur Tabi
2018-03-23 11:34 ` Andy Shevchenko
2018-03-23 14:03 ` Timur Tabi
2018-03-23 11:36 ` Andy Shevchenko
2018-03-23 16:21 ` Stephen Boyd
2018-03-23 16:25 ` Timur Tabi
2018-03-23 16:31 ` Andy Shevchenko [this message]
2018-03-23 16:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeTxGu-pxqde_egsqUkLBdZujoJv=0YEj9cv8ujnthyPA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).