From: Bjorn Andersson <bjorn@kryo.se>
To: Archit Taneja <architt@codeaurora.org>
Cc: Andy Gross <agross@codeaurora.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Rob Clark <robdclark@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5
Date: Sat, 17 Oct 2015 20:19:11 -0700 [thread overview]
Message-ID: <CAJAp7OhSLFHAdg9POwfhFRU2NmYS8Oc-Zpn8-UCdLfpBWepbdw@mail.gmail.com> (raw)
In-Reply-To: <1444997172-9308-1-git-send-email-architt@codeaurora.org>
On Fri, Oct 16, 2015 at 5:06 AM, Archit Taneja <architt@codeaurora.org> wrote:
> MDP5 has a different compatible string (which causes checkpatch warnings
> when we try to add MDP5 device nodes). It also has different list of
> clocks.
>
> Update the bindings for MDP5.
>
> Signed-off-by: Archit Taneja <architt@codeaurora.org>
> ---
> Documentation/devicetree/bindings/drm/msm/mdp.txt | 23 ++++++++++++++++-------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/drm/msm/mdp.txt b/Documentation/devicetree/bindings/drm/msm/mdp.txt
> index 1a0598e..e926daa 100644
> --- a/Documentation/devicetree/bindings/drm/msm/mdp.txt
> +++ b/Documentation/devicetree/bindings/drm/msm/mdp.txt
> @@ -3,18 +3,27 @@ Qualcomm adreno/snapdragon display controller
> Required properties:
> - compatible:
> * "qcom,mdp" - mdp4
> + * "qcom,mdss_mdp" - mdp5
Wouldn't it be better to name these "qcom,mdp4" and "qcom,mdp5" so
that we don't have to rely on some magic detection mechanism to
support future versions?
Regards,
Bjorn
next prev parent reply other threads:[~2015-10-18 3:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 12:06 [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5 Archit Taneja
2015-10-16 12:06 ` [PATCH 2/2] arm64: dtsi: Add device nodes for GPU and MDSS on MSM8916 Archit Taneja
2015-10-18 3:19 ` Bjorn Andersson [this message]
[not found] ` <CAJAp7OhSLFHAdg9POwfhFRU2NmYS8Oc-Zpn8-UCdLfpBWepbdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-19 5:49 ` [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5 Archit Taneja
2015-10-20 18:17 ` Rob Clark
2015-10-23 7:47 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJAp7OhSLFHAdg9POwfhFRU2NmYS8Oc-Zpn8-UCdLfpBWepbdw@mail.gmail.com \
--to=bjorn@kryo.se \
--cc=agross@codeaurora.org \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).