From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43EC926C3BD for ; Thu, 25 Sep 2025 13:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758807305; cv=none; b=hISbFCcG3Kd06b1mCzD9/ABHFzUqoWfXBl7+wbu+yTSAl7wH315tfma0SEx6Ek9etFthJ8CT0uG3C+HnB7BGPyMXXvIXZyZntO/zIaYXWMPFeVL+kBn2gmi7/127q5ozlqpFC1tE5VqNvnmeF5JbG6dp2L9+VyyBLRK9A/ai9sU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758807305; c=relaxed/simple; bh=U0zBqrOVz2aVyIkOdhN/c5ZsuFUDGjUs9oZhG9G8cd8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=eFd+umhzM655nv+vsyxDdIEf8rg1aaS7FuzuHbuFQAUF4Mp/5n8iCm9EGlrlqwYSioB/rIavXhLUt0w160m0Yke1sBLauYY1eAXPde7dx/RVb3xSXrkrmL/xe5PtPFf8uRm35knykAPNZOia+CanDEM+C3H7oqxPUfG8Ma6zvwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JslnrxGq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JslnrxGq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E58E9C4CEF0 for ; Thu, 25 Sep 2025 13:35:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758807304; bh=U0zBqrOVz2aVyIkOdhN/c5ZsuFUDGjUs9oZhG9G8cd8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JslnrxGqC5YDchzPfgAZdyZrZgtviyOLpf4A8RzMq84c78iYViknuF2beVq+xKQcl pt1l/eLOt6ThyA4pwBQXoVYEzzbibKihOg2E7wWv5bYvNICV0+RrwIipzKfDN4nYYB sK3FQISCI+IXTgXSSRkCLj2kdel+ayYwsSTu9XWndFYynTAPselJj4+eyObo6cy/SH ic+uKvU0LfEYoHyZsVSoqnqdzowbL5rW8eyv2iu3Wf6b9CuWtNMYqxiixyhz8SYR+K z0bX/YKVN11y5visySyyoc4v0VAeuqh5ASxbLlFgpBTt+KEpWWahNB5J5z7MBkf9oR VlIaw18Bas/9g== Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-b55197907d1so751019a12.0 for ; Thu, 25 Sep 2025 06:35:04 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXdQQHCJLBTT2r9wb53qEArz904RF/phhfDXabsm+oJUU9Kwg4FYBHDKhNxBfn/fVFvUg19JF8140AyZVI5@vger.kernel.org X-Gm-Message-State: AOJu0YxUWKabI/1Y3KPEyxQSNQBp4bZ4VY/udo2ewEwku9LgH9zyyHFD a4sT2WFSUqTGrdFhwjXNB7Y9/6TdoTnlVOlGyCsUCIqbxCWtr1hUXT8mP7WNHMHNdj5ok9pq2U4 ryQ43ehdd+flUhCIYFJ+j8aF/Xhe5AKQ= X-Google-Smtp-Source: AGHT+IF2gfRSMbhEJa8nvrh+JpQ+A2ctdyaVqt5YxJDoqNHuurr02R6K0ugrO5eiCQDnx8VVAz7RofYZkW98Xl+uAW4= X-Received: by 2002:a17:903:2c9:b0:259:5fdf:d79c with SMTP id d9443c01a7336-27ed4ad65e1mr32294745ad.51.1758807304473; Thu, 25 Sep 2025 06:35:04 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250925-v3_glymur_introduction-v1-0-24b601bbecc0@oss.qualcomm.com> <20250925-v3_glymur_introduction-v1-14-24b601bbecc0@oss.qualcomm.com> In-Reply-To: From: Krzysztof Kozlowski Date: Thu, 25 Sep 2025 22:34:52 +0900 X-Gmail-Original-Message-ID: X-Gm-Features: AS18NWC4qEyHuPYqOFoEoG1CnyL6J8LaE_ysvRuMlpyTnvkn7ftx1v5-lrNiYqU Message-ID: Subject: Re: [PATCH 14/24] arm64: dts: qcom: Update the pmh0110.dtsi for Glymur To: Dmitry Baryshkov Cc: Pankaj Patil , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kamal Wadhwa Content-Type: text/plain; charset="UTF-8" On Thu, 25 Sept 2025 at 22:14, Dmitry Baryshkov wrote: > > On Thu, Sep 25, 2025 at 05:08:54PM +0900, Krzysztof Kozlowski wrote: > > On Thu, 25 Sept 2025 at 15:34, Pankaj Patil > > wrote: > > > > > > From: Kamal Wadhwa > > > > > > Add multiple instance of PMH0110 DT node, one for each assigned > > > SID for this PMIC on the spmi_bus0 and spmi_bus1 on the Glymur > > > CRD. > > > > > > Take care to avoid compilation issue with the existing nodes by > > > gaurding each PMH0110 nodes with `#ifdef` for its corresponding > > > SID macro. So that only the nodes which have the their SID macro > > > defined are the only ones picked for compilation. > > > > > > Signed-off-by: Kamal Wadhwa > > > Signed-off-by: Pankaj Patil > > > --- > > > arch/arm64/boot/dts/qcom/pmh0110.dtsi | 66 ++++++++++++++++++++++++++++++++++- > > > 1 file changed, 65 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/pmh0110.dtsi b/arch/arm64/boot/dts/qcom/pmh0110.dtsi > > > index b99c33cba8860f1852231db33a127646c08c1e23..4a5c66e5c9fbc35cedb67601f4568844dc41fbea 100644 > > > --- a/arch/arm64/boot/dts/qcom/pmh0110.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/pmh0110.dtsi > > > @@ -7,6 +7,8 @@ > > > #include > > > > > > &spmi_bus0 { > > > + > > > +#ifdef PMH0110_D_E0_SID > > > > NAK > > > > I already explained on IRC in great details why. > > A short summary or a link to a channel / date would be nice in order to > include other people into the discussion. > Of course but: 1. You were there so maybe you remember the arguments, and: 2. I'm offline, using phone, not having laptop, replying during my personal time off just before merge window so any emergency time should be spent on important matters instead these two huge patch bombs adding such usage I already said: NO, don't do this.