From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Turquette, Mike" Subject: Re: [PATCH] clk: Constify struct clk_init_data Date: Mon, 14 May 2012 22:59:41 -0700 Message-ID: References: <1337004763-21250-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20120514215304.GB3075@gmail.com> <4FB1AC79.7000901@codeaurora.org> <4FB1E5F6.7070401@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from na3sys009aob106.obsmtp.com ([74.125.149.76]:52562 "EHLO na3sys009aog106.obsmtp.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753774Ab2EOGAF (ORCPT ); Tue, 15 May 2012 02:00:05 -0400 Received: by bkcjk13 with SMTP id jk13so5092009bkc.26 for ; Mon, 14 May 2012 23:00:02 -0700 (PDT) In-Reply-To: <4FB1E5F6.7070401@ti.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Rajendra Nayak Cc: Saravana Kannan , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sascha Hauer , andrew@lunn.ch, "linux-arm-msm@vger.kernel.org" On Mon, May 14, 2012 at 10:13 PM, Rajendra Nayak wrote: > Hi Saravana, > > > On Tuesday 15 May 2012 06:38 AM, Saravana Kannan wrote: >> >> Btw, I didn't follow up on the other thread we were having, but can you >> remind me again what was the reason that you thought that only >> __clk_init() would work for your static init code and __clk_register() >> won't work? > > > One of the main reason has been the platform implementation we have to > handle some complex mux/divider combo clocks in OMAP2/3 which rely on > 'struct clk' pointers. Maybe we can do away with the existing > implementation and redo it so we don't have any such limitation, but the > quantum of change moving to common clk has been so much that we are > trying to minimize on the platform code changes for now. So while > we move to common clk it would still be useful to have __clk_init() > around for a while till we figure out how to get rid of it for OMAP. > Just to add to what Rajendra has stated for OMAP: after OMAP's conversion is finally made initcall-able then I'll get rid of lots of the gross macros and before-the-memory-allocator-is-alive stuff. I'll make sure that no other platforms are using those bits of course, but I plan on removing some of this stuff from the core once my platform is up to speed. Regards, Mike > regards, > Rajendra