From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v4 2/3] dt-bindings: power: supply: qcom_bms: Add bindings Date: Wed, 18 Apr 2018 16:16:46 -0500 Message-ID: References: <20180407135934.26122-1-ctatlor97@gmail.com> <20180407175802.29444-1-ctatlor97@gmail.com> <20180407175802.29444-2-ctatlor97@gmail.com> <20180413163527.ludqnnc5nkj4spre@rob-hp-laptop> <20180415125528.GA15803@arch.home> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180415125528.GA15803@arch.home> Sender: linux-kernel-owner@vger.kernel.org To: Craig Tatlor Cc: linux-arm-msm , Sebastian Reichel , Mark Rutland , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Linus Walleij , Andrew Morton , Randy Dunlap , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" List-Id: linux-arm-msm@vger.kernel.org On Sun, Apr 15, 2018 at 7:55 AM, Craig Tatlor wrote: > On Fri, Apr 13, 2018 at 11:35:27AM -0500, Rob Herring wrote: >> On Sat, Apr 07, 2018 at 06:57:45PM +0100, Craig Tatlor wrote: >> > Add bindings for the Qualcomm Battery Monitoring system. >> > >> > Signed-off-by: Craig Tatlor >> > --- >> > .../bindings/power/supply/qcom_bms.txt | 93 +++++++++++++++++++ >> > 1 file changed, 93 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/power/supply/qcom_bms.txt >> > >> > diff --git a/Documentation/devicetree/bindings/power/supply/qcom_bms.txt b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt >> > new file mode 100644 >> > index 000000000000..6296399edc09 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt >> > @@ -0,0 +1,93 @@ >> > +Qualcomm Battery Measurement System >> > + >> > +The Qualcomm Battery Measurement System is found inside of Qualcomm PM8941 >> >> Is it Monitoring or Measurment? >> >> > +PMICs. It provides OCV and coulomb counter registers that allow the kernel >> > +to infer a capacity level. >> >> s/kernel/OS/ >> >> OCV? >> >> > + >> > +Required properties: >> > +- compatible: Should contain "qcom,pm8941-bms". >> > +- reg: Specifies the SPMI address and length of the >> > + controller's registers. >> > +- interrupts: OCV threshold interrupt. >> > +- io-channels: Should contain IIO channel specifier for the >> > + ADC channel that reports battery temperature. >> > +- io-channel-names: Should contain "temp". >> > +- qcom,fcc-temp-legend: An array containing the temperature, in degC, >> > + for each column of the FCC lookup table. >> >> What's FCC? >> >> > +- qcom,fcc-lut: An array of FCC values in mah, one entry for each >> > + temperature defined in in qcom,fcc-temp-legend. >> > +- qcom,ocv-temp-legend: An array containing the temperature, in degC, >> > + for each column of the OCV lookup table. >> > +- qcom,ocv-capacity-legend: An array containing the capacity for each >> > + row of the OCV lookup table. >> > +- qcom,ocv-lut: An array of OCV values in mV, one entry for each >> > + capacity defined in qcom,ocv-capacity-legend. >> >> Need to specify the sizes of these if not 32-bit. >> >> All these seem to have units, so add unit suffixes as defined in >> property-units.txt. > Should i change code to use microamphours & microvolts or add a new > suffix? It is preferred to use the existing ones unless you have some justification to add new ones. Rob