From: Rob Herring <robherring2@gmail.com>
To: Yaniv Gardi <ygardi@codeaurora.org>
Cc: Jej B <James.Bottomley@hansenpartnership.com>,
Paul Bolle <pebolle@tiscali.nl>,
hch@infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Santosh Y <santoshsy@gmail.com>,
linux-scsi-owner@vger.kernel.org,
Subhash Jadavani <subhashj@codeaurora.org>,
Gilad Broner <gbroner@codeaurora.org>,
Dolev Raviv <draviv@codeaurora.org>,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <JBottomley@odin.com>
Subject: Re: [PATCH v7 2/8] scsi: ufs-qcom: fix compilation warning if compiled as a module
Date: Wed, 2 Sep 2015 15:28:56 -0500 [thread overview]
Message-ID: <CAL_JsqKcPD9Kg4DOctPA9vYYHMd6+K_jQR339iiB+rth=HdP_A@mail.gmail.com> (raw)
In-Reply-To: <1441205138-12664-3-git-send-email-ygardi@codeaurora.org>
On Wed, Sep 2, 2015 at 9:45 AM, Yaniv Gardi <ygardi@codeaurora.org> wrote:
> This change fixes a compilation warning that happens if SCSI_UFS_QCOM
> is compiled as a module.
> Also this patch fixes an error happens when insmod the module:
> "ufs_qcom: module license 'unspecified' taints kernel."
>
> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
>
> ---
> drivers/scsi/ufs/ufs-qcom.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index 4cdffa4..6c23bbf 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -917,12 +917,15 @@ out:
>
> #define ANDROID_BOOT_DEV_MAX 30
> static char android_boot_dev[ANDROID_BOOT_DEV_MAX];
> -static int get_android_boot_dev(char *str)
What is this Android crap doing in a driver to begin with?
Rob
next prev parent reply other threads:[~2015-09-02 20:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 14:45 [PATCH v7 0/8] Fix error message and present UFS variant Yaniv Gardi
2015-09-02 14:45 ` [PATCH v7 1/8] phy: qcom-ufs: fix build error when the component is built as a module Yaniv Gardi
2015-10-22 6:45 ` subhashj
2015-09-02 14:45 ` [PATCH v7 2/8] scsi: ufs-qcom: fix compilation warning if compiled " Yaniv Gardi
2015-09-02 20:28 ` Rob Herring [this message]
2015-10-22 6:53 ` subhashj
2015-09-02 14:45 ` [PATCH v7 3/8] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component Yaniv Gardi
2015-10-22 6:56 ` subhashj
2015-09-02 14:45 ` [PATCH v7 4/8] add ufshcd_get_variant ufshcd_set_variant Yaniv Gardi
2015-10-22 6:57 ` subhashj
2015-09-02 14:45 ` [PATCH v7 5/8] scsi: ufs: creates wrapper functions for vops Yaniv Gardi
2015-10-22 6:54 ` subhashj
2015-09-02 14:45 ` [PATCH v7 6/8] scsi: ufs: make the UFS variant a platform device Yaniv Gardi
[not found] ` <1441205138-12664-7-git-send-email-ygardi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-09-02 20:33 ` Rob Herring
2015-10-22 7:02 ` subhashj
2015-10-22 7:50 ` Arnd Bergmann
2015-10-25 10:50 ` ygardi
2015-09-02 14:45 ` [PATCH v7 7/8] scsi: ufs-qcom: add debug prints for test bus Yaniv Gardi
2015-10-22 7:03 ` subhashj
2015-09-02 14:45 ` [PATCH v7 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations Yaniv Gardi
2015-10-22 7:05 ` subhashj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKcPD9Kg4DOctPA9vYYHMd6+K_jQR339iiB+rth=HdP_A@mail.gmail.com' \
--to=robherring2@gmail.com \
--cc=JBottomley@odin.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=draviv@codeaurora.org \
--cc=gbroner@codeaurora.org \
--cc=hch@infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=santoshsy@gmail.com \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).