From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pramod Gurav Subject: Re: [PATCH] tty: serial: msm: Remove duplicate handling of clocks Date: Thu, 12 May 2016 10:08:59 +0530 Message-ID: References: <1462957229-17567-1-git-send-email-pramod.gurav@linaro.org> <20160512001837.GJ3492@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-yw0-f180.google.com ([209.85.161.180]:36769 "EHLO mail-yw0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751761AbcELEjA (ORCPT ); Thu, 12 May 2016 00:39:00 -0400 Received: by mail-yw0-f180.google.com with SMTP id o66so70691927ywc.3 for ; Wed, 11 May 2016 21:38:59 -0700 (PDT) In-Reply-To: <20160512001837.GJ3492@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Andy Gross , gregkh@linuxfoundation.org, David Brown , jslaby@suse.com, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org On 12 May 2016 at 05:48, Stephen Boyd wrote: > On 05/11, Pramod Gurav wrote: >> msm_serial driver provides a .pm callback to the serial core to enable >> and disable clock resource in suspend/resume path. This function is >> also called before msm_startup. msm_startup also enables the clocks which >> is not needed. Hence remove the duplcate clock operation from msm_startup >> and msm_shutdown. Same is done in console setup to get rid of duplicate >> clock operation. > > I had to check and I see that for the console case we call the > .pm callback and don't turn it off until suspend/resume paths > (would be nice to add suspend/resume to this driver too). I > guess that's what you meant by this last sentence? > Yes the clocks would be kept ON if its console. I am working to add suspend/resume and runtime pm as it will not happen by default through core. >> >> Tested on DB410C console. >> >> Signed-off-by: Pramod Gurav > > Reviewed-by: Stephen Boyd > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project