From: Timur Tabi <timur@codeaurora.org>
To: Austin Christ <austinwc@codeaurora.org>
Cc: wsa@the-dreams.de, linux-i2c@vger.kernel.org,
linux-arm-msm@vger.kernel.org, Sinan Kaya <okaya@codeaurora.org>
Subject: Re: [PATCH] i2c-qup: reduce verbosity on DMA channel not found messages
Date: Wed, 31 Jan 2018 10:54:59 -0600 [thread overview]
Message-ID: <CAOZdJXVKZfzXgAYtbr4j9EfcCDPx7io_LNw08aiCyYX9ZALdMQ@mail.gmail.com> (raw)
In-Reply-To: <1516138534-30842-2-git-send-email-austinwc@codeaurora.org>
On Tue, Jan 16, 2018 at 3:35 PM, Austin Christ <austinwc@codeaurora.org> wrote:
> From: Sinan Kaya <okaya@codeaurora.org>
>
> QDF2400 product doesn't have any BAM DMA attached to the I2C channel. This
> causes code to spit an unnecessary error message during boot.
If that's the case, then qup->is_dma should be false, and then this
code should never be executed.
Wouldn't it be better if qup_i2c_probe() is modified to detect a
QDF2400 and not even try to enable DMA? There's already code like
that for device tree:
if (of_device_is_compatible(pdev->dev.of_node, "qcom,i2c-qup-v1.1.1")) {
qup->adap.algo = &qup_i2c_algo;
qup->adap.quirks = &qup_i2c_quirks;
else
...
qup->adap.algo = &qup_i2c_algo_v2;
ret = qup_i2c_req_dma(qup);
On QDF2400, you should never be calling qup_i2c_req_dma() in the first place.
next prev parent reply other threads:[~2018-01-31 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 21:35 [PATCH] i2c: qup: Add shutdown method Austin Christ
2018-01-16 21:35 ` [PATCH] i2c-qup: reduce verbosity on DMA channel not found messages Austin Christ
2018-01-31 16:54 ` Timur Tabi [this message]
2018-02-02 23:36 ` [PATCH] i2c: qup: Add shutdown method Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOZdJXVKZfzXgAYtbr4j9EfcCDPx7io_LNw08aiCyYX9ZALdMQ@mail.gmail.com \
--to=timur@codeaurora.org \
--cc=austinwc@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).