From: Ulf Hansson <ulf.hansson@linaro.org>
To: Subhash Jadavani <subhashj@codeaurora.org>
Cc: linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v1 3/3] mmc: sdio: print correct UHS mode during card detection
Date: Thu, 6 Dec 2012 11:41:59 +0100 [thread overview]
Message-ID: <CAPDyKFqAkL+N3Zz2Lo7hj92QZoVJVn+UhbCSpqZLtSVG-eN3=Q@mail.gmail.com> (raw)
In-Reply-To: <1354620980-23764-4-git-send-email-subhashj@codeaurora.org>
On 4 December 2012 12:36, Subhash Jadavani <subhashj@codeaurora.org> wrote:
> When SDIO3.0 card is detected, incorrect bus speed mode
> is printed as part of card detection print in kernel logs.
>
> This change fixes it so that user won't be confused by
> looking at incorrect card detection message in logs.
>
> Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
> ---
> drivers/mmc/core/sdio.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
> index 9565d38..3a64933 100644
> --- a/drivers/mmc/core/sdio.c
> +++ b/drivers/mmc/core/sdio.c
> @@ -485,23 +485,27 @@ static int sdio_set_bus_speed_mode(struct mmc_card *card)
> bus_speed = SDIO_SPEED_SDR104;
> timing = MMC_TIMING_UHS_SDR104;
> card->sw_caps.uhs_max_dtr = UHS_SDR104_MAX_DTR;
> + card->sd_bus_speed = UHS_SDR104_BUS_SPEED;
> } else if ((card->host->caps & MMC_CAP_UHS_DDR50) &&
> (card->sw_caps.sd3_bus_mode & SD_MODE_UHS_DDR50)) {
> bus_speed = SDIO_SPEED_DDR50;
> timing = MMC_TIMING_UHS_DDR50;
> card->sw_caps.uhs_max_dtr = UHS_DDR50_MAX_DTR;
> + card->sd_bus_speed = UHS_DDR50_BUS_SPEED;
> } else if ((card->host->caps & (MMC_CAP_UHS_SDR104 |
> MMC_CAP_UHS_SDR50)) && (card->sw_caps.sd3_bus_mode &
> SD_MODE_UHS_SDR50)) {
> bus_speed = SDIO_SPEED_SDR50;
> timing = MMC_TIMING_UHS_SDR50;
> card->sw_caps.uhs_max_dtr = UHS_SDR50_MAX_DTR;
> + card->sd_bus_speed = UHS_SDR50_BUS_SPEED;
> } else if ((card->host->caps & (MMC_CAP_UHS_SDR104 |
> MMC_CAP_UHS_SDR50 | MMC_CAP_UHS_SDR25)) &&
> (card->sw_caps.sd3_bus_mode & SD_MODE_UHS_SDR25)) {
> bus_speed = SDIO_SPEED_SDR25;
> timing = MMC_TIMING_UHS_SDR25;
> card->sw_caps.uhs_max_dtr = UHS_SDR25_MAX_DTR;
> + card->sd_bus_speed = UHS_SDR25_BUS_SPEED;
> } else if ((card->host->caps & (MMC_CAP_UHS_SDR104 |
> MMC_CAP_UHS_SDR50 | MMC_CAP_UHS_SDR25 |
> MMC_CAP_UHS_SDR12)) && (card->sw_caps.sd3_bus_mode &
> @@ -509,6 +513,7 @@ static int sdio_set_bus_speed_mode(struct mmc_card *card)
> bus_speed = SDIO_SPEED_SDR12;
> timing = MMC_TIMING_UHS_SDR12;
> card->sw_caps.uhs_max_dtr = UHS_SDR12_MAX_DTR;
> + card->sd_bus_speed = UHS_SDR12_BUS_SPEED;
> }
>
> err = mmc_io_rw_direct(card, 0, 0, SDIO_CCCR_SPEED, 0, &speed);
> --
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
next prev parent reply other threads:[~2012-12-06 10:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 11:36 [PATCH v1 0/3] SDIO fixes Subhash Jadavani
2012-12-04 11:36 ` [PATCH v1 1/3] mmc: sdio: fix resume failure Subhash Jadavani
2012-12-06 10:33 ` Ulf Hansson
2012-12-06 15:25 ` Subhash Jadavani
2012-12-06 22:10 ` Ulf Hansson
2012-12-07 12:15 ` Subhash Jadavani
2012-12-07 14:51 ` Ulf Hansson
2012-12-08 5:55 ` Subhash Jadavani
2012-12-10 12:55 ` Ulf Hansson
2012-12-04 11:36 ` [PATCH v1 2/3] mmc: sdio: Fix SDIO 3.0 UHS-I initialization sequence Subhash Jadavani
2012-12-04 21:14 ` Bing Zhao
2012-12-05 5:17 ` Shen, Jackey
2012-12-05 19:13 ` Bing Zhao
2012-12-06 3:21 ` Shen, Jackey
2012-12-06 3:33 ` Bing Zhao
2012-12-06 6:22 ` Subhash Jadavani
2012-12-06 18:48 ` Bing Zhao
2012-12-07 8:42 ` Johan Rudholm
2012-12-07 9:57 ` Ulf Hansson
2012-12-04 11:36 ` [PATCH v1 3/3] mmc: sdio: print correct UHS mode during card detection Subhash Jadavani
2012-12-06 10:41 ` Ulf Hansson [this message]
2012-12-26 4:59 ` Shen, Jackey
[not found] ` <50C7271D.2080704@codeaurora.org>
[not found] ` <86988B169C1CD04598F5B80198CCE50E738D93@aphydexd01b>
2012-12-11 12:41 ` FW: [PATCH v1 0/3] SDIO fixes Subhash Jadavani
2013-01-14 19:07 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFqAkL+N3Zz2Lo7hj92QZoVJVn+UhbCSpqZLtSVG-eN3=Q@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=subhashj@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).