From: Daniel Stone <daniel@fooishbar.org>
To: Archit Taneja <architt@codeaurora.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-msm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jon Medhurst <tixy@linaro.org>
Subject: Re: [RFC] component: Fix: Unassign components' masters if bringing up master fails
Date: Mon, 15 Feb 2016 16:36:02 +0000 [thread overview]
Message-ID: <CAPj87rNjXim0xRoGFYqdEhzH7f-Gd7+=SmfBE9LmqW+DPdn15w@mail.gmail.com> (raw)
In-Reply-To: <1455183351-22823-1-git-send-email-architt@codeaurora.org>
Hi Archit,
On 11 February 2016 at 09:35, Archit Taneja <architt@codeaurora.org> wrote:
> component_master_add_with_match can fail if the master's bind op doesn't
> go through successfully. In such a scenario, all the components in the
> master's match array have their 'master' pointer set to the given master.
> These pointers need to be set to NULL again. If they aren't, successive
> calls to component_master_add_with_match will fail because the driver
> thinks these components already have a master.
>
> This issue can be seen when a driver defers probe because of missing
> resources. It is seen after the introduction of commit:
>
> "component: track components via array rather than list"
>
> Add 'master_remove_components' which sets the all the components's masters
> in the match array to NULL. This function is also re-used in
> component_master_del and replaces code that did the same thing.
Jon already fixed this (in a slightly more limited way perhaps?) in 57480484f9.
Cheers,
Daniel
next prev parent reply other threads:[~2016-02-15 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 9:35 [RFC] component: Fix: Unassign components' masters if bringing up master fails Archit Taneja
2016-02-15 16:36 ` Daniel Stone [this message]
2016-02-15 19:32 ` Jon Medhurst (Tixy)
2016-02-15 23:01 ` Russell King - ARM Linux
2016-02-16 7:16 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPj87rNjXim0xRoGFYqdEhzH7f-Gd7+=SmfBE9LmqW+DPdn15w@mail.gmail.com' \
--to=daniel@fooishbar.org \
--cc=architt@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tixy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).