From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07AD8C433F5 for ; Sat, 19 Mar 2022 18:29:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243901AbiCSSbP (ORCPT ); Sat, 19 Mar 2022 14:31:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233591AbiCSSbO (ORCPT ); Sat, 19 Mar 2022 14:31:14 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FD8337032 for ; Sat, 19 Mar 2022 11:29:53 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id a17so12655880edm.9 for ; Sat, 19 Mar 2022 11:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=mime-version:content-transfer-encoding:date:message-id:from:to:cc :subject:references:in-reply-to; bh=buKp/c8UvzHPIAhRI7uXCYLONDKNZjnQ6ELqJjK7HuA=; b=k4nyBk88e6efJTjIm7EZ0GLZbtg/Onpo4+WFLft/j94NiAxeTzmwE1iruDGx6+mmCu JtsjzOM8sWpaaJwTpwuYUA/xsDqSTBMmdF7C8CS3/eKWOoAUUCZd1dKlQuyNXjg2vUfd GNjZXrz6e7ZxGQ9zOG75KLBqN3VfW0iOcHkUGnUot++W+3cG1nbub/zBeoC+bSuIT2is qhifnXLc+GXdQfGaF5B0iG4YoNynLZGIwRVXiYtZHRHH8pY/T01JyBbyS2+pIwHZEWVs E1tJWHzopRgkTTwym4ZYzNGyW8Q7eSf4wp4fDzHZM/cQLbXlAwDIpXp1gJxuH2TDbXMQ GnhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:content-transfer-encoding:date :message-id:from:to:cc:subject:references:in-reply-to; bh=buKp/c8UvzHPIAhRI7uXCYLONDKNZjnQ6ELqJjK7HuA=; b=6T2NDUMvUEj2o9N7gvTs1/Q00IqHu0muNEjr5JZtYI7I82NgKPvYRtOwke+f8+QAnP IZvNvRZfJScW2k+oUo279A7mtqamDQRtRjVcjNsIxEh2MG3cLz15RE4l9ur/8NJqT6+8 tL9jn+WdzMS+qHrCvG/wdQaorXgzm4/85r6ysuaBRC0kXccxdjXCtQCgT012BKFUZvrm l/h9DZG1cUoDoBdydDfkbUTtpOsPk2WIGtLj3dgHzRI5nN9aLwAVyI0BbiglPylwWgMk F/pmuwb72Kk7XcR3fme/nFFVZhCYwNsxr7Wtud7F/7cGnT9c4Zjaj3nSuqo37jkh+HT0 IBIA== X-Gm-Message-State: AOAM533+gkjZufiy9RFY17a6k7UlyipSfgBnGKgA/GvoP2Rs9jRbadue UajjPV6rxgyPk+2v9l7TgpihNg== X-Google-Smtp-Source: ABdhPJwjUdqRL9meDgsEI/c6J8JDxqnmewgyL9kvXOXz29w8UM8JNz+OMI2GClNroTMk12KuO2svAQ== X-Received: by 2002:a05:6402:289d:b0:419:437:ef4f with SMTP id eg29-20020a056402289d00b004190437ef4fmr11131838edb.110.1647714591776; Sat, 19 Mar 2022 11:29:51 -0700 (PDT) Received: from localhost (a246182.upc-a.chello.nl. [62.163.246.182]) by smtp.gmail.com with ESMTPSA id hg8-20020a1709072cc800b006d6e469fbf0sm5008422ejc.134.2022.03.19.11.29.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Mar 2022 11:29:51 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 19 Mar 2022 19:29:50 +0100 Message-Id: From: "Luca Weiss" To: "Krzysztof Kozlowski" , Cc: <~postmarketos/upstreaming@lists.sr.ht>, , "Andy Gross" , "Bjorn Andersson" , "Rob Herring" , "Krzysztof Kozlowski" , , Subject: Re: [PATCH 5/6] arm64: dts: qcom: sm6350: Add UFS nodes References: <20220318183004.858707-1-luca.weiss@fairphone.com> <20220318183004.858707-6-luca.weiss@fairphone.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Krzysztof, On Sat Mar 19, 2022 at 3:43 PM CET, Krzysztof Kozlowski wrote: > On 18/03/2022 19:30, Luca Weiss wrote: > > Add the necessary nodes for UFS and its PHY. > >=20 > > Signed-off-by: Luca Weiss > > --- > > arch/arm64/boot/dts/qcom/sm6350.dtsi | 79 ++++++++++++++++++++++++++++ > > 1 file changed, 79 insertions(+) > >=20 > > diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts= /qcom/sm6350.dtsi > > index d7c9edff19f7..c5c93b6bcd2a 100644 > > --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi > > @@ -541,6 +541,85 @@ uart2: serial@98c000 { > > }; > > }; > > =20 > > + ufs_mem_hc: ufshc@1d84000 { > > Generic node name, so ufs. With the node name changes UFS doesn't probe anymore. [ 1.893762] ufshcd-qcom 1d84000.ufs: ufshcd_variant_hba_init: variant qc= om init failed err -19 [ 1.902674] ufshcd-qcom 1d84000.ufs: Initialization failed [ 1.908391] ufshcd-qcom 1d84000.ufs: ufshcd_pltfrm_init() failed -19 I didn't debug this in detail but it's likely from the androidboot.bootdevice=3D1d84000.ufshc parameter in cmdline that ufs-qcom.c uses to fail probe with -ENODEV for all UFS other than the selected one. Not sure why this behavior exists in mainline (didn't look into this either). This cmdline parameter (among many others) is added by the stock bootloader and as far as I know there's no way to turn that off. > > > + compatible =3D "qcom,sm6350-ufshc", "qcom,ufshc", > > + "jedec,ufs-2.0"; > > + reg =3D <0 0x01d84000 0 0x3000>, > > + <0 0x01d90000 0 0x8000>; > > + reg-names =3D "std", "ice"; > > + interrupts =3D ; > > + phys =3D <&ufs_mem_phy_lanes>; > > + phy-names =3D "ufsphy"; > > + lanes-per-direction =3D <2>; > > + #reset-cells =3D <1>; > > + resets =3D <&gcc GCC_UFS_PHY_BCR>; > > + reset-names =3D "rst"; > > + > > + power-domains =3D <&gcc UFS_PHY_GDSC>; > > + > > + iommus =3D <&apps_smmu 0x80 0x0>; > > + > > + clock-names =3D > > Drop unneeded blank line, start just after '=3D' and align next elements > with it. Sure. > > > + "core_clk", > > + "bus_aggr_clk", > > + "iface_clk", > > + "core_clk_unipro", > > + "core_clk_ice", > > + "ref_clk", > > + "tx_lane0_sync_clk", > > + "rx_lane0_sync_clk", > > + "rx_lane1_sync_clk"; > > + clocks =3D > > The same. Sure. I also adjusted the clock name/order to match the bindings (thanks for spotting the problems there!) Regards Luca > > > Best regards, > Krzysztof