From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48AA8ECAAA1 for ; Mon, 31 Oct 2022 13:56:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230327AbiJaN44 (ORCPT ); Mon, 31 Oct 2022 09:56:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231318AbiJaN4z (ORCPT ); Mon, 31 Oct 2022 09:56:55 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4085F2C4 for ; Mon, 31 Oct 2022 06:56:54 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id r14so17562513edc.7 for ; Mon, 31 Oct 2022 06:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZcCKYUH9Lbw/pHPSk6/2WqMZQyQUMyuhsXpUiDfOF6A=; b=MHShAiwKTrTKgezu8b/h1HoWiKmRbMo2Se7Cqp0JBdChjeixK+L0le1H3GXkvigB+s tl1nb+Pnb1oJjdpb/LjPiD9TJUKR7TUUPFUHxlwjWN1j2ruklEG3lDaWN19Q5V7o8i2Q 9ae1VwZkDTRFRsksktZlCLJ7ukCegJxsj2IP1C3+23KdkS872MiAqMHYUaA0Y8tj5X4m pZxEweYicWfz1f3HCYMGqWP4u+oouDxlrGb0/RU3S8kFR02V3F6lk405m4PmD4WUR2LO CsbLxLDBTKjBBFeQBWhgZz7hrFJuiMpeZOa+wHqM5IfSZLG4v481jSWye7Gm9kURvhmJ Gl3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ZcCKYUH9Lbw/pHPSk6/2WqMZQyQUMyuhsXpUiDfOF6A=; b=v4N0hc7xC4UtD5at1Mn75fI3cUAqHqUXFoJ9SPhmEyzhwkwH8eOArkTRvY3ceQnV+T 3UYYVK4XcNgWs4QENkwqMfkzUoWHS2MbFguy2nce7H/7rDxe6918+rxhf9JqNWhlWsmJ 1sVltXfxAXFG1FeAkAR86rat8Nlt43Qrp4mFMjaLAwXFSOI/cu9NJJa1dfMdtrpmmHYX prByXdeK93Z3+2H08FwYtpP7dkA7Q2Z3I9eciTVet3zB+5+XKppAL57pcE3iLZWC1jKB EtQfarHzraotPSoltC7FlXz8/ha+kX0ZW793GNnFRJg37uORE38ZokiYWkH1iZd3f3xW aVJQ== X-Gm-Message-State: ACrzQf3AGBnNO2DQtBWfSUbfeSqvsLYeDvhSVx7wDWzAXBiWtKwr+Utl Pi2qnRotNm+gagZmK1uDRIOif7J5CgeGgA== X-Google-Smtp-Source: AMsMyM6u3JAX6R+7QqE3QY18S43gVSOpaUsIoIZwvU1h8v4fcdHEBIhKdyE7CRGMaOBEy+diJLl18Q== X-Received: by 2002:a50:ec99:0:b0:462:2c1c:8764 with SMTP id e25-20020a50ec99000000b004622c1c8764mr13656055edr.325.1667224612782; Mon, 31 Oct 2022 06:56:52 -0700 (PDT) Received: from localhost (31-151-115-246.dynamic.upc.nl. [31.151.115.246]) by smtp.gmail.com with ESMTPSA id t31-20020a056402241f00b00459cd13fd34sm3214246eda.85.2022.10.31.06.56.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 06:56:52 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 31 Oct 2022 14:56:50 +0100 Message-Id: Cc: , , "Dylan Van Assche" Subject: Re: [PATCH v4 1/2] leds: flash: add driver to support flash LED module in QCOM PMICs From: "Luca Weiss" To: "Fenglin Wu" , , , , "Pavel Machek" , "Gene Chen" , "Jacek Anaszewski" , X-Mailer: aerc 0.12.0 References: <20221025073802.2662564-1-quic_fenglinw@quicinc.com> <20221025073802.2662564-2-quic_fenglinw@quicinc.com> In-Reply-To: <20221025073802.2662564-2-quic_fenglinw@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Fenglin, On Tue Oct 25, 2022 at 9:38 AM CEST, Fenglin Wu wrote: > Add initial driver to support flash LED module found in Qualcomm > Technologies, Inc. PMICs. The flash module can have 3 or 4 channels > and each channel can be controlled indepedently and support full scale > current up to 1.5 A. It also supports connecting two channels together > to supply one LED component with full scale current up to 2 A. In that > case, the current will be split on each channel symmetrically and the > channels will be enabled and disabled at the same time. > > Signed-off-by: Fenglin Wu > Tested-by: Luca Weiss # sm7225-fairphone-fp4 += pm6150l > --- > drivers/leds/flash/Kconfig | 15 + > drivers/leds/flash/Makefile | 1 + > drivers/leds/flash/leds-qcom-flash.c | 700 +++++++++++++++++++++++++++ > 3 files changed, 716 insertions(+) > create mode 100644 drivers/leds/flash/leds-qcom-flash.c > > +static const struct of_device_id qcom_flash_led_match_table[] =3D { > + { .compatible =3D "qcom,spmi-flash-led" }, > + { } > +}; Dylan has noticed that auto-loading the module based on dt match doesn't work currently. It seems that this line is missing here to enable that: MODULE_DEVICE_TABLE(of, qcom_flash_led_match_table); Please add it for v5! Regards Luca > + > +static struct platform_driver qcom_flash_led_driver =3D { > + .driver =3D { > + .name =3D "leds-qcom-flash", > + .of_match_table =3D qcom_flash_led_match_table, > + }, > + .probe =3D qcom_flash_led_probe, > + .remove =3D qcom_flash_led_remove, > +}; > + > +module_platform_driver(qcom_flash_led_driver); > + > +MODULE_DESCRIPTION("QCOM Flash LED driver"); > +MODULE_LICENSE("GPL"); > --=20 > 2.25.1