From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2087C4332F for ; Mon, 21 Nov 2022 07:43:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229984AbiKUHnP (ORCPT ); Mon, 21 Nov 2022 02:43:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229995AbiKUHnE (ORCPT ); Mon, 21 Nov 2022 02:43:04 -0500 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C733EAB for ; Sun, 20 Nov 2022 23:43:02 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id x102so15084181ede.0 for ; Sun, 20 Nov 2022 23:43:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1TUVIyfnzpJrJjjktkuqFcVCWlSjqMueZ8oSh19wEx0=; b=u8HULqbgDO1V1jjNHkBZ+tyxbUE+H5slR0LHOlbfeZAo3EEj10DJVA0a7eNayrx8QE qkAIPnZN/1pyhj7djHgxGa6H6GOEPzp/BK4X9QN1iUaQzkZv42i3cBJppROe/Ej/iZ3E DrQx85QkfKzETnYKoXMc/xsfBK04j9UbGhery64BTRSdObqu0tUQYDhy/q1NdZpfw1aY 6ZBdw+RMjZ8k2siwz+RcwlWJnWHhxYnldUPd4gqHu6++LVwVBmdtRmk885K7XmSv09fm WbY3hF41oKOfCmenytGGcYFTMJYtm8wOhq+6nnTuT0a8an7eKvRjiv2AKO21kjqiN3Zo tiUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1TUVIyfnzpJrJjjktkuqFcVCWlSjqMueZ8oSh19wEx0=; b=KuPkzQhLYrA7FSncCjFONollamZ8Efd1QaJxzjmIfulSGSEZaKAaoPvols2xDEq97P TE0Z4TtAAxDCZxHxOzMvVenbe79U45spLcZZ/DdF77q2LiD7n3F8G2h8dhWhUS7YPmuD RKTn48ZVy+PkMUtdijtKVgPvqS8plxpe8kNF3WPklJdY+cwFSIq808qeWW7L1gdEukBc egG+HIVr1cTBptjXHZzqNX6WYi3Ytkx5IqqknH9Y/eMnmxQKOu6AlzZ5xa9g66+1GEYp ELVvPaw/bzN0UdVZNg2/q1MFrJCMEx7TV6qVOXARlZMkTbJb719OARay3YJtByE3JRi9 lrYw== X-Gm-Message-State: ANoB5plXbAKydQxa/Je1YfsTtHaS/6SRRIugz97TzTXdKuA4ooFbs/Hv 9uR86CkXRTUN68u42sMqUQJdjrvqjeswwQ== X-Google-Smtp-Source: AA0mqf70Zc1BNt2e8y7KjZG/3WSjRLleM/arnX0rg2ndkyr3oTK5dpqVHh4yYqJ77f04oWtSKx3tnA== X-Received: by 2002:a05:6402:2a09:b0:461:30d8:6742 with SMTP id ey9-20020a0564022a0900b0046130d86742mr14964115edb.172.1669016580728; Sun, 20 Nov 2022 23:43:00 -0800 (PST) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id e10-20020a170906648a00b007adade0e9easm4667280ejm.85.2022.11.20.23.42.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Nov 2022 23:42:59 -0800 (PST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 21 Nov 2022 08:42:58 +0100 Message-Id: Cc: , , , Subject: Re: [PATCH] interconnect: qcom: icc-rpmh: Fix an error handling path in qcom_icc_rpmh_probe() From: "Luca Weiss" To: "Christophe JAILLET" , "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Georgi Djakov" X-Mailer: aerc 0.13.0 References: In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Christophe, On Sun Nov 20, 2022 at 1:35 PM CET, Christophe JAILLET wrote: > If of_platform_populate() fails, some resources need to be freed as alrea= dy > done in the other error handling paths. > > Fixes: 57eb14779dfd ("interconnect: qcom: icc-rpmh: Support child NoC dev= ice probe") I believe the same needs to be applied to icc-rpm.c. Also there shouldn't be an empty line here between Fixes: and Signed-off-by= : Regards Luca > > Signed-off-by: Christophe JAILLET > --- > drivers/interconnect/qcom/icc-rpmh.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/interconnect/qcom/icc-rpmh.c b/drivers/interconnect/= qcom/icc-rpmh.c > index fd17291c61eb..5168bbf3d92f 100644 > --- a/drivers/interconnect/qcom/icc-rpmh.c > +++ b/drivers/interconnect/qcom/icc-rpmh.c > @@ -235,8 +235,11 @@ int qcom_icc_rpmh_probe(struct platform_device *pdev= ) > platform_set_drvdata(pdev, qp); > =20 > /* Populate child NoC devices if any */ > - if (of_get_child_count(dev->of_node) > 0) > - return of_platform_populate(dev->of_node, NULL, NULL, dev); > + if (of_get_child_count(dev->of_node) > 0) { > + ret =3D of_platform_populate(dev->of_node, NULL, NULL, dev); > + if (ret) > + goto err; > + } > =20 > return 0; > err: > --=20 > 2.34.1