From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE7F2C6FA8F for ; Wed, 30 Aug 2023 18:32:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235553AbjH3ScV (ORCPT ); Wed, 30 Aug 2023 14:32:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245189AbjH3OoC (ORCPT ); Wed, 30 Aug 2023 10:44:02 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39E24198 for ; Wed, 30 Aug 2023 07:43:57 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50091b91a83so8797426e87.3 for ; Wed, 30 Aug 2023 07:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1693406635; x=1694011435; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7y1PTlMIpI19ndr06GdGR/gezHXVIuarLmJLhteMMeY=; b=LYzzjbHgvGqKeGAc0j1Jmdyyz6FO1+DODQ4KJ9WUt6w2aRG++2plKYtoEyWxDiX8en lHIkhRnCXgg9AJdb2BHPr5i1HXPeYojczAsnVzbWKiQgsSqlkT6VcV6QoT3xyGm92WGP n5LhkCdaqb9m5AK9vgcTV1mWYC1HQy9F1DxjIkiF3zrEE8d5yy1jNscF8ER54RpbOkRb hqD0Hsu/kkelpidCNm5Zpe4GU/tK9JrNiInNtl16JLxRkvwcU2PSzwkn7bE/57iOKCWA J4Js6VPp5/baHjwIzrLzIsNWRTdMhRSG/CMSeVqmUfApjrXFRNKqQzx+TZcwj9qEUWec N5/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693406635; x=1694011435; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7y1PTlMIpI19ndr06GdGR/gezHXVIuarLmJLhteMMeY=; b=HN6JJe3bTJCtG3NHZGysFRsQZzQG9lKT53s8LfbjUT+9oxVbkSgG38OxyWbha02dG8 fLBWaj8wcCw/TgzRLcOQSiXkXJGzDlxehqADSbK/wHe6m6LgNRodfFkp1exgA5TBdetX PILW2/DiOBZ9wRuOfPm0LHE/V1GAOnTHZ3Iy5xDoPolyag5DqLpIoYcTYPGjnT4Ohz+L BNkyjhAUhKCkdCMcyBAuQ8D6XQTzT+GP6tV+vQBhAvK8iLtfYN4uSeUGNGQXPKDXwNis krX86dBuQzMHIloa8MxS8O6e/8QDeqkUeMBUDOM/Hc9UGg6lp6/FeYNHP4ntqhctbcBV C9dQ== X-Gm-Message-State: AOJu0YzF3HE92oXnxmn/L0G2smkE55RHAUmA29t2nnTSPgXa2KwYePPo +C7Mf2A8zQfd1BebZ4A+pY7nZg== X-Google-Smtp-Source: AGHT+IHeygykVFMcBkeCr9Jim8Aiw37Bu4dqw61S/Zwn8g9GABuB2bPsegjI40haOVmM0BZ3MWr+/Q== X-Received: by 2002:a19:5e18:0:b0:500:95f7:c416 with SMTP id s24-20020a195e18000000b0050095f7c416mr1823828lfb.7.1693406634763; Wed, 30 Aug 2023 07:43:54 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id l15-20020aa7d94f000000b0052568bf9411sm6787493eds.68.2023.08.30.07.43.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Aug 2023 07:43:54 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 30 Aug 2023 16:43:53 +0200 Message-Id: Cc: , "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Srinivas Kandagatla" , "Linus Walleij" , "Rafael J. Wysocki" , "Viresh Kumar" , <~postmarketos/upstreaming@lists.sr.ht>, , , , , , Subject: Re: [PATCH 02/11] nvmem: qfprom: Mark core clk as optional From: "Luca Weiss" To: "Doug Anderson" X-Mailer: aerc 0.15.2 References: <20230830-fp5-initial-v1-0-5a954519bbad@fairphone.com> <20230830-fp5-initial-v1-2-5a954519bbad@fairphone.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed Aug 30, 2023 at 4:30 PM CEST, Doug Anderson wrote: > Hi, > > On Wed, Aug 30, 2023 at 2:58=E2=80=AFAM Luca Weiss wrote: > > > > On some platforms like sc7280 on non-ChromeOS devices the core clock > > cannot be touched by Linux so we cannot provide it. Mark it as optional > > as accessing qfprom works without it. > > > > Signed-off-by: Luca Weiss > > --- > > drivers/nvmem/qfprom.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Are you actually testing burning fuses from the OS, or are you just > using the nvmem in "read-only" mode? From comments in the bindings, if > you're trying to burn the fuses then the clock is required. If things > are in read-only mode then the clock isn't required. Hi Doug, I definitely don't plan on burning any fuses on this phone. Not even sure that's allowed by the TZ / boot stack. > > When I compare to the driver, it seems like the driver assumes that if > more than one memory region is provided then you must be supporting > burning fuses. The bindings agree that having 4 memory regions > specified means that the nvmem supports burning and 1 memory region > specified means read-only. The extra 3 memory regions in the nvmem are > all about fuse burning, I believe. > > So maybe the right fix here is to just change your dts to specify one > memory region? I got feedback from Konrad that this here would be the preferred approach compared to having a different dts for ChromeOS vs non-ChromeOS devices. I don't feel strongly to either, for me it's also okay to remove the extra memory regions and only have the main one used on regular qcom devices. Let me know what you think. Regards Luca > > -Doug