From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F3DC4708E for ; Mon, 30 Oct 2023 14:43:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233500AbjJ3Onp (ORCPT ); Mon, 30 Oct 2023 10:43:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233469AbjJ3Ono (ORCPT ); Mon, 30 Oct 2023 10:43:44 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E6EADA for ; Mon, 30 Oct 2023 07:43:40 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9c5b313b3ffso684445366b.0 for ; Mon, 30 Oct 2023 07:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1698677019; x=1699281819; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4nwo0UYDV4o06Mzw9WU2DYO+XxHpuorjy7eMshi09Lk=; b=2OESjA41F9aeEf4pRwy2E815bTZti3+39VGllMtCc00lpc549g4Kom0Y10M4gYNSHE ZNNQO+cBqrmBAAY5Muk0aP3CieqiTm15yOXfQWi2heAHGoBiLLhaPDvzJJpF8/8J1pq9 IfwnXst+MYR7Yw4pKDevoffkybX6f88HiXfMSuxsd3Rvf5HjC8bpCJndcpPBGRpkJeVQ yZKXZ2q9x43/LRasiJs110sx0Qrjh0aDNioGGiImAIaCZDH9P5Z48uGmCUZ4X+ZggN/w wgGvEdKoZqiFKrh2doJi92eCWe+84dJHd0h4AUXuxgF6AXYG6n6714VYUiyszgdVIhF5 LU4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698677019; x=1699281819; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4nwo0UYDV4o06Mzw9WU2DYO+XxHpuorjy7eMshi09Lk=; b=jEbhC/vBMOVhoLSOi/0QIKzdG5rV2JqBwAKhJkedLarEUx7g2apf90rOF3wraXovnb wuZp1EHncLxN+TGq09keYQTcJQ2qNFOnINoUb0oDOa4MD9CCswDIEgn7M9bYEAnCYAVE 8sL08Yh9O54GXf8i5oAaLRDh0o8+Bw8AvOCE/6abP8/llx0U4sPTmlkzg1UPMPDs5nwu DkhKwyqLbPq5f48Y7f/rOuRDVOESrCSF6AUtA3EFdC3hHyz/4sWbKgpvdNLo7GG0sc0A wJxdJ1ALHFXccPv7146IYlASN88/R1ngJ+IqasbtBHWOJzh6ymU+r6jfbevhxMPuBEe0 4pGw== X-Gm-Message-State: AOJu0Yz8lqyMc/tsP4elm1UhSze56dhbwP7kUuXFDuRr5a0feH0J/H/y i0JGz0owrkR1hm0GafTQSNSOag== X-Google-Smtp-Source: AGHT+IFyhSMzoVuE7IRbjjhWsmhUnwHwbqzbPgJdBWIPhNuv82ntn1Jnq5yfajDSWdfDcVkYhUZKCA== X-Received: by 2002:a17:906:38e:b0:9d3:8d1e:cee with SMTP id b14-20020a170906038e00b009d38d1e0ceemr2667017eja.70.1698677018573; Mon, 30 Oct 2023 07:43:38 -0700 (PDT) Received: from localhost (k10064.upc-k.chello.nl. [62.108.10.64]) by smtp.gmail.com with ESMTPSA id n11-20020a170906b30b00b00989828a42e8sm6035976ejz.154.2023.10.30.07.43.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Oct 2023 07:43:38 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 30 Oct 2023 15:43:37 +0100 Message-Id: Cc: "Mukesh Ojha" , "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Mathieu Poirier" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Manivannan Sadhasivam" , , <~postmarketos/upstreaming@lists.sr.ht>, , "Krzysztof Kozlowski" , "Rob Herring" , =?utf-8?q?Matti_Lehtim=C3=A4ki?= , , , , Subject: Re: [PATCH 7/9] arm64: dts: qcom: sc7280: Add CDSP node From: "Luca Weiss" To: "Doug Anderson" X-Mailer: aerc 0.15.2 References: <20231027-sc7280-remoteprocs-v1-0-05ce95d9315a@fairphone.com> <20231027-sc7280-remoteprocs-v1-7-05ce95d9315a@fairphone.com> <7934a36a-9438-719a-2ed0-4a78757b044b@quicinc.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon Oct 30, 2023 at 3:11 PM CET, Doug Anderson wrote: > Hi, > > On Mon, Oct 30, 2023 at 2:12=E2=80=AFAM Luca Weiss wrote: > > > > On Mon Oct 30, 2023 at 10:04 AM CET, Mukesh Ojha wrote: > > > > > > > > > On 10/27/2023 7:50 PM, Luca Weiss wrote: > > > > Add the node for the ADSP found on the SC7280 SoC, using standard > > > > Qualcomm firmware. > > > > > > > > The memory region for sc7280-chrome-common.dtsi is taken from msm-5= .4 > > > > yupik.dtsi since the other areas also seem to match that file there= , > > > > though I cannot be sure there. > > > > > > > > Signed-off-by: Luca Weiss > > > > --- > > > > arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 5 + > > > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 138 ++++++++= +++++++++++++ > > > > 2 files changed, 143 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi b/a= rch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi > > > > index eb55616e0892..6e5a9d4c1fda 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi > > > > @@ -29,6 +29,11 @@ adsp_mem: memory@86700000 { > > > > no-map; > > > > }; > > > > > > > > + cdsp_mem: memory@88f00000 { > > > > + reg =3D <0x0 0x88f00000 0x0 0x1e00000>; > > > > + no-map; > > > > + }; > > > > + > > > > > > Just a question, why to do it here, if chrome does not use this ? > > > > Other memory regions in sc7280.dtsi also get referenced but not actuall= y > > defined in that file, like mpss_mem and wpss_mem. Alternatively we can > > also try and solve this differently, but then we should probably also > > adjust mpss and wpss to be consistent. > > > > Apart from either declaring cdsp_mem in sc7280.dtsi or > > "/delete-property/ memory-region;" for CDSP I don't really have better > > ideas though. > > > > I also imagine these ChromeOS devices will want to enable cdsp at some > > point but I don't know any plans there. > > Given that "remoteproc_cdsp" has status "disabled" in the dtsi, it > feels like the dtsi shouldn't be reserving memory. I guess maybe > memory regions can't be status "disabled"? Hi Doug, That's how it works in really any qcom dtsi though. I think in most/all cases normally the reserved-memory is already declared in the SoC dtsi file and also used with the memory-region property. I wouldn't be against adjusting sc7280.dtsi to match the way it's done in the other dtsi files though, so to have all the required labels already defined in the dtsi so it doesn't rely on these labels being defined in the device dts. In other words, currently if you include sc7280.dtsi and try to build, you first have to define the labels mpss_mem and wpss_mem (after this patch series also cdsp_mem and adsp_mem) for it to build. I'm quite neutral either way, let me know :) Regards Luca > > -Doug