From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B4F51BC26 for ; Tue, 16 Jan 2024 12:37:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="nDmo+7CC" Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-559bd483877so307827a12.0 for ; Tue, 16 Jan 2024 04:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1705408649; x=1706013449; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q4mR1emV7e4VKpQPCJz2Hf3qZyAbmUfMxUA9APfw/1A=; b=nDmo+7CCW7wTWjA4SG685v+agP9O90TA4sZDtBINVaAnPQ78CHyq6RetuEJlek1HM1 6wxRtLg+MwXgZjPSNkm8a7/NoW1WT4FSNVajlM9Vz3uhcvIBbhGK8S63b7XkbeMtZWuI 8Ig1OpYsZUJis6T71iiveTt3GoBwxMM7K2C0AwnY8O+S8UeYt309MbrdOMiT4WVeGxVB UkLPdjp8gSlhajm46wZTuPLe09nrp8E9rlFuEm/wZkpnlJ0zK3p85bcyTAs87LobQj2J nMCzngu+H+/t679oABVM/aC1NfuWsiNcdpEUJnN3pDRpPhVEc2O7ayUbba0On29a5gpe 6NGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705408649; x=1706013449; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Q4mR1emV7e4VKpQPCJz2Hf3qZyAbmUfMxUA9APfw/1A=; b=lGKYVH398KHQ1husjIkPyRGVl5RKCjL2Vx7OGzrg5Vw7b9LLLcvSrkaug6XpYzmW9M mVeHlDIXjN2j74nWWKsxZ++h78P3JAVHgLexGDVcQ4rLXLZ6bYe+EaDb1yal4X8fB3ei reTlX844l5sDSEyaUwdbJ6V7xQSTlhJZaqcph21sN8+rs+iv/TaGgR4GzXIJN2gKHBBt hhyN/AaLdyt6PxKF3+5Blh7cU3WBD3QJloUhdCPXsg4nQp4WoYuqfQYdLXFcNThj6Jen YPm9xHLzTxW01Shaa03hoAVdB/MPwVO0GdIoCmF+WFdQ/kRYDeB2kiyZdxpZl1bzR/dj pykQ== X-Gm-Message-State: AOJu0YwT/nZRDv0c/R65qKzSU8RozKta2J2tMocD+MoSte/kDXjVxE3o jGYcl4cBGKRryVyLC2OjnUMDvSE6jaoHGQ== X-Google-Smtp-Source: AGHT+IE8AuAnz/Y2vI48q1u6S5mFnUhMe9qfL9/aQfgOSuL4n2n1Q6uw/zPO4/FVy4CdLg0KBvQG1Q== X-Received: by 2002:a05:6402:8d3:b0:559:45ac:6750 with SMTP id d19-20020a05640208d300b0055945ac6750mr1876000edz.23.1705408649241; Tue, 16 Jan 2024 04:37:29 -0800 (PST) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id dj17-20020a05640231b100b00559bb146ecbsm284504edb.6.2024.01.16.04.37.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jan 2024 04:37:29 -0800 (PST) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 16 Jan 2024 13:37:28 +0100 Message-Id: Cc: "Amit Pundir" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "open list:ARM/QUALCOMM SUPPORT" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list" Subject: Re: [PATCH] arm64: dts: qcom: sdm845: Fix wild reboot during Antutu test From: "Luca Weiss" To: "Daniel Lezcano" , X-Mailer: aerc 0.15.2 References: <20240116115921.804185-1-daniel.lezcano@linaro.org> In-Reply-To: <20240116115921.804185-1-daniel.lezcano@linaro.org> On Tue Jan 16, 2024 at 12:59 PM CET, Daniel Lezcano wrote: > Running an Antutu benchmark makes the board to do a hard reboot. > > Cause: it appears the gpu-bottom and gpu-top temperature sensors are show= ing > too high temperatures, above 115=C2=B0C. > > Out of tree configuratons show the gpu thermal zone is configured to > be mitigated at 85=C2=B0C with devfreq. > > Add the DT snippet to enable the thermal mitigation on the sdm845 > based board. > > Fixes: c79800103eb18 ("arm64: dts: sdm845: Add gpu and gmu device nodes") > Cc: Amit Pundir > Signed-off-by: Daniel Lezcano A part of this is already included with this patch: https://lore.kernel.org/linux-arm-msm/20240102-topic-gpu_cooling-v1-4-fda30= c57e353@linaro.org/ Maybe rebase on top of that one and add the 85degC trip point or something? > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 32 ++++++++++++++++++++++++++-- > 1 file changed, 30 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/q= com/sdm845.dtsi > index c2244824355a..20fefd6af0f8 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -4764,6 +4764,8 @@ gpu: gpu@5000000 { > interconnects =3D <&mem_noc MASTER_GFX3D 0 &mem_noc SLAVE_EBI1 0>; > interconnect-names =3D "gfx-mem"; > =20 > + #cooling-cells =3D <2>; > + > status =3D "disabled"; > =20 > gpu_opp_table: opp-table { > @@ -5603,12 +5605,25 @@ gpu-top-thermal { > thermal-sensors =3D <&tsens0 11>; > =20 > trips { > - gpu1_alert0: trip-point0 { > + gpu1_alert0: trip-point0 { > + temperature =3D <85000>; > + hysteresis =3D <2000>; > + type =3D "passive"; > + }; > + The indentation here should use tabs not spaces. > + gpu1_alert1: trip-point1 { > temperature =3D <90000>; > hysteresis =3D <2000>; > type =3D "hot"; > }; > }; > + > + cooling-maps { > + map0 { > + trip =3D <&gpu1_alert0>; > + cooling-device =3D <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > =20 > gpu-bottom-thermal { > @@ -5618,12 +5633,25 @@ gpu-bottom-thermal { > thermal-sensors =3D <&tsens0 12>; > =20 > trips { > - gpu2_alert0: trip-point0 { > + gpu2_alert0: trip-point0 { > + temperature =3D <85000>; > + hysteresis =3D <2000>; > + type =3D "passive"; > + }; > + > + gpu2_alert1: trip-point1 { > temperature =3D <90000>; > hysteresis =3D <2000>; > type =3D "hot"; > }; > }; > + > + cooling-maps { > + map0 { > + trip =3D <&gpu2_alert0>; > + cooling-device =3D <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > =20 > aoss1-thermal {