From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Georgi Djakov" <djakov@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Artur Świgoń" <a.swigon@samsung.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] interconnect: constify of_phandle_args in xlate
Date: Mon, 19 Feb 2024 17:27:28 +0100 [thread overview]
Message-ID: <CZ973FMYMJAO.PQ0Z5YLXZPPM@gmail.com> (raw)
In-Reply-To: <41e371f1-96f4-45c0-9f65-81ed6924b325@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1679 bytes --]
On Fri Feb 16, 2024 at 2:59 PM CET, Krzysztof Kozlowski wrote:
> On 16/02/2024 14:55, Konrad Dybcio wrote:
> > On 16.02.2024 14:52, Krzysztof Kozlowski wrote:
> >> The xlate callbacks are supposed to translate of_phandle_args to proper
> >> provider without modifying the of_phandle_args. Make the argument
> >> pointer to const for code safety and readability.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >> drivers/gpio/gpiolib-of.c | 2 +-
> >> drivers/interconnect/core.c | 4 ++--
> >> drivers/interconnect/qcom/icc-common.c | 3 ++-
> >> drivers/interconnect/qcom/icc-common.h | 3 ++-
> >> drivers/interconnect/samsung/exynos.c | 2 +-
> >> drivers/memory/tegra/mc.c | 2 +-
> >> drivers/memory/tegra/tegra124-emc.c | 2 +-
> >> drivers/memory/tegra/tegra124.c | 2 +-
> >> drivers/memory/tegra/tegra186-emc.c | 2 +-
> >> drivers/memory/tegra/tegra20-emc.c | 2 +-
> >> drivers/memory/tegra/tegra20.c | 2 +-
> >> drivers/memory/tegra/tegra30-emc.c | 2 +-
> >> drivers/memory/tegra/tegra30.c | 2 +-
> >> include/linux/interconnect-provider.h | 11 ++++++-----
> >> include/soc/tegra/mc.h | 7 ++++---
> >
> > Ended up being a bit wider than just icc..
> >
> > Looks sane apart from that
>
> Tegra memory controllers are also interconnect providers, so two subsystems.
>
> This patch should go via interconnect tree.
I think Konrad might have been referring to the GPIO hunk, which seems
out of place. For the Tegra parts, though:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-02-19 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 13:52 [PATCH] interconnect: constify of_phandle_args in xlate Krzysztof Kozlowski
2024-02-16 13:55 ` Konrad Dybcio
2024-02-16 13:59 ` Krzysztof Kozlowski
2024-02-19 16:27 ` Thierry Reding [this message]
2024-02-20 6:59 ` Krzysztof Kozlowski
2024-02-16 13:56 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZ973FMYMJAO.PQ0Z5YLXZPPM@gmail.com \
--to=thierry.reding@gmail.com \
--cc=a.swigon@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=brgl@bgdev.pl \
--cc=djakov@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).