From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Fenglin Wu" <quic_fenglinw@quicinc.com>
Cc: <~postmarketos/upstreaming@lists.sr.ht>,
<phone-devel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: qcom: pmi632: Add vibrator
Date: Thu, 18 Apr 2024 12:03:10 +0200 [thread overview]
Message-ID: <D0N5VCESMRIX.3MY64A0MXKJGW@fairphone.com> (raw)
In-Reply-To: <c1763d69-f0a4-4415-be7a-31b04153fbfb@linaro.org>
On Thu Apr 18, 2024 at 12:01 PM CEST, Konrad Dybcio wrote:
> On 18.04.2024 8:36 AM, Luca Weiss wrote:
> > Add a node for the vibrator module found inside the PMI632.
> >
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > ---
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> On a side note, this is a totally configuration-free peripheral that doesn't do
> anything crazy until manually configured.
>
> In the slow quest to be (hopefully) more sane about the defaults, should we keep
> them enabled by default? Bjorn?
But many (most?) devices don't have a vibration motor connected to
PMI632, some (like devboards) don't have anything, and other phones have
a separate chip that controls the vibration motor.
Enabling this by default would mean all devices with PMI632 would get an
input device for the vibrator that probably doesn't work?
Regards
Luca
>
> Konrad
next prev parent reply other threads:[~2024-04-18 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 6:36 [PATCH 0/2] Enable vibrator on PMI632 + Fairphone 3 Luca Weiss
2024-04-18 6:36 ` [PATCH 1/2] arm64: dts: qcom: pmi632: Add vibrator Luca Weiss
2024-04-18 10:01 ` Konrad Dybcio
2024-04-18 10:03 ` Luca Weiss [this message]
2024-04-22 22:43 ` Konrad Dybcio
2024-04-18 6:36 ` [PATCH 2/2] arm64: dts: qcom: sdm632-fairphone-fp3: Enable vibrator Luca Weiss
2024-05-29 2:01 ` [PATCH 0/2] Enable vibrator on PMI632 + Fairphone 3 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0N5VCESMRIX.3MY64A0MXKJGW@fairphone.com \
--to=luca.weiss@fairphone.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=quic_fenglinw@quicinc.com \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox