From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18E751F949 for ; Wed, 13 Nov 2024 08:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731484992; cv=none; b=WOOpgGT4OyeZdWTEr9r3wPF7vt31YAHebLP1csaXDSdlbkenzkt1tW2l0gGelUbuEbtbJi8EWr3pxh4TeyK04CQyGS13TW78fTZ3cwOEpwHuAUn/oQXo3M3OzkE1hToYGeNfkUVsgnahE30ReobSjdEV3wBgevBCdXgBOXAaPdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731484992; c=relaxed/simple; bh=JtfJ/M8Fde3sq0t/X0kZEogyBD+h5DUxk1EyzuQfIiQ=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=B7Fb7HCh85htDXksbZGVDTS7FGmyFPP0CUNGy1QRIYNmeTeGvGz6h/pKEa0At2qYjlorZmbw7hTLbkY4pGmV1Jc7/4DLZZXPONiJmC69IkKoTeCz82C+vfUab1PEerWF+GrZBRfnsyk8xqSS11jbqpmvJoMqOH3tS9Py4WN4L9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=5mQfxZnW; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="5mQfxZnW" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-37d462c91a9so4164188f8f.2 for ; Wed, 13 Nov 2024 00:03:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1731484988; x=1732089788; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jKyYktRQuJ/QeBC58+VEnoyS7t9UdeFDO97IPToRn1c=; b=5mQfxZnWHR/zupZge//HJjN9lGSuo9Zau6+Dm1sAiKsUlpnk5fyvD79V1fUJ3mk85M qFv02UpglU0aAjHWLp8tJQE54wpqxT+ny3q8TMl7MV5VUDQCIMs4AsnqBtieuADmlONN 7IP7ihPjPxvpJshQwck/36tvUiYp8oyMkXqdTm9FaHendhoDu2yLXxmeYKPwrbEK/rHX E4UxKOyVzQZKO9jbxzfXsjR9CsnZ0O8GZ5ADXKJOqtEV9PGnCpwQuittgOdgytQ7jIgt QAjwFkMGeRv6meR1ymtRBagZeVYfT8Jtd9RlJeaVVL+/6Qwvr2dMw1AQputrV2hrViv/ L4WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731484988; x=1732089788; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jKyYktRQuJ/QeBC58+VEnoyS7t9UdeFDO97IPToRn1c=; b=dmqnbl6vdSxxxpec9zwSgqTQgmgLQGA2Q/IDSARrmA7Zb1Kmi3EU9Ya9FPHQ7n9TAR 2r/zJdoYP2QIrOtjUmasjHXfIol9MHOn+eOLGV6JHKuEPlgJeBwefuDncWD+uKwxXKqI 5W4FW9BoydhIEOvgDi8g9utU1Ku2O4c0S0ltGdhB8LE22eQGZFysuZwMlmICcrq3YmZ4 KjU2KEJ1H4d+zVO3wu1IKFbLRbMBPaQkynHZQhFd5hUgZkci9oeaznANVHfqRMRSKuxi YkqNiNk4Pdn0qDfaWVG1h36XR5Q+ItblJTAB/r9UoPhGO5qxWd7R2g114oTHJKEaP0GG tQhA== X-Forwarded-Encrypted: i=1; AJvYcCWY4LthxlDW+SXsIUPDgRoC5ti///2CNo3quSp0CHJQ/ZGwssfVGDXyQ5GeZ1FKNRk7c8GmqwmzuiNqA7lI@vger.kernel.org X-Gm-Message-State: AOJu0YwrtDD+nXQ63KB4kVpLglLXYtK4HOSYIAr/ARZFOXyHrT5gWDJd JuX5xAdofesjFQuCscuUs905ILJEoX6Ii+JKibXQx5ZgIL7SwSc9TpWym6hv31Y= X-Google-Smtp-Source: AGHT+IFOEcn5QjxpPu724zso7ULSYt3uZMMHchhIsaHCQRGB1Ui88bJ4YmB3X+sf4mSWdm4RywdtVA== X-Received: by 2002:a5d:6daa:0:b0:37d:377d:c7b0 with SMTP id ffacd0b85a97d-38208110ab8mr4231577f8f.18.1731484988382; Wed, 13 Nov 2024 00:03:08 -0800 (PST) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381eda03e8asm17571508f8f.90.2024.11.13.00.03.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Nov 2024 00:03:08 -0800 (PST) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 13 Nov 2024 09:03:07 +0100 Message-Id: To: "Vedang Nagar" , "Dmitry Baryshkov" Cc: , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , , , , "Vikash Garodia (QUIC)" Subject: Re: [PATCH] arm64: dts: qcom: sc7280: enable venus node From: "Luca Weiss" X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20241004-venus_sc7280-v1-1-4d7d8fd7e95b@quicinc.com> <78e6ff6b-efe1-496c-a1fb-c9a0a4aba2d2@quicinc.com> <39206687-6fb3-434f-b2ba-a028cf6f8ed3@quicinc.com> In-Reply-To: <39206687-6fb3-434f-b2ba-a028cf6f8ed3@quicinc.com> Hi Vedang, On Wed Nov 13, 2024 at 8:01 AM CET, Vedang Nagar wrote: > Hi Luca, > On 11/12/2024 8:49 PM, Luca Weiss wrote: > > Hi Vedang, > >=20 > > On Tue Nov 12, 2024 at 3:39 PM CET, Vedang Nagar wrote: > >> > >> > >> On 11/12/2024 6:43 PM, Dmitry Baryshkov wrote: > >>> On Tue, 12 Nov 2024 at 08:17, Vedang Nagar = wrote: > >>>> > >>>> > >>>> > >>>> On 10/7/2024 1:20 AM, Dmitry Baryshkov wrote: > >>>>> On Fri, Oct 04, 2024 at 04:22:31PM GMT, Vedang Nagar wrote: > >>>>>> Enable the venus node on Qualcomm sc7280. It was made disabled > >>>>>> earlier to avoid bootup crash, which is fixed now with [1]. > >>>>> > >>>>> NAK, there might be other reasons to keep venus disabled, like the = lack > >>>>> of the vendor-signed firmware for the particular device. > >>>> Can you pls elaborate more on this? Any device with sc7280 SOC can u= se > >>>> venus.mbn which is already present in linux-firmware git. > >>> > >>> Can it though if the device is fused to use vendor keys and to check > >>> the trust chain? > >> Yes, infact the existing ones are signed and works with trustzone auth= entication. > >=20 > > No, the venus firmware from linux-firmware does not work on a device > > with secure boot on, like the (QCM6490) Fairphone 5 smartphone. > Are you saying even after applying this [1] you are seeing the same ? > > [1] > https://patchwork.kernel.org/project/linux-media/patch/20231201-sc7280-ve= nus-pas-v3-2-bc132dc5fc30@fairphone.com/ That patch has been in mainline since v6.9 and my tree is newer, so yes. See e.g. Qualcomm doc KBA-161204232438 for some details. Regards Luca > >=20 > > $ rm /lib/firmware/qcom/qcm6490/fairphone5/venus.mbn > > $ cp /lib/firmware/qcom/vpu-2.0/venus.mbn.zst /lib/firmware/qcom/qcm649= 0/fairphone5/venus.mbn.zst > >=20 > > leads to > >=20 > > [ 10.848191] qcom-venus aa00000.video-codec: Adding to iommu group 13 > > [ 10.863062] qcom-venus aa00000.video-codec: non legacy binding > > [ 10.909555] qcom-venus aa00000.video-codec: error -22 initializing f= irmware qcom/qcm6490/fairphone5/venus.mbn > > [ 10.910099] qcom-venus aa00000.video-codec: fail to load video firmw= are > > [ 10.910849] qcom-venus aa00000.video-codec: probe with driver qcom-v= enus failed with error -22 > >=20 > > It's the same with e.g. adsp firmware, modem firmware, etc. > >=20 > > With secure boot off, yes, the hardware will load any firmware > > regardless of the signature. > >=20 > > Regards > > Luca > >=20 > >>> > >>>> > >>>> Regards, > >>>> Vedang Nagar > >>>>> > >>>>>> > >>>>>> [1] > >>>>>> https://lore.kernel.org/linux-media/20231201-sc7280-venus-pas-v3-2= -bc132dc5fc30@fairphone.com/ > >>>>>> > >>>>>> Signed-off-by: Vedang Nagar > >>>>>> --- > >>>>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 -- > >>>>>> 1 file changed, 2 deletions(-) > >>>>> > >>> > >>> > >>> > >=20