From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCC5428466E for ; Wed, 28 May 2025 12:20:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748434821; cv=none; b=OM/i8Fqt2e7WTRa6CoiFX6AQhhyVhqyccTkM8kSgQD3b8//6AifN02rWF0W/Jk+7mvizpbX9AHe0VIT6BG/VtXEG3Olwi8deL2saRgpYBrB6cZ9xBVM88KHUL3YPUDIMKEck5pyXhqvVm+l76p4DrYTPxygOM2sL592zYlRgSr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748434821; c=relaxed/simple; bh=LgluqXTAQPOxJPKju8Bo8ViAFRC7s0F2a9tFXlqvtIo=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=lEJjmDC4cvpt2q/C/z//0E1oiKlnECJ2n8Prck3UiAjpZtdTfqBvkxYE1nrZ5N/vMYJ7mAYLaIzG/EXZ6HmcF3ckNsV2htMFsAYd0wmY0i68d00DckvcukHwBD49zjAZQZQFi/+2zKBCtwghli1ce0c3fqBu0FbFuwpUDoFxXQg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Up9MwRuH; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Up9MwRuH" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-442d146a1aaso50958565e9.1 for ; Wed, 28 May 2025 05:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748434818; x=1749039618; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nUiSIyBK9bnL6y5jkIEyCSHfBFQ4eE1Z0A1Z3a6M0aM=; b=Up9MwRuHNjPw1rlRQzUew66x7qEPzJiY9UVqJhwvtqIf0Eyo8lBQCHqtWdrA5m9oYE cQuPLlhoGUjI1pgVqE+wE/s544dc0VOLMRzLVEmaDPWy9BpuDGjDTlWu7NHnXkeqYYDi LS/N2aq0Q5HHtM26h+IwOruFH3o0lEwdzLbpOu8LTAoMEIQUmLpzyomxAMNSLuLFe+l+ hN1kFmpyq4xM5UYNtEbrl0NZjqmb8dCbT0mXGc0ahpMwuiHfCCMu3MdqvNnqbNRXfM5M tx3XGeVV7oXENS2jWvJto04TScoaNtoDRPUeSBNGT2V7MU+bmGc+wOKiTULLKBme1g96 wzOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748434818; x=1749039618; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nUiSIyBK9bnL6y5jkIEyCSHfBFQ4eE1Z0A1Z3a6M0aM=; b=GMUXiIa2PWJnxnjxxQVyxwGBcl972nX9FZ+JT100+DRytBfasNcwaB28rKhRBDom6r mhMlLX3uW4maTnwg/Cl7QdNBvSLpG1zf/uggF82gWqCLYdya+qPrS1zjFgVmLiW9K4oZ UGhqM217hcT0VJIRVPAQNGN6x7JA05eJG/sXcGUCncVo2AP9mHnC3jTD2kHW2HU3idtU ATHjS+Id13pcLv1FFr6GSsUUmFToRierXXrdKUIjJXkYVgox5hry7HCXGLA2GMYtwN0E i3wi51BMEFuAA5W+9noYcu5g3FTzMQx8HkNug09N2wUrk8Vs7bDK503Vu/rxQeMUpbQz MZ1A== X-Forwarded-Encrypted: i=1; AJvYcCVU7y7ELfVWsv9nolVv6tGwyxUvxV0AWsRy9+gl3qncipvciTnXguJxY6Cu+Fzgn0p05IBiGnYnI9/LvvKo@vger.kernel.org X-Gm-Message-State: AOJu0YxEmNIh2KNxiDafGon3aNy6t3tVdw1S3Pcyv0qKc6pOxOdcyR0W uBWBq4w0pCSPdmz8tRc3Kcss4nPZWa6+5Cfebfy7Wj3TuFASzKlBVrB69ZHrHJ+lPV4= X-Gm-Gg: ASbGncsetMzijik1LOQbL5DfvU0ED6GqMvozCMNl+x1pIsqdEzmIxGD6lfll0KoyfZ7 gyrJLEUu2VTj7k7RE4PrNoIjqfWHkizvtlbONcuTJO+nQ6+mUgEVYJ0Km2isGGdgwOmV2iFw/0+ B8Hud+LYwCzL8JdmfVQ9liLMAbuikYskchoXbdoh+0Ei/Y3HNzCqd5ZUYNTjkTUC0LPZjl2Z4rr 4RhJgw6wAw2nmtiyej1Y+AXJrV2NOimFJOYISeHfylZFtrVah+9PqtMzQjiCXPlXtCMFMjVwJeh GPzm6D1Q8SPBpysJeV/LY2BnAXNgk5YamCpQEIEzYaR1wLu6Yw6LKTeuZHJtX/rYFqA= X-Google-Smtp-Source: AGHT+IGZexNRqILydRhcO4IU4n98EZEdu0fFVjtfd4sxx1IIeEAtAXBTC1Us7iU6PxbqQgpjB0cAjw== X-Received: by 2002:a05:600c:3109:b0:43d:1b74:e89a with SMTP id 5b1f17b1804b1-44c941884eamr149032045e9.9.1748434817966; Wed, 28 May 2025 05:20:17 -0700 (PDT) Received: from localhost ([2a00:2381:fd67:101:6c39:59e6:b76d:825]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4507255b619sm15992525e9.22.2025.05.28.05.20.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 May 2025 05:20:17 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 28 May 2025 13:20:16 +0100 Message-Id: Cc: "Bjorn Andersson" , "Linus Walleij" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Srinivas Kandagatla" , "Liam Girdwood" , "Mark Brown" , "Konrad Dybcio" , , , , , , , Subject: Re: [PATCH v4 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec From: "Alexey Klimov" To: "Prasad Kumpatla" , "Mohammad Rafi Shaik" X-Mailer: aerc 0.20.0 References: <20250527111227.2318021-1-quic_pkumpatl@quicinc.com> <20250527111227.2318021-8-quic_pkumpatl@quicinc.com> In-Reply-To: <20250527111227.2318021-8-quic_pkumpatl@quicinc.com> On Tue May 27, 2025 at 12:12 PM BST, Prasad Kumpatla wrote: > From: Mohammad Rafi Shaik > > Add nodes for WSA8830 speakers and WCD9370 headset codec > on qcm6490-idp board. > > Enable lpass macros along with audio support pin controls. > > Signed-off-by: Mohammad Rafi Shaik > Co-developed-by: Prasad Kumpatla > Signed-off-by: Prasad Kumpatla > --- > arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 96 +++++++++++++++++++ > .../boot/dts/qcom/qcs6490-audioreach.dtsi | 24 +++++ > 2 files changed, 120 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/d= ts/qcom/qcm6490-idp.dts > index 7a155ef6492e..884abbda74fd 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > @@ -18,6 +18,7 @@ > #include "pm7325.dtsi" [..] > +&swr0 { > + status =3D "okay"; > + > + wcd937x_rx: codec@0,4 { > + compatible =3D "sdw20217010a00"; > + reg =3D <0 4>; > + qcom,rx-port-mapping =3D <1 2 3 4 5>; > + qcom,rx-channel-mapping =3D /bits/ 8 <1 2 1 1 2 1 1 2>; > + }; > +}; > + > +&swr1 { > + status =3D "okay"; > + > + wcd937x_tx: codec@0,3 { > + compatible =3D "sdw20217010a00"; > + reg =3D <0 3>; > + qcom,tx-port-mapping =3D <1 1 2 3>; > + qcom,tx-channel-mapping =3D /bits/ 8 <1 2 1 1 2 3 3 4 1 2 3 4>; It will be tremendously useful to add comments that elaborate the {rx,tx}-c= hannel-mapping (and port mapping for what it's worth) here like it is done in other dt fil= es. For example in the same way as it is done in sm8650-qrd.dts or like here: https://lore.kernel.org/linux-arm-msm/20250526-sm8750-audio-part-2-v3-3-744= 29c686bb1@linaro.org/ Best regards, Alexey