From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2069299AA3 for ; Wed, 8 Oct 2025 02:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759891248; cv=none; b=Ab6Gy11qcPgmnHOepbocPdOPMUUpkkpsrfFLGtYquI33LxPFfULnA/8lgsl8DlJWrLKkHGZIg6MSIV7ON2oXubYZimshSEn3NNd1vbhrzS1idmKn2eRS2elpDaeM6AROO+yARVIKsHKEXxqBoolt4CMNBAMyuYqIOehRI6bmlLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759891248; c=relaxed/simple; bh=vbpwXTejC+yajTX3XXncJGeds605AJHrgdSUCP7BbNs=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=AJ4L7wTmp3EIW5dKirqiarVL3LvqyVnTPM3jvANvMd46SUuserXyJl5FVPYTa9qy+q/9pPz7z73g7K2UbqiXo0u8nDOTtJI5U0frCFCk3N7wKxN5Qq7yob+mKVYW5cSVgqWnNJ9IR4+PLVlxeEs4K4UX3KClStevs3Y03shYUXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hTAdcuHp; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hTAdcuHp" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3fc36b99e92so304939f8f.0 for ; Tue, 07 Oct 2025 19:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759891245; x=1760496045; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vbpwXTejC+yajTX3XXncJGeds605AJHrgdSUCP7BbNs=; b=hTAdcuHpIxENGBpN9STA3bI7YsxHoTZ6EtRCkJqoMD/wiGNCAwTIKV7IsP8wPyG4bB U6GLpIU57vGx18Wjj4enoKZBERR5wmO+CeozzgXfVXfvblWakhfgees/6FpyeltmCUju r+vcJuwd/tQkQivDRtnhhfLFNyUpFiDRI8wWzWJph5fSpU5lb4/WfoN4XMlMK2tNKP4c q7vH969Hk7rYMvcGQmv2gquNNzh3cjb7FCO5O54XwwE3VQJr5H+Ly2ZHS94RxjpZKVZp Ty+Q+9JpswO9NMCEI7NDDv3pmVG0bz3NJfKPd27U5kJIHoTQcYK4lmCsqIRreMdBdLK6 1NOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759891245; x=1760496045; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vbpwXTejC+yajTX3XXncJGeds605AJHrgdSUCP7BbNs=; b=VTEVhiWB5vusk3DNba4kn6qo9ax/OKntsZrt7Mcg1HdWLc3yKcJM/INZ9FCGAr3Eoq SZ+DjwpSIgNv7+73QB5uXMXJ1CSOPLROAQtReV/oKWsXGnDpdxxJzXgnDlFpw7jWCByw VQE2m1yWACIl1nO8kxTJMFAuH9tiksGDfxTCZGi7mX5aZHFoRhwbOhBUGb+tY4m3XzqW wybF75f5eWRLNbfCi0ZPIHoS/Bwhl9vLyRGa//Zp+NauhP7tIG4XOWDIbGgXF4Dt6bRi iZSqlPgh/HC6YcK8WGPN9qXx1BcMR7j0dDgz4o5Lt4Xe7S7O6ZASBEJrRl1XpiVJSOud y+jg== X-Forwarded-Encrypted: i=1; AJvYcCUFAxelVCm7/7lKz7WIwkrwmWGLbwT5e00QhIemBIvyA4WWaeaqIpkhSULTuE+wO9KOdhcdyj0Ju/2b+6qi@vger.kernel.org X-Gm-Message-State: AOJu0YzTbZ/7oA7RpaCLXIhPTVZSs5Gn19+hiF0mW4K5JkvOAq659Z7h nzfGYoqjErvCbjQNA+esaVkh9tlQ7GrS6dHIxugq+emKlNLOLRBiFDXn0CiVoc/fpbI= X-Gm-Gg: ASbGncvBQRRaJraS4o9/z753xSfdQuKTZgq64NMbY3VI3iKadz1KAnSPZYpa9mNJCCH KHaOBdSaIgPDFcVh7ZkEU56Mz6JPGZNFsoPVkGuV3+01bghZ0idKZs6lQ49SkkY/SVpymrkoPvj 1VYbB2fYsONGax45/A/md7zcqu9D72/FCAPyoJqh0YAvB4Z+kph3qGaH4scNgYlrG0Ox1c1CfVl CNZWkT0l+fcPbHLNc1T4u31mulaghNmaxMtmqVCUA/ilEVcz4hgoO3EfhnT0wPahay04QmRCdrD yvK7PbDGSQxfW005o8bwvnY3T61GtGuJ2x4bXPQ1ZtpaW5fPCcrm5eJcJKuJ5UxoJZptBjZ/eSJ wKqDeji2yk/x0SqstRGqw4qa8bAB+k8BSSqR5n/Ya7WuSA6iWUNi/bYI= X-Google-Smtp-Source: AGHT+IFFqlDGt7h0nc+NuKrTo3pc2pheELlH3q2GeHR9OiCLFLF0nYVBjizloysNNRJBS6y4P310LA== X-Received: by 2002:a5d:584b:0:b0:3ee:3dce:f65f with SMTP id ffacd0b85a97d-425829e7935mr4259067f8f.14.1759891244667; Tue, 07 Oct 2025 19:40:44 -0700 (PDT) Received: from localhost ([2a02:c7c:7259:a00:8c32:dd4d:57f2:8be7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8e9724sm27496800f8f.28.2025.10.07.19.40.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Oct 2025 19:40:43 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 08 Oct 2025 03:40:42 +0100 Message-Id: Cc: "Jaroslav Kysela" , "Takashi Iwai" , "Dmitry Baryshkov" , , , , Subject: Re: [PATCH 1/2] dt-bindings: sound: qcom,sm8250: add QRB2210 and RB1 soundcards From: "Alexey Klimov" To: "Krzysztof Kozlowski" , "Srinivas Kandagatla" , "Liam Girdwood" , "Mark Brown" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" X-Mailer: aerc 0.20.0 References: <20251007-qrb2210-qcm2290-sndcard-v1-0-8222141bca79@linaro.org> <20251007-qrb2210-qcm2290-sndcard-v1-1-8222141bca79@linaro.org> <67e313d3-1f91-4205-8aec-fbbfa41004f2@kernel.org> In-Reply-To: <67e313d3-1f91-4205-8aec-fbbfa41004f2@kernel.org> On Tue Oct 7, 2025 at 2:45 AM BST, Krzysztof Kozlowski wrote: > On 07/10/2025 10:26, Alexey Klimov wrote: >> Add soundcard compatible for QRB2210 (QCM2290) platforms. >> While at this, also add QRB2210 RB1 entry which is set to be >> compatible with QRB2210 soundcard. > > > You explained here what you did, but you should explain why. I don't > quite get why SoC sound card and RB1 sound card are both needed. I would > just go with one. I wanted to go with none in the first place and just make it rb2 sndcard compatible (as a fallback). Then Dmitry suggested to follow other sndcards patterns and implmenet it like this. There is also at least one qrb2210/qcm2290-based board -- UNO Q and at this point I can't say if it will need separate compatble or can use qcom,qrb2210-sndcard as a fallback. > Please use subject prefixes matching the subsystem. For bindings, the > preferred subjects are explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-pat= ches.html#i-for-patch-submitters So the order in subject should be reversed. Got it. Thanks, Alexey